From mboxrd@z Thu Jan 1 00:00:00 1970 From: tanhuazhong Subject: Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring() Date: Mon, 29 Oct 2018 08:54:57 +0800 Message-ID: <939d1c9c-a2eb-d6a1-f3c2-caa1a858d947@huawei.com> References: <1540697651-22993-1-git-send-email-tanhuazhong@huawei.com> <1540697651-22993-6-git-send-email-tanhuazhong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Cc: , , , , , To: Sergei Shtylyov , Return-path: Received: from szxga04-in.huawei.com ([45.249.212.190]:14576 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725879AbeJ2Jl0 (ORCPT ); Mon, 29 Oct 2018 05:41:26 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018/10/28 16:09, Sergei Shtylyov wrote: > Hello! > > On 28.10.2018 6:34, Huazhong Tan wrote: > >> It is not necessary to reset the queue in the hns3_uninit_all_ring(), >> since the queue is stopped in the down operation, and will be reset >> in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING > >    Operation. > yes, sorry for my poor spelling >> flag in the hclge_reset_tqp() is not correct, because we need to reset >> tqp during pf reset, otherwise it may cause queue not be reset to > >    Not being reset? > yes, thanks. >> working state problem. >> >> Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver >> for hip08 SoC") >> Signed-off-by: Huazhong Tan > [...] > > MBR, Sergei > Greeting. Huazhong >