From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 36/38] net/dpaa: add support for checksum
	offload
Date: Wed, 28 Jun 2017 16:50:35 +0100
Message-ID: <93a8a45b-01d1-608d-f3df-92551df6e476@intel.com>
References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com>
 <1497591668-3320-37-git-send-email-shreyansh.jain@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: hemant.agrawal@nxp.com
To: Shreyansh Jain <shreyansh.jain@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 11AA12C13
 for <dev@dpdk.org>; Wed, 28 Jun 2017 17:50:37 +0200 (CEST)
In-Reply-To: <1497591668-3320-37-git-send-email-shreyansh.jain@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/16/2017 6:41 AM, Shreyansh Jain wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

<...>

> @@ -363,6 +439,18 @@ dpaa_eth_queue_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)
>  						}
>  						rte_pktmbuf_free(mbuf);
>  					}
> +					if (mbuf->ol_flags & DPAA_TX_CKSUM_OFFLOAD_MASK) {
> +						if (mbuf->data_off < DEFAULT_TX_ICEOF +
> +							sizeof(struct dpaa_eth_parse_results_t)) {
> +							PMD_DRV_LOG(DEBUG, "Checksum offload Err: "
> +								"Not enough Headroom "
> +								"space for correct Checksum offload."
> +								"So Calculating checksum in Software.");
> +							dpaa_checksum(mbuf);
> +						} else
> +							dpaa_checksum_offload(mbuf, &fd_arr[loop],
> +								mbuf->buf_addr);
> +					}

There is a tx_pkt_prepare() dev_ops.
Does it make sense to move this calculations to that function?

>  				} else {
>  					PMD_DRV_LOG(DEBUG, "Number of Segments not supported");
>  					/* Set frames_to_send & nb_bufs so that

<...>