From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NmnM5-0000lP-6N for qemu-devel@nongnu.org; Wed, 03 Mar 2010 07:07:09 -0500 Received: from [199.232.76.173] (port=53671 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NmnM4-0000l4-MG for qemu-devel@nongnu.org; Wed, 03 Mar 2010 07:07:08 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NmnM3-0005IC-HH for qemu-devel@nongnu.org; Wed, 03 Mar 2010 07:07:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11578) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NmnM3-0005I4-2n for qemu-devel@nongnu.org; Wed, 03 Mar 2010 07:07:07 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o23C76gN012875 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Mar 2010 07:07:06 -0500 From: Juan Quintela Date: Wed, 3 Mar 2010 13:06:52 +0100 Message-Id: <93c1dcb48b0cfa33775fc45a1ffb9c0edb44d833.1267617582.git.quintela@redhat.com> In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH 02/10] slirp: check system() success List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, amit.shah@redhat.com we shouldn't call W*() macros until we check that fork worked. Signed-off-by: Juan Quintela --- net/slirp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index 317cca7..7f846ec 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -472,7 +472,7 @@ static void slirp_smb_cleanup(SlirpState *s) if (s->smb_dir[0] != '\0') { snprintf(cmd, sizeof(cmd), "rm -rf %s", s->smb_dir); ret = system(cmd); - if (!WIFEXITED(ret)) { + if (ret == -1 || !WIFEXITED(ret)) { qemu_error("'%s' failed.\n", cmd); } else if (WEXITSTATUS(ret)) { qemu_error("'%s' failed. Error code: %d\n", -- 1.6.5.2