All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: James Hogan <james.hogan@imgtec.com>, qemu-devel@nongnu.org
Cc: Yongbok Kim <yongbok.kim@imgtec.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] mips: Add KVM T&E segment support for TCG
Date: Mon, 31 Jul 2017 13:47:48 -0700	[thread overview]
Message-ID: <93cb4cb7-842c-1a37-c2dd-a7c522076a1d@twiddle.net> (raw)
In-Reply-To: <ad80a5d3ff807996b3cdf70504cab7efd66c4295.1501506432.git-series.james.hogan@imgtec.com>

On 07/31/2017 06:09 AM, James Hogan wrote:
> +static int mips_um_ksegs;
> +
>   uint64_t cpu_mips_kseg0_to_phys(void *opaque, uint64_t addr)
>   {
>       return addr & 0x1fffffffll;
> @@ -38,3 +40,13 @@ uint64_t cpu_mips_kvm_um_phys_to_kseg0(void *opaque, uint64_t addr)
>   {
>       return addr | 0x40000000ll;
>   }
> +
> +int mips_um_ksegs_enabled(void)

bool?

Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

  reply	other threads:[~2017-07-31 20:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 13:09 [PATCH 0/2] mips: KVM T&E segment support for TCG James Hogan
2017-07-31 13:09 ` [Qemu-devel] " James Hogan
2017-07-31 13:09 ` [PATCH 1/2] mips: Improve segment defs for KVM T&E guests James Hogan
2017-07-31 13:09   ` [Qemu-devel] " James Hogan
2017-07-31 18:17   ` Philippe Mathieu-Daudé
2017-07-31 13:09 ` [PATCH 2/2] mips: Add KVM T&E segment support for TCG James Hogan
2017-07-31 13:09   ` [Qemu-devel] " James Hogan
2017-07-31 20:47   ` Richard Henderson [this message]
2017-07-31 21:36     ` James Hogan
2017-07-31 21:36       ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93cb4cb7-842c-1a37-c2dd-a7c522076a1d@twiddle.net \
    --to=rth@twiddle.net \
    --cc=aurelien@aurel32.net \
    --cc=james.hogan@imgtec.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yongbok.kim@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.