From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH 1/2] ipc: clearn up code Date: Fri, 20 Apr 2018 08:55:19 +0100 Message-ID: <93e616c5-292a-98ee-041b-462c098e90d0@intel.com> References: <1524187312-129804-1-git-send-email-jianfeng.tan@intel.com> <1524187312-129804-2-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: thomas@monjalon.net To: Jianfeng Tan , dev@dpdk.org Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 1CA247272 for ; Fri, 20 Apr 2018 09:55:23 +0200 (CEST) In-Reply-To: <1524187312-129804-2-git-send-email-jianfeng.tan@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20-Apr-18 2:21 AM, Jianfeng Tan wrote: > Following below commit, we change some internal function and variable > names: > commit ce3a7312357b ("eal: rename IPC request as synchronous one") > > Also use calloc to supersede malloc + memset for code clean up. > > Signed-off-by: Jianfeng Tan > --- In general, Acked-by: Anatoly Burakov However, i think it would be good to have it rebased/applied on top of IPC coverity fixes, in particular because this patch uses strcpy instead of instead of strlcpy. -- Thanks, Anatoly