From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D38B8C433F5 for ; Mon, 13 Dec 2021 03:28:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbhLMD23 (ORCPT ); Sun, 12 Dec 2021 22:28:29 -0500 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:24478 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbhLMD22 (ORCPT ); Sun, 12 Dec 2021 22:28:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1639366108; x=1670902108; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1iIGBwZfqdyU2oIDOWAaYh9Xk7ZCowRlfURdZiu48XQ=; b=yJG6j5HWnEj7IMLi2LoWbJ40vi1GkwXglYmqzdzYPm/cMB6iZXX9r3FK iFpryyfakHjGWyyagFT+slhOKKwv2POYO53JEJd0XtkBqTiPEFygEJ1Pe jwQVpNHIfsD4snqtJla0QbBNETNiv5N1wo14zRvNfe4d7UNGOUIWpcwVk 4=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 12 Dec 2021 19:28:28 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2021 19:28:28 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Sun, 12 Dec 2021 19:28:27 -0800 Received: from [10.50.12.43] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Sun, 12 Dec 2021 19:28:24 -0800 Message-ID: <93ef32a5-013a-fdcf-11bb-6f3c9bc34628@quicinc.com> Date: Mon, 13 Dec 2021 08:58:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCHv6 0/5] tracing/rwmmio/arm64: Add support to trace register reads/writes Content-Language: en-US To: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , Steven Rostedt CC: gregkh , , , , References: From: Sai Prakash Ranjan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Arnd, On 12/7/2021 12:24 PM, Sai Prakash Ranjan wrote: > Generic MMIO read/write i.e., __raw_{read,write}{b,l,w,q} accessors > are typically used to read/write from/to memory mapped registers > and can cause hangs or some undefined behaviour in following cases, > > * If the access to the register space is unclocked, for example: if > there is an access to multimedia(MM) block registers without MM > clocks. > > * If the register space is protected and not set to be accessible from > non-secure world, for example: only EL3 (EL: Exception level) access > is allowed and any EL2/EL1 access is forbidden. > > * If xPU(memory/register protection units) is controlling access to > certain memory/register space for specific clients. > > and more... > > Such cases usually results in instant reboot/SErrors/NOC or interconnect > hangs and tracing these register accesses can be very helpful to debug > such issues during initial development stages and also in later stages. > > So use ftrace trace events to log such MMIO register accesses which > provides rich feature set such as early enablement of trace events, > filtering capability, dumping ftrace logs on console and many more. > > Sample output: > > rwmmio_write: __qcom_geni_serial_console_write+0x160/0x1e0 width=32 val=0xa0d5d addr=0xfffffbfffdbff700 > rwmmio_post_write: __qcom_geni_serial_console_write+0x160/0x1e0 width=32 val=0xa0d5d addr=0xfffffbfffdbff700 > rwmmio_read: qcom_geni_serial_poll_bit+0x94/0x138 width=32 addr=0xfffffbfffdbff610 > rwmmio_post_read: qcom_geni_serial_poll_bit+0x94/0x138 width=32 val=0x0 addr=0xfffffbfffdbff610 > > This series is a follow-up for the series [1] and a recent series [2] making use > of both. > > [1] https://lore.kernel.org/lkml/cover.1536430404.git.saiprakash.ranjan@codeaurora.org/ > [2] https://lore.kernel.org/lkml/1604631386-178312-1-git-send-email-psodagud@codeaurora.org/ > > Note in previous v4 version, Arnd suggested to benchmark and compare size with callback > based implementation, please see [3] for more details on that with brief comparison below. > > > **Inline version with CONFIG_FTRACE=y and CONFIG_TRACE_MMIO_ACCESS=y** > $ size vmlinux > text data bss dec hex filename > 23884219 14284468 532568 38701255 24e88c7 vmlinux > > **Callback version with CONFIG_FTRACE=y and CONFIG_TRACE_MMIO_ACCESS=y** > $ size vmlinux > text data bss dec hex filename > 24108179 14279596 532568 38920343 251e097 vmlinux > > $ ./scripts/bloat-o-meter inline-vmlinux callback-vmlinux > add/remove: 8/3 grow/shrink: 4889/89 up/down: 242244/-11564 (230680) > Total: Before=25812612, After=26043292, chg +0.89% > > [3] https://lore.kernel.org/lkml/466449a1-36da-aaa9-7e4f-477f36b52c9e@quicinc.com/ > > Changes in v6: > * Implemented suggestions by Arnd Bergmann: > - Use arch independent IO barriers in arm64/asm > - Add ARCH_HAVE_TRACE_MMIO_ACCESS > - Add post read and post write logging support > - Remove tracepoint_active check > * Fix build error reported by kernel test robot. > > Changes in v5: > * Move arm64 to use asm-generic provided high level MMIO accessors (Arnd). > * Add inline logging for MMIO relaxed and non-relaxed accessors. > * Move nVHE KVM comment to makefile (Marc). > * Fix overflow warning due to switch to inline accessors instead of macro. > * Modify trace event field to include caller and parent details for more detailed logs. > > Changes in v4: > * Drop dynamic debug based filter support since that will be developed later with > the help from Steven (Ftrace maintainer). > * Drop value passed to writel as it is causing hangs when tracing is enabled. > * Code cleanup for trace event as suggested by Steven for earlier version. > * Fixed some build errors reported by 0-day bot. > > Changes in v3: > * Create a generic mmio header for instrumented version (Earlier suggested in [1] > by Will Deacon and recently [2] by Greg to have a generic version first). > * Add dynamic debug support to filter out traces which can be very useful for targeted > debugging specific to subsystems or drivers. > * Few modifications to the rwmmio trace event fields to include the mmio width and print > addresses in hex. > * Rewrote commit msg to explain some more about usecases. > > Prasad Sodagudi (1): > tracing: Add register read/write tracing support > > Sai Prakash Ranjan (4): > arm64: io: Use asm-generic high level MMIO accessors > irqchip/tegra: Fix overflow implicit truncation warnings > drm/meson: Fix overflow implicit truncation warnings > asm-generic/io: Add logging support for MMIO accessors > > arch/Kconfig | 3 + > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/io.h | 41 +++-------- > arch/arm64/kvm/hyp/nvhe/Makefile | 7 +- > drivers/gpu/drm/meson/meson_viu.c | 22 +++--- > drivers/irqchip/irq-tegra.c | 10 +-- > include/asm-generic/io.h | 81 +++++++++++++++++++-- > include/trace/events/rwmmio.h | 112 ++++++++++++++++++++++++++++++ > kernel/trace/Kconfig | 7 ++ > kernel/trace/Makefile | 1 + > kernel/trace/trace_readwrite.c | 47 +++++++++++++ > 11 files changed, 278 insertions(+), 54 deletions(-) > create mode 100644 include/trace/events/rwmmio.h > create mode 100644 kernel/trace/trace_readwrite.c > Does this version look good to you? From the other mail thread it seems Catalin is ok with your suggested change. Kernel test robot hasn't come with any build error reports so far, I have fixed the previous reported one in meson drm driver. Thanks, Sai From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B704C433EF for ; Mon, 13 Dec 2021 03:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TwCP56m7CA0Wjca7iOBoqJce+joNmosqPhYDVzgTEvE=; b=iLlSlXYNaWJARv qRnBqK8RVOtr81M5/3URPheZX8/AxFtMYJpKa3mqsRNZMHwHz05vJrxVVGovc60FFKm75nn2Cpir+ V4lhsT5nGcHh0u3+A4fcsMZRPa8bYxC8El0l+7HMcKb6fZ8JwwUZ3m4nSx89Ig1lF6zxeYBomQfr1 a+tfjrXr12BHSo7G0AvjP26D7SpGeS8u5SgY35FvMwZcMkxDTENzdMR7LeXx6D+V0j+uTgdZSJBQn yR+KoO98+DTQ4I8qKDwoSVTAdUTi+7b8wFGfaA3PfAflgauRcmoAaRRWIpiI8r9S/GmSY16YYgVwa CZxEojHP9W/21WO4UsfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwc0w-007g81-6w; Mon, 13 Dec 2021 03:28:34 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwc0r-007g7E-VE for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 03:28:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1639366109; x=1670902109; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1iIGBwZfqdyU2oIDOWAaYh9Xk7ZCowRlfURdZiu48XQ=; b=kxGTVV6xgU9dx0gvbY7oyGdt5gAT0agVOyuAt60SVAtazWvzauk1B6Ao BXhb0DyERScYm/9kZnht8UkaBgHFW0sXOte2wM89KszjdeG93uSqB8o7M Y6Y8Y/FkCTczZajcA+/aEYpI8FCQUi/WKKJqDuYq8ajCl8VH3tGe0x1CZ s=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 12 Dec 2021 19:28:28 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2021 19:28:28 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Sun, 12 Dec 2021 19:28:27 -0800 Received: from [10.50.12.43] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Sun, 12 Dec 2021 19:28:24 -0800 Message-ID: <93ef32a5-013a-fdcf-11bb-6f3c9bc34628@quicinc.com> Date: Mon, 13 Dec 2021 08:58:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCHv6 0/5] tracing/rwmmio/arm64: Add support to trace register reads/writes Content-Language: en-US To: Will Deacon , Catalin Marinas , Marc Zyngier , Arnd Bergmann , Steven Rostedt CC: gregkh , , , , References: From: Sai Prakash Ranjan In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211212_192830_113930_EA88D1C4 X-CRM114-Status: GOOD ( 27.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, On 12/7/2021 12:24 PM, Sai Prakash Ranjan wrote: > Generic MMIO read/write i.e., __raw_{read,write}{b,l,w,q} accessors > are typically used to read/write from/to memory mapped registers > and can cause hangs or some undefined behaviour in following cases, > > * If the access to the register space is unclocked, for example: if > there is an access to multimedia(MM) block registers without MM > clocks. > > * If the register space is protected and not set to be accessible from > non-secure world, for example: only EL3 (EL: Exception level) access > is allowed and any EL2/EL1 access is forbidden. > > * If xPU(memory/register protection units) is controlling access to > certain memory/register space for specific clients. > > and more... > > Such cases usually results in instant reboot/SErrors/NOC or interconnect > hangs and tracing these register accesses can be very helpful to debug > such issues during initial development stages and also in later stages. > > So use ftrace trace events to log such MMIO register accesses which > provides rich feature set such as early enablement of trace events, > filtering capability, dumping ftrace logs on console and many more. > > Sample output: > > rwmmio_write: __qcom_geni_serial_console_write+0x160/0x1e0 width=32 val=0xa0d5d addr=0xfffffbfffdbff700 > rwmmio_post_write: __qcom_geni_serial_console_write+0x160/0x1e0 width=32 val=0xa0d5d addr=0xfffffbfffdbff700 > rwmmio_read: qcom_geni_serial_poll_bit+0x94/0x138 width=32 addr=0xfffffbfffdbff610 > rwmmio_post_read: qcom_geni_serial_poll_bit+0x94/0x138 width=32 val=0x0 addr=0xfffffbfffdbff610 > > This series is a follow-up for the series [1] and a recent series [2] making use > of both. > > [1] https://lore.kernel.org/lkml/cover.1536430404.git.saiprakash.ranjan@codeaurora.org/ > [2] https://lore.kernel.org/lkml/1604631386-178312-1-git-send-email-psodagud@codeaurora.org/ > > Note in previous v4 version, Arnd suggested to benchmark and compare size with callback > based implementation, please see [3] for more details on that with brief comparison below. > > > **Inline version with CONFIG_FTRACE=y and CONFIG_TRACE_MMIO_ACCESS=y** > $ size vmlinux > text data bss dec hex filename > 23884219 14284468 532568 38701255 24e88c7 vmlinux > > **Callback version with CONFIG_FTRACE=y and CONFIG_TRACE_MMIO_ACCESS=y** > $ size vmlinux > text data bss dec hex filename > 24108179 14279596 532568 38920343 251e097 vmlinux > > $ ./scripts/bloat-o-meter inline-vmlinux callback-vmlinux > add/remove: 8/3 grow/shrink: 4889/89 up/down: 242244/-11564 (230680) > Total: Before=25812612, After=26043292, chg +0.89% > > [3] https://lore.kernel.org/lkml/466449a1-36da-aaa9-7e4f-477f36b52c9e@quicinc.com/ > > Changes in v6: > * Implemented suggestions by Arnd Bergmann: > - Use arch independent IO barriers in arm64/asm > - Add ARCH_HAVE_TRACE_MMIO_ACCESS > - Add post read and post write logging support > - Remove tracepoint_active check > * Fix build error reported by kernel test robot. > > Changes in v5: > * Move arm64 to use asm-generic provided high level MMIO accessors (Arnd). > * Add inline logging for MMIO relaxed and non-relaxed accessors. > * Move nVHE KVM comment to makefile (Marc). > * Fix overflow warning due to switch to inline accessors instead of macro. > * Modify trace event field to include caller and parent details for more detailed logs. > > Changes in v4: > * Drop dynamic debug based filter support since that will be developed later with > the help from Steven (Ftrace maintainer). > * Drop value passed to writel as it is causing hangs when tracing is enabled. > * Code cleanup for trace event as suggested by Steven for earlier version. > * Fixed some build errors reported by 0-day bot. > > Changes in v3: > * Create a generic mmio header for instrumented version (Earlier suggested in [1] > by Will Deacon and recently [2] by Greg to have a generic version first). > * Add dynamic debug support to filter out traces which can be very useful for targeted > debugging specific to subsystems or drivers. > * Few modifications to the rwmmio trace event fields to include the mmio width and print > addresses in hex. > * Rewrote commit msg to explain some more about usecases. > > Prasad Sodagudi (1): > tracing: Add register read/write tracing support > > Sai Prakash Ranjan (4): > arm64: io: Use asm-generic high level MMIO accessors > irqchip/tegra: Fix overflow implicit truncation warnings > drm/meson: Fix overflow implicit truncation warnings > asm-generic/io: Add logging support for MMIO accessors > > arch/Kconfig | 3 + > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/io.h | 41 +++-------- > arch/arm64/kvm/hyp/nvhe/Makefile | 7 +- > drivers/gpu/drm/meson/meson_viu.c | 22 +++--- > drivers/irqchip/irq-tegra.c | 10 +-- > include/asm-generic/io.h | 81 +++++++++++++++++++-- > include/trace/events/rwmmio.h | 112 ++++++++++++++++++++++++++++++ > kernel/trace/Kconfig | 7 ++ > kernel/trace/Makefile | 1 + > kernel/trace/trace_readwrite.c | 47 +++++++++++++ > 11 files changed, 278 insertions(+), 54 deletions(-) > create mode 100644 include/trace/events/rwmmio.h > create mode 100644 kernel/trace/trace_readwrite.c > Does this version look good to you? From the other mail thread it seems Catalin is ok with your suggested change. Kernel test robot hasn't come with any build error reports so far, I have fixed the previous reported one in meson drm driver. Thanks, Sai _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel