All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Yang Rong <yangrong@vivo.com>,
	linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: opensource.kernel@vivo.com, LKML <linux-kernel@vger.kernel.org>,
	Lu Hongfei <luhongfei@vivo.com>
Subject: Re: [PATCH v2] mtd: Fix resource leaks in for_each_child_of_node() loops
Date: Mon, 10 Jul 2023 19:19:26 +0200	[thread overview]
Message-ID: <93f264ab-336b-8992-6f87-ceaf0434c617@web.de> (raw)
In-Reply-To: <20230710061412.2272-1-yangrong@vivo.com>

Would a subject like “[PATCH v3] mtd: core: Fix resource leak in a for_each_child_of_node() loop”
be more appropriate?


> Ensure child node references are decremented properly in the error path.

How do you think about the following wording variant?

  Ensure child node references are properly decremented in the error path
  of this function implementation.


Would you like to add the tag “Fixes” because of the completion
of the exception handling?

Regards,
Markus

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2023-07-10 17:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10  6:10 [PATCH v2] mtd: Fix resource leaks in for_each_child_of_node() loops Yang Rong
2023-07-10  6:10 ` Yang Rong
2023-07-10 17:19 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93f264ab-336b-8992-6f87-ceaf0434c617@web.de \
    --to=markus.elfring@web.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=luhongfei@vivo.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=opensource.kernel@vivo.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yangrong@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.