Re: [PATCH v2 10/10] socketcall.2: Use syscall(SYS_...); for system calls without a wrapper

["Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>]

Hi Alex,

On 5/25/21 6:19 AM, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

Applied.

Thanks,

Michael


> ---
>  man2/socketcall.2 | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/man2/socketcall.2 b/man2/socketcall.2
> index 8ef3d65d3..883c2aafe 100644
> --- a/man2/socketcall.2
> +++ b/man2/socketcall.2
> @@ -27,13 +27,18 @@
>  socketcall \- socket system calls
>  .SH SYNOPSIS
>  .nf
> -.B #include <linux/net.h>
> +.BR "#include <linux/net.h>" "        /* Definition of " SYS_* " constants */"
> +.BR "#include <sys/syscall.h>" "      /* Definition of " SYS_socketcall " */"
> +.B #include <unistd.h>
>  .PP
> -.BI "int socketcall(int " call ", unsigned long *" args );
> +.BI "int syscall(SYS_socketcall, int " call ", unsigned long *" args );
>  .fi
>  .PP
>  .IR Note :
> -There is no glibc wrapper for this system call; see NOTES.
> +glibc provides no wrapper for
> +.BR socketcall (),
> +necessitating the use of
> +.BR syscall (2).
>  .SH DESCRIPTION
>  .BR socketcall ()
>  is a common kernel entry point for the socket system calls.
> @@ -156,10 +161,6 @@ T}
>  This call is specific to Linux, and should not be used in programs
>  intended to be portable.
>  .SH NOTES
> -Glibc does not provide a wrapper for this system call;
> -in the unlikely event that you want to call it directly, do so using
> -.BR syscall (2).
> -.PP
>  On some architectures\(emfor example, x86-64 and ARM\(emthere is no
>  .BR socketcall ()
>  system call; instead
> @@ -198,3 +199,4 @@ and also provides a (very) small performance improvement.
>  .BR shutdown (2),
>  .BR socket (2),
>  .BR socketpair (2)
> +
> 


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/