All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: sunpeng.li@amd.com, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Cc: Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH 04/10] drm/nouveau: Use connector kdev as aux device parent
Date: Fri, 12 Jul 2019 15:55:42 -0400	[thread overview]
Message-ID: <93fcded587fd0a2c67df35cc74d6406bd3267c4c.camel@redhat.com> (raw)
In-Reply-To: <20190704190519.29525-5-sunpeng.li@amd.com>

Reviewed-by: Lyude Paul <lyude@redhat.com>

On Thu, 2019-07-04 at 15:05 -0400, sunpeng.li@amd.com wrote:
> From: Leo Li <sunpeng.li@amd.com>
> 
> Set the connector's kernel device as the parent for the aux kernel
> device. This allows udev rules to access connector attributes when
> creating symlinks to aux devices.
> 
> Cc: Ben Skeggs <bskeggs@redhat.com>
> Signed-off-by: Leo Li <sunpeng.li@amd.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c
> b/drivers/gpu/drm/nouveau/nouveau_connector.c
> index 4116ee62adaf..e32def09ef89 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -1346,7 +1346,7 @@ nouveau_connector_create(struct drm_device *dev,
>  		break;
>  	case DRM_MODE_CONNECTOR_DisplayPort:
>  	case DRM_MODE_CONNECTOR_eDP:
> -		nv_connector->aux.dev = dev->dev;
> +		nv_connector->aux.dev = connector->kdev;
>  		nv_connector->aux.transfer = nouveau_connector_aux_xfer;
>  		snprintf(aux_name, sizeof(aux_name), "sor-%04x-%04x",
>  			 dcbe->hasht, dcbe->hashm);
-- 
Cheers,
	Lyude Paul

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-07-12 19:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 19:05 [PATCH 00/10] Enable MST Aux devices (v2) sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05 ` [PATCH 03/10] drm/sysfs: Add mstpath attribute to connector devices sunpeng.li
     [not found]   ` <20190704190519.29525-4-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2019-07-04 19:33     ` Ville Syrjälä
2019-07-05 14:03       ` Li, Sun peng (Leo)
2019-07-05 14:32     ` [PATCH v2] " sunpeng.li-5C7GfCeVMHo
     [not found]       ` <20190705143220.11109-1-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2019-07-10 10:07         ` Ville Syrjälä
2019-07-10 22:50         ` Lyude Paul
     [not found]           ` <346980b73f3b1fbbc70cbf3771788cec0777d4c0.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-07-16 18:28             ` Li, Sun peng (Leo)
2019-07-16 20:28               ` Lyude Paul
     [not found] ` <20190704190519.29525-1-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2019-07-04 19:05   ` [PATCH 01/10] drm/dp: Use non-cyclic idr sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05   ` [PATCH 02/10] drm/dp_mst: Enable registration of AUX devices for MST ports (v2) sunpeng.li-5C7GfCeVMHo
     [not found]     ` <20190704190519.29525-3-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2019-07-10 19:51       ` Lyude Paul
2019-07-10 23:25     ` Lyude Paul
2019-07-04 19:05   ` [PATCH 04/10] drm/nouveau: Use connector kdev as aux device parent sunpeng.li-5C7GfCeVMHo
2019-07-12 19:55     ` Lyude Paul [this message]
2019-07-04 19:05   ` [PATCH 05/10] drm/bridge/analogix-anx78xx: " sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05   ` [PATCH 06/10] drm/amd/display: " sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05   ` [PATCH 07/10] drm/i915: Implement MST Aux device registration sunpeng.li-5C7GfCeVMHo
2019-07-10 10:06     ` Ville Syrjälä
2019-07-12 19:48     ` Lyude Paul
2019-07-12 20:05       ` Ville Syrjälä
     [not found]         ` <20190712200559.GN5942-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-07-12 20:15           ` Ville Syrjälä
2019-07-23 14:01             ` Li, Sun peng (Leo)
2019-07-04 19:05   ` [PATCH 08/10] drm/nouveau/kms/nv50: " sunpeng.li-5C7GfCeVMHo
2019-07-12 19:54     ` Lyude Paul
2019-07-04 19:05   ` [PATCH 09/10] drm/radeon: " sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05   ` [PATCH 10/10] drm/amd/display: " sunpeng.li-5C7GfCeVMHo
2019-07-09 19:10   ` [PATCH 00/10] Enable MST Aux devices (v2) Li, Sun peng (Leo)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93fcded587fd0a2c67df35cc74d6406bd3267c4c.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sunpeng.li@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.