From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 016D4C4708F for ; Tue, 1 Jun 2021 12:15:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C276461375 for ; Tue, 1 Jun 2021 12:15:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C276461375 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B6E681F9B; Tue, 1 Jun 2021 14:15:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2FF1582AE5; Tue, 1 Jun 2021 14:15:26 +0200 (CEST) Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.70.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A114480F0E for ; Tue, 1 Jun 2021 14:15:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=kever.yang@rock-chips.com Received: from localhost (unknown [192.168.167.70]) by regular1.263xmail.com (Postfix) with ESMTP id 8FF93570; Tue, 1 Jun 2021 20:15:16 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-SKE-CHECKED: 1 X-ABS-CHECKED: 1 Received: from [172.16.12.120] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P3122T139987525818112S1622549715342779_; Tue, 01 Jun 2021 20:15:15 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: kever.yang@rock-chips.com X-SENDER: yk@rock-chips.com X-LOGIN-NAME: kever.yang@rock-chips.com X-FST-TO: gouwa@khadas.com X-RCPT-COUNT: 8 X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 Subject: Re: [PATCH] evb_rk3399: add usb ohci definations To: Artem Lapkin Cc: sjg@chromium.org, jagan@amarulasolutions.com, sunil@amarulasolutions.com, u-boot@lists.denx.de, art@khadas.com, nick@khadas.com, gouwa@khadas.com References: <20210526093319.274254-1-art@khadas.com> From: Kever Yang Message-ID: <9401f82b-efe7-7acf-da10-4934db5d3b8b@rock-chips.com> Date: Tue, 1 Jun 2021 20:15:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210526093319.274254-1-art@khadas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi Artem, On 2021/5/26 下午5:33, Artem Lapkin wrote: > Problem: not possible to use CONFIG_USB_OHCI_HCD=y and > CONFIG_USB_OHCI_GENERIC=y options without CONFIG_USB_OHCI_NEW and > CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS definations > > Add missed definations. But , evb_rk3399 board does not enable CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC. Thanks, - Kever > > Signed-off-by: Artem Lapkin > --- > include/configs/evb_rk3399.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk3399.h > index b7e85037..492b7b4d 100644 > --- a/include/configs/evb_rk3399.h > +++ b/include/configs/evb_rk3399.h > @@ -15,4 +15,7 @@ > > #define SDRAM_BANK_SIZE (2UL << 30) > > +#define CONFIG_USB_OHCI_NEW > +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 > + > #endif