From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751233AbdECAWr (ORCPT ); Tue, 2 May 2017 20:22:47 -0400 Received: from merlin.infradead.org ([205.233.59.134]:36100 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbdECAWb (ORCPT ); Tue, 2 May 2017 20:22:31 -0400 Subject: Re: [PATCH] xen: Move xen_have_vector_callback definition to enlighten.c To: Boris Ostrovsky , jgross@suse.com References: <1493745786-27350-1-git-send-email-boris.ostrovsky@oracle.com> Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Randy Dunlap Message-ID: <94163359-6cf0-56b6-3e98-ddf595cae283@infradead.org> Date: Tue, 2 May 2017 17:22:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1493745786-27350-1-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/02/17 10:23, Boris Ostrovsky wrote: > Commit 84d582d236dc ("xen: Revert commits da72ff5bfcb0 and > 72a9b186292d") defined xen_have_vector_callback in enlighten_hvm.c. > Since guest-type-neutral code refers to this variable this causes > build failures when CONFIG_XEN_PVHVM is not defined. > > Moving xen_have_vector_callback definition to enlighten.c resolves > this issue. > > Signed-off-by: Boris Ostrovsky > Reported-by: Randy Dunlap Works for me. Thanks. Acked-by: Randy Dunlap > --- > arch/x86/xen/enlighten.c | 3 +++ > arch/x86/xen/enlighten_hvm.c | 3 --- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c > index 41d324c..a5ffcbb 100644 > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c > @@ -57,6 +57,9 @@ EXPORT_SYMBOL_GPL(xen_start_info); > > struct shared_info xen_dummy_shared_info; > > +__read_mostly int xen_have_vector_callback; > +EXPORT_SYMBOL_GPL(xen_have_vector_callback); > + > /* > * Point at some empty memory to start with. We map the real shared_info > * page as soon as fixmap is up and running. > diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c > index 078c512..a6d014f 100644 > --- a/arch/x86/xen/enlighten_hvm.c > +++ b/arch/x86/xen/enlighten_hvm.c > @@ -18,9 +18,6 @@ > #include "mmu.h" > #include "smp.h" > > -__read_mostly int xen_have_vector_callback; > -EXPORT_SYMBOL_GPL(xen_have_vector_callback); > - > void __ref xen_hvm_init_shared_info(void) > { > int cpu; > -- ~Randy