All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] STi DT updates for v4.8
Date: Thu, 07 Jul 2016 12:08:01 +0200	[thread overview]
Message-ID: <9427724.UUV0z7XpPd@wuerfel> (raw)
In-Reply-To: <577E0734.2070206@st.com>

On Thursday, July 7, 2016 9:39:32 AM CEST Patrice Chotard wrote:
> On 07/07/2016 07:28 AM, Olof Johansson wrote:
> > On Fri, Jul 01, 2016 at 03:28:58PM +0200, Patrice Chotard wrote:
> >> ----------------------------------------------------------------
> >> Highlights:
> >> -----------
> >>   -add STi critical clocks
> >> - as discussed on IRC with Lee Jones, remove SPI hack wich has dependecy
> >> with critical clocks
> >>
> >> ----------------------------------------------------------------
> >> Lee Jones (3):
> >>        ARM: sti: stih407-family: Supply defines for CLOCKGEN A0
> >>        ARM: sti: stih410-clocks: Identify critical clocks
> >>        spi: st-ssc4: Remove 'no clocking' hack
> > THere are more patches than this in this branch -- there are three clock
> > branches that by the look of it have been applied by Stephen Boyd.
> >
> > However, since they have been brought in without doing a merge, it's hard for
> > us to tell where they came form, and/or if they're in a shared branch
> > somewhere. Therefore, I recommend doing a --no-ff merge of the branch, so it's
> > obvious from the merge commit where they came form. They also need to be part
> > of the diffstat.
> >
> > Finally, the clk patch doesn't really belong in the DT branch here. It's
> > probably a suitable patch to send to the clk maintainers after the DT changes
> > have gone in, i.e. for 4.9.
> >
> > Please respin this pull request and we'll take another look!
> 
> There was a discussion on IRC armlinux's channel between Lee Jones, Arnd 
> Bergman
> and Mark Brown about the way to proceed with this pull request.
> 
> As there are dependencies between the 3 critical clocks patches on 
> Stephen Boyd's
> branch clk-next/clk-st-critical, our STi DT and our SPI drivers which 
> remove a temporary
> clock hack, the decision was taken to put our DT STi fixes on top of 
> Stephen Boyd critical clk
>   branch and our SPI patches on the top.
> 
> For more details i put in attachment the IRC exchange about this.

This information belongs into the tag description, it's required for
us to make the decision whether the branch is can be merged or not.

In particular, you need to spell out the specific dependency that
exists between the clk patches and the dt patches.

What I understood from Lee before is that there is no such dependency
at all and the only thing that needs the clk changes is the spi
patch, while the DT patches and the clk patches are independent.

However, Lee's explanation was a bit ambiguous and could be interpreted
as meaning that there is another dependency here, which was simply
not explained.

	Arnd

  reply	other threads:[~2016-07-07 10:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01 13:28 [GIT PULL] STi DT updates for v4.8 Patrice Chotard
2016-07-07  5:28 ` Olof Johansson
2016-07-07  7:39   ` Patrice Chotard
2016-07-07 10:08     ` Arnd Bergmann [this message]
2016-07-12  9:24       ` Lee Jones
2016-07-12 14:03         ` Patrice Chotard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9427724.UUV0z7XpPd@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.