From: Johannes Berg <johannes@sipsolutions.net>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Felix Fietkau <nbd@nbd.name>, Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org,
syzbot+fdc5123366fb9c3fdc6d@syzkaller.appspotmail.com
Subject: Re: [PATCH] wifi: mac80211: don't ask rate control with zero rate mask if scanning
Date: Thu, 18 Jan 2024 14:46:14 +0100 [thread overview]
Message-ID: <9433d29b643e4cce3a9354282405288c75c45e02.camel@sipsolutions.net> (raw)
In-Reply-To: <20240117124848.120438-1-dmantipov@yandex.ru>
On Wed, 2024-01-17 at 15:48 +0300, Dmitry Antipov wrote:
> If we're scanning and got the control frame with zero rate mask, drop
> the frame before '__rate_control_send_low()' getting stuck attempting
> to select supported rate.
But why drop the frame? I'm still thinking that it just doesn't really
make sense to apply the rate mask to scanning at all?
The most common use case for this is probably P2P-style things where you
just don't want to use CCK, but for scanning we have
NL80211_ATTR_TX_NO_CCK_RATE for this, so there's really no need to apply
the rate mask?
johannes
next prev parent reply other threads:[~2024-01-18 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 12:48 [PATCH] wifi: mac80211: don't ask rate control with zero rate mask if scanning Dmitry Antipov
2024-01-18 13:46 ` Johannes Berg [this message]
2024-01-19 8:07 ` Dmitry Antipov
2024-01-19 17:19 ` Johannes Berg
2024-01-24 15:11 ` Dmitry Antipov
2024-01-25 9:07 ` [PATCH 0/1] " Dmitry Antipov
2024-01-25 9:07 ` [PATCH 1/1] wifi: mac80211: ignore the bitrate mask when scanning Dmitry Antipov
2024-01-26 10:06 ` Johannes Berg
2024-01-26 10:05 ` [PATCH 0/1] Re: wifi: mac80211: don't ask rate control with zero rate mask if scanning Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9433d29b643e4cce3a9354282405288c75c45e02.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=nbd@nbd.name \
--cc=syzbot+fdc5123366fb9c3fdc6d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.