From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3048DC433E0 for ; Wed, 1 Jul 2020 09:58:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0ACEE20747 for ; Wed, 1 Jul 2020 09:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729777AbgGAJ6R (ORCPT ); Wed, 1 Jul 2020 05:58:17 -0400 Received: from mail.loongson.cn ([114.242.206.163]:38934 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729332AbgGAJ6Q (ORCPT ); Wed, 1 Jul 2020 05:58:16 -0400 Received: from [10.130.0.52] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dx_98uXvxecKNNAA--.1551S3; Wed, 01 Jul 2020 17:58:08 +0800 (CST) Subject: Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Michal Simek , linux-arm-kernel@lists.infradead.org References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn> Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org From: Tiezhu Yang Message-ID: <9434711b-96c1-8ef5-79b6-510170654df8@loongson.cn> Date: Wed, 1 Jul 2020 17:58:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf9Dx_98uXvxecKNNAA--.1551S3 X-Coremail-Antispam: 1UD129KBjvdXoWrKFyxWw4DGFyUKw47tw15CFg_yoW3ZFg_Zr 1093Z5GFW8Jrn8JayIyrsI9393Wr4kJan7tFWvva47Z34fXws3urWqkw1xX348WF1fCF45 Cw4YvrWftrW7ZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcAYjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVW8JVWxJw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF 04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r 18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vI r41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr 1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjxUc9mRUUUUU X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2020 05:42 PM, Markus Elfring wrote: >> In the function xilinx_intc_of_init(), system resource "irqc->root_domain" >> was not released in the error case. Thus add jump target for the completion >> of the desired exception handling. > Another small wording adjustment: > … Thus add a jump target … OK > > > … >> +++ b/drivers/irqchip/irq-xilinx-intc.c > … >> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, >> >> return 0; >> >> +error_domain_remove: >> + irq_domain_remove(irqc->root_domain); >> error: >> iounmap(irqc->base); > … > > Can labels like “remove_irq_domain” and “unmap_io” be nicer? Thank you, I will use "err_domain_remove" and "err_iounmap" to keep consistence with other patches. > > Regards, > Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiezhu Yang Date: Wed, 01 Jul 2020 09:58:06 +0000 Subject: Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak Message-Id: <9434711b-96c1-8ef5-79b6-510170654df8@loongson.cn> List-Id: References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Michal Simek , linux-arm-kernel@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 07/01/2020 05:42 PM, Markus Elfring wrote: >> In the function xilinx_intc_of_init(), system resource "irqc->root_domain" >> was not released in the error case. Thus add jump target for the completion >> of the desired exception handling. > Another small wording adjustment: > … Thus add a jump target … OK > > > … >> +++ b/drivers/irqchip/irq-xilinx-intc.c > … >> @@ -250,6 +250,8 @@ static int __init xilinx_intc_of_init(struct device_node *intc, >> >> return 0; >> >> +error_domain_remove: >> + irq_domain_remove(irqc->root_domain); >> error: >> iounmap(irqc->base); > … > > Can labels like “remove_irq_domain” and “unmap_io” be nicer? Thank you, I will use "err_domain_remove" and "err_iounmap" to keep consistence with other patches. > > Regards, > Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79272C433E0 for ; Wed, 1 Jul 2020 09:59:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 488FA2073E for ; Wed, 1 Jul 2020 09:59:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U/bVlFTs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 488FA2073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4sKbeZX2vmsc83B+HPxqgHv0HECotO9sCiRAi70ef6M=; b=U/bVlFTsbKNkMFRd1k58rHYrF 8RwbTEj+BfOAiyHBDdagLDQj2UyXSDnNRmlaLi8RpaJMnpzWMY+W2Ha4zgyWYet7VZ5wTtoEDw+E9 ys6V5uSdxy0Pr+mNu8RzD+HdrFKmwfUzD9d1EB0LtGOyG42sum6+nqidcahXmXO+nKJbD2x7kWpx9 VH1Bza4EglV2BIR6DNYTbLbOaHkHJmfPXWHSh8F3CcaCkL+n3Kjx8USi2f6Eu4VbSDFA3sK+RumC6 nQI1v1nq5B7w2YYpoJgBIYWKQoTupN3uAEumsCozF/ewIzB6IMDbb6KtwJle5n/iiqRI+QWbBgq22 qZTOuQBjg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZVa-0005bH-BU; Wed, 01 Jul 2020 09:58:26 +0000 Received: from mail.loongson.cn ([114.242.206.163] helo=loongson.cn) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqZVV-0005Zt-NA for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 09:58:24 +0000 Received: from [10.130.0.52] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dx_98uXvxecKNNAA--.1551S3; Wed, 01 Jul 2020 17:58:08 +0800 (CST) Subject: Re: [PATCH v4 14/14] irqchip/xilinx-intc: Fix potential resource leak To: Markus Elfring , Thomas Gleixner , Jason Cooper , Marc Zyngier , Michal Simek , linux-arm-kernel@lists.infradead.org References: <1593569786-11500-1-git-send-email-yangtiezhu@loongson.cn> <1593569786-11500-15-git-send-email-yangtiezhu@loongson.cn> From: Tiezhu Yang Message-ID: <9434711b-96c1-8ef5-79b6-510170654df8@loongson.cn> Date: Wed, 1 Jul 2020 17:58:06 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-CM-TRANSID: AQAAf9Dx_98uXvxecKNNAA--.1551S3 X-Coremail-Antispam: 1UD129KBjvdXoWrKFyxWw4DGFyUKw47tw15CFg_yoW3ZFg_Zr 1093Z5GFW8Jrn8JayIyrsI9393Wr4kJan7tFWvva47Z34fXws3urWqkw1xX348WF1fCF45 Cw4YvrWftrW7ZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcAYjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVW8JVWxJw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzVAYIcxG8wCF 04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r 18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vI r41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr 1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjxUc9mRUUUUU X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_055822_942344_9785A00A X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMDcvMDEvMjAyMCAwNTo0MiBQTSwgTWFya3VzIEVsZnJpbmcgd3JvdGU6Cj4+IEluIHRoZSBm dW5jdGlvbiB4aWxpbnhfaW50Y19vZl9pbml0KCksIHN5c3RlbSByZXNvdXJjZSAiaXJxYy0+cm9v dF9kb21haW4iCj4+IHdhcyBub3QgcmVsZWFzZWQgaW4gdGhlIGVycm9yIGNhc2UuIFRodXMgYWRk IGp1bXAgdGFyZ2V0IGZvciB0aGUgY29tcGxldGlvbgo+PiBvZiB0aGUgZGVzaXJlZCBleGNlcHRp b24gaGFuZGxpbmcuCj4gQW5vdGhlciBzbWFsbCB3b3JkaW5nIGFkanVzdG1lbnQ6Cj4gICAg4oCm IFRodXMgYWRkIGEganVtcCB0YXJnZXQg4oCmCgpPSwoKPgo+Cj4g4oCmCj4+ICsrKyBiL2RyaXZl cnMvaXJxY2hpcC9pcnEteGlsaW54LWludGMuYwo+IOKApgo+PiBAQCAtMjUwLDYgKzI1MCw4IEBA IHN0YXRpYyBpbnQgX19pbml0IHhpbGlueF9pbnRjX29mX2luaXQoc3RydWN0IGRldmljZV9ub2Rl ICppbnRjLAo+Pgo+PiAgIAlyZXR1cm4gMDsKPj4KPj4gK2Vycm9yX2RvbWFpbl9yZW1vdmU6Cj4+ ICsJaXJxX2RvbWFpbl9yZW1vdmUoaXJxYy0+cm9vdF9kb21haW4pOwo+PiAgIGVycm9yOgo+PiAg IAlpb3VubWFwKGlycWMtPmJhc2UpOwo+IOKApgo+Cj4gQ2FuIGxhYmVscyBsaWtlIOKAnHJlbW92 ZV9pcnFfZG9tYWlu4oCdIGFuZCDigJx1bm1hcF9pb+KAnSBiZSBuaWNlcj8KClRoYW5rIHlvdSwg SSB3aWxsIHVzZSAiZXJyX2RvbWFpbl9yZW1vdmUiIGFuZCAiZXJyX2lvdW5tYXAiCnRvIGtlZXAg Y29uc2lzdGVuY2Ugd2l0aCBvdGhlciBwYXRjaGVzLgoKPgo+IFJlZ2FyZHMsCj4gTWFya3VzCgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=