All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Max <jbires@google.com>, Greg KH <gregkh@linuxfoundation.org>,
	Josh Triplett <josh@joshtriplett.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] char: lack of bool string made CONFIG_DEVPORT always on
Date: Wed, 14 Dec 2016 10:11:19 +0100	[thread overview]
Message-ID: <9437575.LShmc6ajMp@wuerfel> (raw)
In-Reply-To: <CAMuHMdWr2JHwUP-WCCZ85gFCDNG_=w7XzKYzywtumvE4ihgfrg@mail.gmail.com>

On Wednesday, December 14, 2016 9:58:53 AM CET Geert Uytterhoeven wrote:
> >
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -589,10 +589,13 @@ config TELCLOCK
> >           controlling the behavior of this hardware.
> >
> >  config DEVPORT
> > -       bool
> > +       bool "/dev/port character device"
> 
> bool "/dev/port character device" if EXPERT?

I think the 'default y' is good enough, there are good reasons
even for non-EXPERT configurations to turn this off.

	Arnd

  reply	other threads:[~2016-12-14  9:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14  0:32 [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max
2016-12-14  0:58 ` Greg KH
2016-12-14  1:18   ` Max
2016-12-14  8:58     ` Geert Uytterhoeven
2016-12-14  9:11       ` Arnd Bergmann [this message]
2016-12-14  9:46         ` Josh Triplett
     [not found]           ` <CALVgH4S9b7JJj0wbR1N9Bd4tJB-CqJWfm_SPXv3z-m7U372ZmA@mail.gmail.com>
2017-01-02 20:49             ` Arnd Bergmann
2017-01-03 12:53 ` Max Bires
2017-01-03 13:52   ` Greg KH
2017-01-03 14:26 ` [PATCH] Without a bool string present, using "# CONFIG_DEVPORT is not set" in defconfig files would not actually unset devport. This esnured that /dev/port was always on, but there are reasons a user may wish to disable it (smaller kernel, attack surface reduction) if it's not being used. Adding a message here in order to make this user visible Max Bires
2017-01-03 14:34   ` Greg KH
2017-01-03 16:18   ` [PATCH] char: lack of bool string made CONFIG_DEVPORT always on Max Bires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9437575.LShmc6ajMp@wuerfel \
    --to=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbires@google.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.