From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C36C3C2D0C6 for ; Wed, 11 Dec 2019 18:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CC352077B for ; Wed, 11 Dec 2019 18:15:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fX6sP+zs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731369AbfLKSPn (ORCPT ); Wed, 11 Dec 2019 13:15:43 -0500 Received: from mail-yw1-f68.google.com ([209.85.161.68]:37140 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731334AbfLKSPj (ORCPT ); Wed, 11 Dec 2019 13:15:39 -0500 Received: by mail-yw1-f68.google.com with SMTP id v84so2956832ywa.4; Wed, 11 Dec 2019 10:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+x/b256hi/BiDL31JHY2PQmq0IAPIM+EJHKCtlj8/GQ=; b=fX6sP+zsfo7QiNbgczb4g4RwNHoCbsE1Qdyiv+e78chsM5SpDb4VEhKpowEc//NJoF FjK35PxJAduy/TX/48sMOL3RShtFhvUhNwsxT+kqQaC0P0K8epI0Z9BONFqdXhvqaS+Z JdChIJ1NIBh4GYo0JeyRRonR7dGvME5szcK+5dxOzjyME0JL+5hqPSLt0c3rVPZ/CA/k TPT3c9y4uC/H5pA25FeD5hZNcBfMikGd+GN2ODylL4gQzHbNIveYNbU3TCBOyxk7Oodl 3ncupRw6DqkxFFMCl21ApGz5DExaUQ+K3+3oorm/IcwlBs/ngNQvTk+jo09qZUQCAVn2 CgQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+x/b256hi/BiDL31JHY2PQmq0IAPIM+EJHKCtlj8/GQ=; b=T8bpSbqhp99dTOScYbbWChBTW4wZYI5ESZKOTBt3I2Po64sjkXDKUpRnpq4VBl14iO vKmhhJVXZFx2KeBgQkPs2AMNpyqTP0W6IcA+NGGv4qlSloIkr34pRVdF9d+uF3yb5zjW 5fJS5pKIG9oYtZNdFbo0/Luso3LGOiLJx7pPPfgLR5hfrIF4AKWhqmhcMrsoxuReJaIE jg5dwsUHeksAvE30MFaCF+7Ehd3AtC+UN33YbG5VTXvxPryOIx7iVV0Myia6SVoHs1AM 3nxXxm1S9S8zPybhUkI9GZGv8/gCWVzrIowr57ChkXbNtiEXitxwf5i9xc88LRfvWKoP aDLA== X-Gm-Message-State: APjAAAWTzeo8apgtoHYRqj2SNMHCyTwNPOOxb43G1JLfSSOtLycbaAc/ pQx4LzBQ2av/vBdQFlnMqVgLAWNrMd2TRw== X-Google-Smtp-Source: APXvYqy+8SSiMyc2gSAf5nlC+pArO37lD4CnuaJdfKdo8miRp32JKEQHg5OHDfOWK1+LzEnk0ZTCWg== X-Received: by 2002:a81:ad1a:: with SMTP id l26mr852793ywh.481.1576088138380; Wed, 11 Dec 2019 10:15:38 -0800 (PST) Received: from karen ([2604:2d80:d68a:cf00:a4bc:8e08:1748:387f]) by smtp.gmail.com with ESMTPSA id i84sm1341120ywc.43.2019.12.11.10.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 10:15:37 -0800 (PST) From: Scott Schafer To: gregkh@linuxfoundation.org Cc: Scott Schafer , Manish Chopra , GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 22/23] staging: qlge: Fix CHECK: Unbalanced braces around else statement Date: Wed, 11 Dec 2019 12:12:51 -0600 Message-Id: <943bad431329fc77f515158444c6d06fbeeb66fe.1576086080.git.schaferjscott@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix CHECK: Unbalanced braces around else statement in file qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_mpi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c index ba8ce3506a59..c9d45c8feabe 100644 --- a/drivers/staging/qlge/qlge_mpi.c +++ b/drivers/staging/qlge/qlge_mpi.c @@ -244,12 +244,12 @@ static int ql_idc_cmplt_aen(struct ql_adapter *qdev) netif_err(qdev, drv, qdev->ndev, "Could not read MPI, resetting RISC!\n"); ql_queue_fw_error(qdev); - } else + } else { /* Wake up the sleeping mpi_idc_work thread that is * waiting for this event. */ complete(&qdev->ide_completion); - + } return status; } @@ -353,8 +353,7 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp) status = ql_get_mb_sts(qdev, mbcp); if (status) { netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n"); - } - else { + } else { int i; netif_err(qdev, drv, qdev->ndev, "Lost AEN detected.\n"); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E170C2D0C6 for ; Wed, 11 Dec 2019 18:16:15 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18AFB206C3 for ; Wed, 11 Dec 2019 18:16:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fX6sP+zs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18AFB206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D51B188629; Wed, 11 Dec 2019 18:16:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SV0K1bNUvSYT; Wed, 11 Dec 2019 18:16:14 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 5E3C38861A; Wed, 11 Dec 2019 18:16:14 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1989B1BF473 for ; Wed, 11 Dec 2019 18:15:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0EB0C88619 for ; Wed, 11 Dec 2019 18:15:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7CsnNjv4xETV for ; Wed, 11 Dec 2019 18:15:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-yw1-f66.google.com (mail-yw1-f66.google.com [209.85.161.66]) by hemlock.osuosl.org (Postfix) with ESMTPS id 6D0028860D for ; Wed, 11 Dec 2019 18:15:39 +0000 (UTC) Received: by mail-yw1-f66.google.com with SMTP id 10so9308124ywv.5 for ; Wed, 11 Dec 2019 10:15:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+x/b256hi/BiDL31JHY2PQmq0IAPIM+EJHKCtlj8/GQ=; b=fX6sP+zsfo7QiNbgczb4g4RwNHoCbsE1Qdyiv+e78chsM5SpDb4VEhKpowEc//NJoF FjK35PxJAduy/TX/48sMOL3RShtFhvUhNwsxT+kqQaC0P0K8epI0Z9BONFqdXhvqaS+Z JdChIJ1NIBh4GYo0JeyRRonR7dGvME5szcK+5dxOzjyME0JL+5hqPSLt0c3rVPZ/CA/k TPT3c9y4uC/H5pA25FeD5hZNcBfMikGd+GN2ODylL4gQzHbNIveYNbU3TCBOyxk7Oodl 3ncupRw6DqkxFFMCl21ApGz5DExaUQ+K3+3oorm/IcwlBs/ngNQvTk+jo09qZUQCAVn2 CgQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+x/b256hi/BiDL31JHY2PQmq0IAPIM+EJHKCtlj8/GQ=; b=qFIHI3p6ZKZkzy9kWX/o0BLf/sv392xJa6H1601ao67eTzKzy6iJxnxt9vvYYvuF8J CVlONN0BeFph8mZuYXvSs006qtVFmMtDut62pLhkGRxePZXqYxOzZejPl6flMrfwyUpH sU3K5MVU1bwQNwPHMa9jGHH488BrB0of9vnvSK0wC4StUWIavigcSyQgiY3w9jaHqT6O 94Xcxhb5AqPB7Q3qdFEwFB2GQwAQlFflbA91A4cxrDkAFkPq/+cYT6mc5wcNa386yU6e dA+WtA3XcsbBWerWhJM2cPET7ueZK/+BlSN4Bv/IL9seKtfkfzu+ZNEXJzpCAb+LlDf3 /Jsw== X-Gm-Message-State: APjAAAXqXmiMZZtYSCTW58/TjPtG0P7vyG9tAsS6Yde1UXP7M72mUsXc Cbc4PuHg4P46pYb7dQRcsFo= X-Google-Smtp-Source: APXvYqy+8SSiMyc2gSAf5nlC+pArO37lD4CnuaJdfKdo8miRp32JKEQHg5OHDfOWK1+LzEnk0ZTCWg== X-Received: by 2002:a81:ad1a:: with SMTP id l26mr852793ywh.481.1576088138380; Wed, 11 Dec 2019 10:15:38 -0800 (PST) Received: from karen ([2604:2d80:d68a:cf00:a4bc:8e08:1748:387f]) by smtp.gmail.com with ESMTPSA id i84sm1341120ywc.43.2019.12.11.10.15.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 10:15:37 -0800 (PST) From: Scott Schafer To: gregkh@linuxfoundation.org Subject: [PATCH v2 22/23] staging: qlge: Fix CHECK: Unbalanced braces around else statement Date: Wed, 11 Dec 2019 12:12:51 -0600 Message-Id: <943bad431329fc77f515158444c6d06fbeeb66fe.1576086080.git.schaferjscott@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com, Manish Chopra , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Scott Schafer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Fix CHECK: Unbalanced braces around else statement in file qlge_mpi.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_mpi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c index ba8ce3506a59..c9d45c8feabe 100644 --- a/drivers/staging/qlge/qlge_mpi.c +++ b/drivers/staging/qlge/qlge_mpi.c @@ -244,12 +244,12 @@ static int ql_idc_cmplt_aen(struct ql_adapter *qdev) netif_err(qdev, drv, qdev->ndev, "Could not read MPI, resetting RISC!\n"); ql_queue_fw_error(qdev); - } else + } else { /* Wake up the sleeping mpi_idc_work thread that is * waiting for this event. */ complete(&qdev->ide_completion); - + } return status; } @@ -353,8 +353,7 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp) status = ql_get_mb_sts(qdev, mbcp); if (status) { netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n"); - } - else { + } else { int i; netif_err(qdev, drv, qdev->ndev, "Lost AEN detected.\n"); -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel