From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: btrfs space used issue
Date: Mon, 5 Mar 2018 11:17:35 -0500 [thread overview]
Message-ID: <94411d71-b9b7-b0ee-f61d-5c4a93b1ad41@gmail.com> (raw)
In-Reply-To: <20180305152827.GA27477@infradead.org>
On 2018-03-05 10:28, Christoph Hellwig wrote:
> On Sat, Mar 03, 2018 at 06:59:26AM +0000, Duncan wrote:
>> Indeed. Preallocation with COW doesn't make the sense it does on an
>> overwrite-in-place filesystem.
>
> It makes a whole lot of sense, it just is a little harder to implement.
>
> There is no reason not to preallocate specific space, or if you aren't
> forced to be fully log structured by the medium, specific blocks to
> COW into. It just isn't quite as trivial as for a rewrite in place
> file system to implement.
Yes, there's generally no reason not to pre-allocate space, but given
how BTRFS implements pre-allocation, it doesn't make sense to do so
pretty much at all for anything but NOCOW files, as it doesn't even
guarantee that you'll be able to write however much data you
pre-allocated space for (and it doesn't matter whether you use fallocate
or just write out a run of zeroes, either way does not work in a manner
consistent with how other filesystems do).
There's been discussion before about this, arising from the (completely
illogical given how fallocate is expected to behave) behavior that you
can fallocate more than half the free space on a BTRFS volume but will
then fail writes with -ENOSPC part way through actually writing data to
the pre-allocated space you just reserved (and that it can fail for
other reasons too with -ENOSPC).
next prev parent reply other threads:[~2018-03-05 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 13:09 btrfs space used issue vinayak hegde
2018-02-27 13:54 ` Austin S. Hemmelgarn
2018-02-28 6:01 ` vinayak hegde
2018-02-28 15:22 ` Andrei Borzenkov
2018-03-01 9:26 ` vinayak hegde
2018-03-01 10:18 ` Andrei Borzenkov
2018-03-01 12:25 ` Austin S. Hemmelgarn
2018-03-03 6:59 ` Duncan
2018-03-05 15:28 ` Christoph Hellwig
2018-03-05 16:17 ` Austin S. Hemmelgarn [this message]
2018-02-28 19:09 ` Duncan
2018-02-28 19:24 ` Austin S. Hemmelgarn
2018-02-28 19:54 ` Duncan
2018-02-28 20:15 ` Austin S. Hemmelgarn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94411d71-b9b7-b0ee-f61d-5c4a93b1ad41@gmail.com \
--to=ahferroin7@gmail.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.