All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
To: Valentin Vidic <Valentin.Vidic@CARNet.hr>
Cc: devel@driverdev.osuosl.org, "Derek Robson" <robsonde@gmail.com>,
	"Michael Panzlaff" <michael.panzlaff@fau.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Luca Söthe" <luca@acul.me>,
	linux-kernel@vger.kernel.org,
	"Marcin Ciupak" <marcin.s.ciupak@gmail.com>,
	"Marcus Wolf" <linux@Wolf-Entwicklungen.de>,
	"Simon Sandström" <simon@nikanor.nu>
Subject: Re: [PATCH] staging: pi433: add descriptions for mutex locks
Date: Fri, 23 Mar 2018 16:38:50 +0100	[thread overview]
Message-ID: <9442615c-5606-328a-f8cc-ad389af55ee3@smarthome-wolf.de> (raw)
In-Reply-To: <20180323114254.GL31333@gavran.carpriv.carnet.hr>

Hi Valentin,

I had no time to work on the code for monthes now and the memorisation
of my thoughts when I was programming that (approx. one year ago) is
quite pale.

As far as I remember, I read something, that the fifo has an integrated
protection, so no external protection is needed. But absolutely unsure.

If I will find some time within the next days, I'll have a look at the
code and try to recall.

But the most important thing already took place: We started thinking
about it :-)

Thanks,

Marcus

Am 23.03.2018 um 12:42 schrieb Valentin Vidic:
> On Fri, Mar 23, 2018 at 11:22:39AM +0100, Marcus Wolf wrote:
>> could you please decribe in short words, why you think, that hte lock
>> isn't obsolete?
>>
>> I wasn't sure, but close to remove the lock. That's why I putted the
>> comment.
> 
> Sure, if pi433_tx_thread runs on one CPU it might be possible
> to call pi433_write concurrently on another CPU and they would
> both modify tx_fifo.  But maybe there is some other protection
> in place that would prevent this?
> 

-- 
Smarthome-Wolf UG (haftungsbeschränkt)
Helene-Lange-Weg 23
80637 München
Amtsgericht München, HRB 223529
Umastzsteuer-ID: DE304719911
Geschäftsführer: Marcus Wolf
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-03-23 15:38 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23  9:47 [PATCH] staging: pi433: add descriptions for mutex locks Valentin Vidic
2018-03-23 10:22 ` Marcus Wolf
2018-03-23 11:42   ` Valentin Vidic
2018-03-23 15:38     ` Marcus Wolf [this message]
2018-03-23 18:00       ` Valentin Vidic
2018-03-23 22:18         ` Valentin Vidic
2018-03-24 22:09           ` [PATCH] staging: pi433: cleanup tx_fifo locking Valentin Vidic
2018-03-25 13:00           ` [PATCH] staging: pi433: add descriptions for mutex locks Marcus Wolf
2018-03-25 13:09             ` Valentin Vidic
2018-03-25 13:12               ` Marcus Wolf
2018-03-25 14:24                 ` Valentin Vidic
2018-04-08 14:15                   ` Marcus Wolf
2018-04-12 17:15                     ` Valentin Vidic
2018-04-19  9:25                       ` Marcus Wolf
2018-04-19  9:47                         ` Valentin Vidic
2018-04-19  9:55                           ` Marcus Wolf
2018-04-08 15:22               ` Marcus Wolf
2018-04-12 18:46                 ` Valentin Vidic
2018-04-19  9:33                   ` Marcus Wolf
2018-04-19 10:25                     ` [PATCH v2] staging: pi433: cleanup tx_fifo locking Valentin Vidic
2018-04-19 10:40                       ` Marcus Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9442615c-5606-328a-f8cc-ad389af55ee3@smarthome-wolf.de \
    --to=marcus.wolf@smarthome-wolf.de \
    --cc=Valentin.Vidic@CARNet.hr \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@Wolf-Entwicklungen.de \
    --cc=luca@acul.me \
    --cc=marcin.s.ciupak@gmail.com \
    --cc=michael.panzlaff@fau.de \
    --cc=robsonde@gmail.com \
    --cc=simon@nikanor.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.