From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [PATCH v2 06/25] app/testpmd: implement basic
 support	for rte_flow
Date: Mon, 19 Dec 2016 08:37:20 +0000
Message-ID: <94479800C636CB44BD422CB454846E013157433C@SHSMSX101.ccr.corp.intel.com>
References: <cover.1479309719.git.adrien.mazarguil@6wind.com>
 <cover.1481903839.git.adrien.mazarguil@6wind.com>
 <3318a43c9e105caaf4d5b13d6e4fcce774fb522f.1481903839.git.adrien.mazarguil@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Pei, Yulong" <yulong.pei@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 9A36EB33E
 for <dev@dpdk.org>; Mon, 19 Dec 2016 09:37:25 +0100 (CET)
In-Reply-To: <3318a43c9e105caaf4d5b13d6e4fcce774fb522f.1481903839.git.adrien.mazarguil@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Adrien,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil
> Sent: Saturday, December 17, 2016 12:25 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 06/25] app/testpmd: implement basic
> support for rte_flow
>=20
> Add basic management functions for the generic flow API (validate, create=
,
> destroy, flush, query and list). Flow rule objects and properties are arr=
anged
> in lists associated with each port.
>=20
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> +/** Create flow rule. */
> +int
> +port_flow_create(portid_t port_id,
> +		 const struct rte_flow_attr *attr,
> +		 const struct rte_flow_item *pattern,
> +		 const struct rte_flow_action *actions) {
> +	struct rte_flow *flow;
> +	struct rte_port *port;
> +	struct port_flow *pf;
> +	uint32_t id;
> +	struct rte_flow_error error;
> +

I think there should be memset for error here, e.g. memset(&error, 0, sizeo=
f(struct rte_flow_error));
Since both cause and message may be NULL regardless of the error type, if t=
here's no error.cause and error.message returned from PMD, Segmentation fau=
lt will happen in port_flow_complain.
PS: This issue doesn't happen if add "export EXTRA_CFLAGS=3D' -g O0'" when =
compiling.

Thanks
Beilei

> +	flow =3D rte_flow_create(port_id, attr, pattern, actions, &error);
> +	if (!flow)
> +		return port_flow_complain(&error);
> +	port =3D &ports[port_id];
> +	if (port->flow_list) {
> +		if (port->flow_list->id =3D=3D UINT32_MAX) {
> +			printf("Highest rule ID is already assigned, delete"
> +			       " it first");
> +			rte_flow_destroy(port_id, flow, NULL);
> +			return -ENOMEM;
> +		}
> +		id =3D port->flow_list->id + 1;
> +	} else
> +		id =3D 0;
> +	pf =3D port_flow_new(attr, pattern, actions);
> +	if (!pf) {
> +		int err =3D rte_errno;
> +
> +		printf("Cannot allocate flow: %s\n", rte_strerror(err));
> +		rte_flow_destroy(port_id, flow, NULL);
> +		return -err;
> +	}
> +	pf->next =3D port->flow_list;
> +	pf->id =3D id;
> +	pf->flow =3D flow;
> +	port->flow_list =3D pf;
> +	printf("Flow rule #%u created\n", pf->id);
> +	return 0;
> +}
> +