From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [PATCH 3/3] net/i40e: enable cloud filter for MPLS
Date: Thu, 9 Mar 2017 03:57:01 +0000
Message-ID: <94479800C636CB44BD422CB454846E01315A7BE5@SHSMSX101.ccr.corp.intel.com>
References: <1488534236-29904-1-git-send-email-beilei.xing@intel.com>
 <1488534236-29904-4-git-send-email-beilei.xing@intel.com>
 <e77fce50-034b-f151-0ac2-da5e05a16d11@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id D1F952C49
 for <dev@dpdk.org>; Thu,  9 Mar 2017 04:57:05 +0100 (CET)
In-Reply-To: <e77fce50-034b-f151-0ac2-da5e05a16d11@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, March 9, 2017 12:06 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel=
.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 3/3] net/i40e: enable cloud filter for MPL=
S
>=20
> On 3/3/2017 9:43 AM, Beilei Xing wrote:
> > This patch enables MPLSoUDP and MPLSoGRE cloud filter with replace
> > cloud filter.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>=20
> <...>
>=20
> > @@ -1286,6 +1286,9 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)
> >  	if (ret < 0)
> >  		goto err_init_fdir_filter_list;
> >
> > +	i40e_replace_mpls_l1_filter(pf);
> > +	i40e_replace_mpls_cloud_filter(pf);
>=20
> Hi Beilei,
>=20
> Can you please help me to understand what has been replaced here, and
> why?

* Cloud filters type is a combination of up to 3 L1 filters.
* L1 filter depends on Type Rule index.

First, there's no MPLS label as L1 filter currently, so we need to add MPLS=
 label by replacing some existing L1 filter, here we replace IMAC.
Second, there's no MPLS label as cloud filter currently, So here we add a n=
ew cloud filter type TEID_MPLS (0x11) to replace Inner MAC filter(0xA).

According to datasheet, the following filter types are supported by cloud f=
ilter.
6:0: Filter type:
* 0x0: Reserved
* 0x1: Reserved=20
* 0x2: Reserved=20
* 0x3: Inner MAC, Inner VLAN (for NVGRE, VXLAN or, Geneve or VXLAN-GPE pack=
ets)
* 0x4: Inner MAC, Inner VLAN, Tenant ID (for NVGRE, VXLAN, or Geneve or VXL=
AN-GPE
packets)
* 0x5: Reserved=20
* 0x6: {Inner MAC, Tenant ID} (NVGRE packet, or VXLAN, /Geneve or VXLAN-GPE=
 packets).
* 0x7: Reserved=20
* 0x8: Reserved=20
* 0x9: Outer MAC L2 filter
* 0xA: Inner MAC filter
* 0xB: Outer MAC, Tenant ID, Inner MAC
* 0xC: Application Destination IP
* 0xD: Application Source-IP, Inner MAC.
* 0xE - 0x3F: Reserved.

>=20
> Thanks,
> ferruh
>=20
> <...>