From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [PATCH v3 1/2] net/i40e: extended list of operations
 for ddp processing
Date: Wed, 28 Jun 2017 08:03:13 +0000
Message-ID: <94479800C636CB44BD422CB454846E0131FD8F92@SHSMSX101.ccr.corp.intel.com>
References: <1495901077-11845-1-git-send-email-andrey.chilikin@intel.com>
 <1498570513-8592-2-git-send-email-andrey.chilikin@intel.com>
 <94479800C636CB44BD422CB454846E0131FD8F09@SHSMSX101.ccr.corp.intel.com>
 <AAC06825A3B29643AF5372F5E0DDF0538DBA24D7@IRSMSX106.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Chilikin, Andrey" <andrey.chilikin@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 3D7FF2C13
 for <dev@dpdk.org>; Wed, 28 Jun 2017 10:03:31 +0200 (CEST)
In-Reply-To: <AAC06825A3B29643AF5372F5E0DDF0538DBA24D7@IRSMSX106.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Andrey,

> -----Original Message-----
> From: Chilikin, Andrey
> Sent: Wednesday, June 28, 2017 3:40 PM
> To: Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>
> Subject: RE: [PATCH v3 1/2] net/i40e: extended list of operations for ddp
> processing
>=20
> Hi Beilei,
>=20
> > -----Original Message-----
> > From: Xing, Beilei
> > Sent: Wednesday, June 28, 2017 7:58 AM
> > To: Chilikin, Andrey <andrey.chilikin@intel.com>; dev@dpdk.org
> > Cc: Wu, Jingjing <jingjing.wu@intel.com>
> > Subject: RE: [PATCH v3 1/2] net/i40e: extended list of operations for
> > ddp processing
> >
> > Hi Andrey,
> >
> <snip>
> > > +	}
> > > +	else {
> >
> > Should be  } else {  here according to the coding style.
>=20
> Will fix in v4
>=20
> > > --- a/drivers/net/i40e/rte_pmd_i40e.h
> > > +++ b/drivers/net/i40e/rte_pmd_i40e.h
> > > @@ -71,6 +71,8 @@ struct rte_pmd_i40e_mb_event_param {  enum
> > > rte_pmd_i40e_package_op {
> > >  	RTE_PMD_I40E_PKG_OP_UNDEFINED =3D 0,
> > >  	RTE_PMD_I40E_PKG_OP_WR_ADD,   /**< load package and add to
> > > info list */
> > > +	RTE_PMD_I40E_PKG_OP_WR_DEL, /**< load package and delete
> > > from info list */
> > > +	RTE_PMD_I40E_PKG_OP_WR_ONLY, /**< load package without
> > > modifying info
> > > +list */
> >
> > The only difference between RTE_PMD_I40E_PKG_OP_WR_ADD and
> > RTE_PMD_I40E_PKG_OP_WR_ONLY is if need to change info list, right? Is
> > there any difference between the profiles added? Do we need another
> > CLI in testpmd to indicate how/when we need to use
> RTE_PMD_I40E_PKG_OP_WR_ONLY?
> >
> I believe that existing testpmd CLI is enough for i40e as this 'if' state=
ment if
> (track_id && (op !=3D RTE_PMD_I40E_PKG_OP_WR_ONLY)) { will not register
> profiles with track_id =3D=3D 0
>=20

OK, so track_id=3D0 is for RTE_PMD_I40E_PKG_OP_WR_ONLY. From the patch, it =
seems we needn't new operation RTE_PMD_I40E_PKG_OP_WR_ONLY exposed to appli=
cation as PMD can decide if register WR_ONLY profiles by track_id.=20