From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [PATCH v6 2/8] net/i40e: update ptype and pctype info
Date: Fri, 29 Sep 2017 13:24:46 +0000
Message-ID: <94479800C636CB44BD422CB454846E013203901C@SHSMSX101.ccr.corp.intel.com>
References: <1506565054-67690-1-git-send-email-beilei.xing@intel.com>
 <1506662342-18966-1-git-send-email-beilei.xing@intel.com>
 <1506662342-18966-3-git-send-email-beilei.xing@intel.com>
 <9BB6961774997848B5B42BEC655768F810E83DD8@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Chilikin, Andrey" <andrey.chilikin@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4FE9F397D
 for <dev@dpdk.org>; Fri, 29 Sep 2017 15:24:49 +0200 (CEST)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810E83DD8@SHSMSX103.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: Wu, Jingjing
> Sent: Friday, September 29, 2017 9:23 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: Chilikin, Andrey <andrey.chilikin@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH v6 2/8] net/i40e: update ptype and pctype info
>=20
>=20
>=20
> > -----Original Message-----
> > From: Xing, Beilei
> > Sent: Friday, September 29, 2017 1:19 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: Chilikin, Andrey <andrey.chilikin@intel.com>; dev@dpdk.org
> > Subject: [PATCH v6 2/8] net/i40e: update ptype and pctype info
> >
> > Update new packet type and new pctype info when downloading profile.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>=20
> [......]
>=20
>=20
> > +	ret =3D rte_pmd_i40e_ptype_mapping_update(port_id, ptype_mapping,
> > +						ptype_num, 0);
> > +	if (ret) {
> > +		PMD_DRV_LOG(ERR, "Failed to update mapping table.");
> > +		rte_free(ptype_mapping);
> > +		rte_free(ptype);
> > +		return -1;
> > +	}
> > +
> > +	rte_free(ptype_mapping);
> > +	rte_free(ptype);
> > +	return 0;
>=20
> Minor comments, how about:
> 	if (ret)
> 		PMD_DRV_LOG(ERR, "Failed to update mapping table.");
>=20
> 	rte_free(ptype_mapping);
> 	rte_free(ptype);
> 	return ret;
>=20

Will update in next version.

>=20
> Reviewed-by: Jingjing Wu <jingjing.wu@intel.com>