Re: [PATCH v8 1/2] net/i40e: support input set configuration

["Xing, Beilei" <beilei.xing@intel.com>]

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 10, 2018 8:13 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi
> Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Chilikin, Andrey <andrey.chilikin@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v8 1/2] net/i40e: support input set
> configuration
> 
> On 1/8/2018 3:09 AM, Beilei Xing wrote:
> > +static inline int
> > +rte_pmd_i40e_inset_field_clear(uint64_t *inset, uint8_t field_idx) {
> > +	uint8_t bit_idx;
> > +
> > +	if (field_idx > 63)
> > +		return -1;
> > +
> > +	bit_idx = 63 - field_idx;
> > +	*inset = *inset & ~(1ULL << bit_idx);
> > +
> > +	return 0;
> > +}
> > +
> >  #endif /* _PMD_I40E_H_ */
> > diff --git a/drivers/net/i40e/rte_pmd_i40e_version.map
> > b/drivers/net/i40e/rte_pmd_i40e_version.map
> > index ebbd24e..0fafadd 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e_version.map
> > +++ b/drivers/net/i40e/rte_pmd_i40e_version.map
> > @@ -58,3 +58,13 @@ DPDK_17.11 {
> >  	rte_pmd_i40e_rss_queue_region_conf;
> >
> >  } DPDK_17.08;
> > +
> > +DPDK_18.02 {
> > +	global:
> > +
> > +	rte_pmd_i40e_inset_get;
> > +	rte_pmd_i40e_inset_set;
> > +	rte_pmd_i40e_inset_field_get;
> > +	rte_pmd_i40e_inset_field_set;
> > +	rte_pmd_i40e_inset_field_clear;
> 
> I think we don't need static inline functions in linker script, do we?

Static inline functions are just used as helper functions, maybe we don't need them in linker script, I will send a new patch to delete it, thanks.

> 
> > +} DPDK_17.11;