From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [PATCH v2] net/i40e: fix packet type parser issue
Date: Mon, 15 Jan 2018 07:26:50 +0000
Message-ID: <94479800C636CB44BD422CB454846E013208C830@SHSMSX101.ccr.corp.intel.com>
References: <1515665027-105293-1-git-send-email-beilei.xing@intel.com>
 <1515746494-86927-1-git-send-email-beilei.xing@intel.com>
 <039ED4275CED7440929022BC67E706115312D4B4@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <039ED4275CED7440929022BC67E706115312D4B4@SHSMSX103.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Sunday, January 14, 2018 12:02 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH v2] net/i40e: fix packet type parser issue
>=20
>=20
>=20
> > -----Original Message-----
> > From: Xing, Beilei
> > Sent: Friday, January 12, 2018 4:42 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: [PATCH v2] net/i40e: fix packet type parser issue
> >
> > Ptype mapping table will fail to update when loading PPP profile, fix
> > the issue via modifying metadata and adding check.
> > This patch also adds parser for IPV4FRAG and IPV6FRAG.
> >
> > Fixes: ab2e350c4f4b ("net/i40e: improve packet type parser")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> >
> > v2 changes:
> >  - Add parser for IPV4FRAG and IPV6FRAG.
> >
> >  drivers/net/i40e/i40e_ethdev.c  | 44
> > ++++++++++++++++++++++++++---------------
> >  drivers/net/i40e/rte_pmd_i40e.c |  6 ++++--
> >  2 files changed, 32 insertions(+), 18 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index d80671a..69704e3 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -11283,43 +11283,55 @@ i40e_update_customized_ptype(struct
> > rte_eth_dev *dev, uint8_t *pkg,
> >  					continue;
> >  				memset(name, 0, sizeof(name));
> >  				strcpy(name, proto[n].name);
> > -				if (!strncmp(name, "PPPOE", 5))
> > +				if (!strncmp(name, "PPPoE", 5))
> >  					ptype_mapping[i].sw_ptype |=3D
> >
> 	RTE_PTYPE_L2_ETHER_PPPOE;
> > -				else if (!strncmp(name, "OIPV4", 5)) {
> > +				else if (!strncmp(name, "IPV4FRAG", 8) &&
> > +					 !in_tunnel) {
> >  					ptype_mapping[i].sw_ptype |=3D
> >
> 	RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> > -					in_tunnel =3D true;
> > -				} else if (!strncmp(name, "IPV4", 4) &&
> > -					   !in_tunnel)
> >  					ptype_mapping[i].sw_ptype |=3D
> > -
> 	RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> > -				else if (!strncmp(name, "IPV4FRAG", 8) &&
> > -					 in_tunnel) {
> > +						RTE_PTYPE_L4_FRAG;
> > +				} else if (!strncmp(name, "IPV4FRAG", 8) &&
> > +					   in_tunnel) {
> >  					ptype_mapping[i].sw_ptype |=3D
> >
> RTE_PTYPE_INNER_L3_IPV4_EXT_UNKNOWN;
> >  					ptype_mapping[i].sw_ptype |=3D
> >  						RTE_PTYPE_INNER_L4_FRAG;
> >  				} else if (!strncmp(name, "IPV4", 4) &&
> > +					   !in_tunnel)
> > +					ptype_mapping[i].sw_ptype |=3D
> > +
> 	RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> > +				else if (!strncmp(name, "OIPV4", 5)) {
> > +					ptype_mapping[i].sw_ptype |=3D
> > +
> 	RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> > +					in_tunnel =3D true;
> > +				} else if (!strncmp(name, "IPV4", 4) &&
> >  					   in_tunnel)
> Since you are doing some reordering here, it's better to move IPV4 &&
> in_tunnel case above OIPV4, to match IPV4 && !in_tunnel case.

OK, will update in next version, thanks.