From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:27048 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbgAJJFi (ORCPT ); Fri, 10 Jan 2020 04:05:38 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00A8vfk2038213 for ; Fri, 10 Jan 2020 04:05:37 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xeeywbf6n-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 10 Jan 2020 04:05:37 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Jan 2020 09:05:35 -0000 Subject: Re: [PATCH v4] KVM: s390: Add new reset vcpu API References: <20200109155602.18985-1-frankja@linux.ibm.com> <20200109180841.6843cb92.cohuck@redhat.com> <90f65536-c2bb-9234-aef4-7941d477369e@linux.ibm.com> From: Christian Borntraeger Date: Fri, 10 Jan 2020 10:05:30 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Message-Id: <94487666-c518-de30-12e6-1848ab3a8313@de.ibm.com> Sender: linux-s390-owner@vger.kernel.org List-ID: To: Thomas Huth , Janosch Frank , Cornelia Huck Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, david@redhat.com On 10.01.20 09:49, Thomas Huth wrote: > > As you said, it's mostly a matter of taste, but at least in my eyes this > approach with fallthroughs and the additional parameter looks rather > harder to understand compared to what I've suggested. Agreed. A parameter makes the code harder to grasp.