From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "lorenzo.bianconi@redhat.com" <lorenzo.bianconi@redhat.com>
Subject: RE: [PATCH net-next] net: ice: ptp: fix compilation warning if PTP_1588_CLOCK is disabled
Date: Tue, 15 Jun 2021 19:10:20 +0000 [thread overview]
Message-ID: <94536f439c894854b5109e77e830729c@intel.com> (raw)
In-Reply-To: <a4d2c3cd609708de38ca59b75e4eb7468750af47.1623766418.git.lorenzo@kernel.org>
> -----Original Message-----
> From: Lorenzo Bianconi <lorenzo@kernel.org>
> Sent: Tuesday, June 15, 2021 7:14 AM
> To: netdev@vger.kernel.org
> Cc: lorenzo.bianconi@redhat.com; Keller, Jacob E <jacob.e.keller@intel.com>
> Subject: [PATCH net-next] net: ice: ptp: fix compilation warning if
> PTP_1588_CLOCK is disabled
>
> Fix the following compilation warning if PTP_1588_CLOCK is not enabled
>
> drivers/net/ethernet/intel/ice/ice_ptp.h:149:1:
> error: return type defaults to ‘int’ [-Werror=return-type]
> ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
>
> Fixes: ea9b847cda647 ("ice: enable transmit timestamps for E810 devices")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Hah. Thanks. This is obviously correct.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_ptp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.h
> b/drivers/net/ethernet/intel/ice/ice_ptp.h
> index 41e14f98f0e6..d01507eba036 100644
> --- a/drivers/net/ethernet/intel/ice/ice_ptp.h
> +++ b/drivers/net/ethernet/intel/ice/ice_ptp.h
> @@ -145,7 +145,7 @@ static inline int ice_get_ptp_clock_index(struct ice_pf *pf)
> return -1;
> }
>
> -static inline
> +static inline s8
> ice_ptp_request_ts(struct ice_ptp_tx *tx, struct sk_buff *skb)
> {
> return -1;
> --
> 2.31.1
prev parent reply other threads:[~2021-06-15 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 14:14 [PATCH net-next] net: ice: ptp: fix compilation warning if PTP_1588_CLOCK is disabled Lorenzo Bianconi
2021-06-15 19:10 ` Keller, Jacob E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94536f439c894854b5109e77e830729c@intel.com \
--to=jacob.e.keller@intel.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.