All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Xu, Quan" <quan.xu@intel.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure
Date: Fri, 30 Jan 2015 01:46:18 +0000	[thread overview]
Message-ID: <945CA011AD5F084CBEA3E851C0AB28890E8802DB@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1501291732160.9702@kaball.uk.xensource.com>


> > > I think that the xenstore_update function should be moved to a new file:
> > > we don't want xen_backend.c to be handling any frontend updates.
> > > Maybe you could create a new file, hw/xen/xen_pvdev.c?
> > >
> >
> > Stefano,
> > 	I'd like to create hw/xen/xen_pvdev.c , include/hw/xen/ xen_pvdev.h
> > and include/hw/xen/xen_frontend.h
> >
> > include/hw/xen/ xen_pvdev.h is for
> > struct XenDevOps{} and struct XenDevice {} definition and some other macro.
> >
> > include/hw/xen/xen_frontend.h is for
> > xen frontend interface, such as xen_fe_register() .etc
> >
> > hw/xen/xen_pvdev.c is for
> > some general parts of xen_backend/xen_frontend.
> > It includes xenstore_update function xendevs management, such as
> > xen_qtail_insert_xendev(..),
> > xenstore_update(...) .etc.
> >
> > do you agree with it?
> 
> It seems reasonable.

Thanks, I will do it ASAP. Now I have fixed most of comments. 

-Quan

  parent reply	other threads:[~2015-01-30  1:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-30 23:03 [Qemu-devel] [v3 2/5] Qemu-Xen-vTPM: Xen frontend driver infrastructure Quan Xu
2014-12-30 23:03 ` Quan Xu
2015-01-19 17:15 ` [Qemu-devel] " Stefano Stabellini
2015-01-19 17:15   ` Stefano Stabellini
2015-01-20  2:47   ` Xu, Quan
2015-01-20  2:47   ` [Qemu-devel] " Xu, Quan
2015-01-20 10:46     ` Stefano Stabellini
2015-01-20 10:46     ` [Qemu-devel] " Stefano Stabellini
2015-01-29 16:07   ` Xu, Quan
2015-01-29 17:32     ` Stefano Stabellini
2015-01-29 17:32     ` [Qemu-devel] " Stefano Stabellini
2015-01-30  1:46       ` Xu, Quan
2015-01-30  1:46       ` Xu, Quan [this message]
2015-01-29 16:07   ` Xu, Quan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=945CA011AD5F084CBEA3E851C0AB28890E8802DB@SHSMSX101.ccr.corp.intel.com \
    --to=quan.xu@intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.