From: "Xu, Quan" <quan.xu@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"Wu, Feng" <feng.wu@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue
Date: Thu, 23 Jun 2016 02:08:17 +0000 [thread overview]
Message-ID: <945CA011AD5F084CBEA3E851C0AB28894B8F57DE@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <576AD67302000078000F7C7F@prv-mh.provo.novell.com>
On June 23, 2016 12:18 AM, Jan Beulich <JBeulich@suse.com> wrote:
> >>> On 22.06.16 at 17:54, <quan.xu@intel.com> wrote:
> > On June 17, 2016 3:01 PM, Jan Beulich <JBeulich@suse.com> wrote:
> >> And again I don't understand: ASSERT()s are to verify assumed state.
> >> If
> > static
> >> code analysis resulted in understanding a function is unreachable
> >> when qi_ctrl->qinval_maddr is zero (because qinval ought to have got
> >> disabled if
> > any
> >> of the table setup failed), then adding ASSERT() would (a) document
> >> that and
> >> (b) allow to know quickly if something broke that assumption.
> >
> > other than enable_qinval() -- yes, I need to convert conditionals of
> > qi_ctrl->qinval_maddr into ASSERT()s..
> > But in enable_qinval(), I am still not quite sure whether I need to
> > convert these conditionals of qi_ctrl->qinval_maddr into ASSERT()s or
> > not.
>
> No, I don't think you want to so there - you'd bring the system down in case
> of an actual initialization error. ASSERT()s should only be used on conditions
> controlled entirely by the hypervisor.
>
Jan, thank you. Now I am clear.
Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-23 2:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 9:05 [Patch v11 0/3] VT-d Device-TLB flush issue Xu, Quan
2016-06-01 9:05 ` [Patch v11 1/3] IOMMU: add a timeout parameter for device IOTLB invalidation Xu, Quan
2016-06-02 10:24 ` Jan Beulich
2016-06-15 2:55 ` Xu, Quan
2016-06-01 9:05 ` [Patch v11 2/3] vt-d: synchronize for Device-TLB flush one by one Xu, Quan
2016-06-02 10:49 ` Jan Beulich
2016-06-01 9:05 ` [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue Xu, Quan
2016-06-02 11:07 ` Jan Beulich
2016-06-16 8:42 ` Xu, Quan
2016-06-16 9:04 ` Jan Beulich
2016-06-17 6:08 ` Xu, Quan
2016-06-17 7:00 ` Jan Beulich
2016-06-17 8:15 ` Xu, Quan
2016-06-17 8:40 ` Jan Beulich
2016-06-22 15:54 ` Xu, Quan
2016-06-22 16:18 ` Jan Beulich
2016-06-23 2:08 ` Xu, Quan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=945CA011AD5F084CBEA3E851C0AB28894B8F57DE@SHSMSX101.ccr.corp.intel.com \
--to=quan.xu@intel.com \
--cc=JBeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.