From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBAFC10F00 for ; Tue, 12 Mar 2019 17:57:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F70F205C9 for ; Tue, 12 Mar 2019 17:57:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728977AbfCLR5G (ORCPT ); Tue, 12 Mar 2019 13:57:06 -0400 Received: from mail.bugwerft.de ([46.23.86.59]:54910 "EHLO mail.bugwerft.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728132AbfCLR5F (ORCPT ); Tue, 12 Mar 2019 13:57:05 -0400 X-Greylist: delayed 362 seconds by postgrey-1.27 at vger.kernel.org; Tue, 12 Mar 2019 13:57:03 EDT Received: from [192.168.178.170] (pD95EF672.dip0.t-ipconnect.de [217.94.246.114]) by mail.bugwerft.de (Postfix) with ESMTPSA id C27CF369CF0; Tue, 12 Mar 2019 17:49:54 +0000 (UTC) Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify callback To: Heiko Stuebner , Andrew Lunn , david.wu@rock-chips.com Cc: David Miller , hkallweit1@gmail.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <411b1c33-a245-0706-8afd-c4bea1b90f68@gmail.com> <20190304.113025.1437399524067140375.davem@davemloft.net> <20190304200630.GJ26378@lunn.ch> <3079158.ITs3Wk0qno@phil> From: Daniel Mack Openpgp: preference=signencrypt Autocrypt: addr=daniel@zonque.org; prefer-encrypt=mutual; keydata= mQINBFJqOksBEADTAqNa32jIMmtknN+kbl2QCQ+O8onAyfBXW2+ULByC+54ELTsKnuAChxYB pimYqixmqbD9f7PrnU4/zAEMr8yJaTLp1uFHN1Qivx268wVlFBP+rnhULsiwcsJVWWIeeUxR Fk6V7K8RQMGsk0jwTfF+zHfKc7qPIMVh7peZalyIn6giqcQKM6SNrsCjLKlIachR/SstmMOG 5sXkykOh0pqgqj0aDzs2H9UYJyuA1OTkrN8AwA6SgwbZxRThdgbFKY7WaBPALcGK+89OCtwE UV6SIF9cUd0EvaqyawJbjPGRFJ4KckAfZYRdRWtd+2njeC9hehfB/mQVDBzHtquSO6HPKqt/ 4hDtQDXv4qAyBNDi50uXmORKxSJkcFlBGAl0RGOCcegilCfjQHX6XHPXbAfuoJGYyt1i4Iuy Doz5KVxm0SPftRNfg5eVKm3akIEdR1HI315866/QInkinngZ8BItVj+B89pwcbMcaG4cFcB8 4sWOLDPiGob2oaMe88y3whxVW8a+PAyfvesLJFeLGfjtBOO1sGtUa/qudcqS74oyfqVmRz+V sxEQ9xW9MZsZuvZYNT9nHGAP4ekpAs/ZGYX2sraU8394EDhKb2tkQz952D7BH2/xrGleOar2 BnkuCR/M9iS2BPNTYZEYQfIdj7NI3Qbn4vKtM3IMnPWRFS7ZuQARAQABtB9EYW5pZWwgTWFj ayA8ZGFuaWVsQHpvbnF1ZS5vcmc+iQI7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIe AQIXgAIZAQUCWom+IAAKCRC6YTEa/GNUJDAiD/42ybmeJ4r9yEmdgJraRiDDdcMTPuDwRICQ oxiMBph+eBjdveCaG4K2IjbUouhXKXVAiugSbyHWL9vcBzcPIy+mcxCSf0BC6BCzhR60ontC GTZAGNXVL98RhlnDGtFBPKZfXy1V8LaAe9puyBysv3/RAanc85B6Rv0bMRh/1nKf2rQWHmM5 bnPrxSDh2X3CJEMCCtoTo5jZ3YnkZae7DmVL/0JWGrCPfTXrBsJi+EVNFy2D57DdAWFbcl8C eiQrwBPfVomQTQ0EgLl8gC2V1UxjgdBy3Vpf0MIjlNvE0Lv3MPCwV3X33+07wtpGK7DzJY8N MI+Woe/Qp49QenYL2Xx/R7frfdIG4HAnUaeIGR+1PGqbX9Kc3htKIP9DV3j9xLHkIfhI+2HH HEptLuoewPS2egdtJo4LNWM7WMquJcve/dMae2MWlLfPQiTTy8RUPd8PtTSxrmUAYwGzAPYQ JATxoi/g02BtwsxNxp9gN9tlPEdP+0O2vptN3leADrt6nW495TlbuYwJaz4VPGrkziKpV9HU KgGaRwr0/RpONO4TFk6wTIa2Tak/y8s7rfnr+t7OVp7gG7/CKozRZMv/YijQhelMk4D6E6UI oE5ZQ7bkBRZj0V3fkFl7FM1wzk1WJ2jUhw3wNIy5vQ36rTCoeLDEVpZO1MeVh09FbEDJkBu5 SrkCDQRSajpLARAA4lEVCaGHcCIhxLSxvPjgzj7BzpmPaJbMd92DeKtUcB2vHhhuqa0WQSGO jKlaQdTqowVIQ974snsmNNwF5w8mss46T1X+2WS7YKAyn4dDScukY54thYthOkOn4DbKV6S0 4IV30DL9/5iQHszl9FNY7MIdvwMM7ozxJYrUv+wKcfOBh4zbFisXCu+jPobyKe+5XurJXXZ9 2aSDkrKPT9zKSUz+fElb/mL7o4NCeQcK5yvKMgj1MqT7O+V5F3gM/bh0srNMxL8w27pgYm6e O99M3vNkRd+qyXOsc6dLqgSkxsoRuWVX8vJROi6gMdn7O/AZ85t5paFIj5rqRJyYTPDRKN2Z ayT+ZPlF14b6LaodbPbZXEwiPfGhUwuVSwUjKHjcJMLLi5vq62fq1X/cCi2midjFY6nQsSn9 Mldx6v7JJWW8hvlnw+smduhg0UCfwx0KCI9wSPE2MUbm6KKS4DwAPbi0WCeUcNzRUxTCAs6c a9EOH0qsEAH7vwLzCf5lFiTMolhDJLZrsYvS1MBN4FxsyC7MMW2j4rMk2v0STORRGNY5oxrn LAO52ns135O2A22Mnhqo+ssjhJQAvEr5f13/qUEP0w79Qg9BUE5yfwJsalhgVfEvKabrNDKu a7UqNZ5lJZO2TdCi7OYl34WEnS3e+3qY2oHSL5n4kLiT/v+/1U0AEQEAAYkCHwQYAQIACQIb DAUCV6sTCAAKCRC6YTEa/GNUJHw5D/4luZ1GFCPW8kqkmpBUFTVjZqOhhT+z0KnrBsisJSOH VR8MraCDWHo/u4PTgqwF38PvyeZ4jXTXv+5FYjN6sJ8ydnfsUOORoM/KUafXmAug3zafqFd9 CzELh8FutTRYncoJMmL2HAbHqQRZlcFj6mKYFKqN+pA3tPbl3QpDORxMzeSn0J4sQeaVkIw2 inqYKTW+7vMi9/toMBNPEJPgSG77opYcEVjtDCPeAermjt6Ypqb0NyvE7zHLXpw3zcIA+Zge 0VIIW5bXco8520SJfDCKlS3IJlxOGgLVbcWwMayhO8cw8kWHg4KqjWQPvfsuhALGUidfhC3h L/o+2sOPZXT09OIR4arkuWH7xPF2X+L13TJ52OqVt0ERX5D9/7AwTArpCK6Vr3hybscBwFdW DduIc9DAFQ4AzQuURhAP2wHBmayrVDdtwtZVxyO6b6G2brkdbCpFEzeg66Q1jp/R5GXgNMBi qkqS7nnXncMTx6jmMAxHQ3XoXzPIZmBvWmD9Z0gCyTU6lSFSiGLO7KegnaRgBlJX/kmZ7Xfu YbiKOFbQ6XDctinOnZW5HFQiNQ+qkkx/CEcC1tXPY+JMjmA43KfCtwCjZbmi/bmb1JHJNZ9O H/iGc7WLxMDmqqBiZcQMQ0fcvv9Pj/NM8qNTDPtWeMwHV1p5s/U9nT8E35Hvbwx1Zg== Message-ID: <945fb25c-c854-27f3-1e98-18a5c981d59f@zonque.org> Date: Tue, 12 Mar 2019 18:50:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <3079158.ITs3Wk0qno@phil> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/3/2019 1:27 PM, Heiko Stuebner wrote: > Hi Andrew, Heiner, > > Am Montag, 4. März 2019, 21:06:30 CET schrieb Andrew Lunn: >> On Mon, Mar 04, 2019 at 11:30:25AM -0800, David Miller wrote: >>> From: Heiner Kallweit >>> Date: Sun, 3 Mar 2019 19:58:57 +0100 >>> >>>> Currently the Phy driver's link_change_notify callback is called >>>> whenever the state machine is run (every second if polling), no matter >>>> whether the state changed or not. This isn't needed and may confuse >>>> users considering the name of the callback. Therefore let's change >>>> the behavior and call this callback only in case of an actual >>>> state change. >>>> >>>> This requires changes to the at803x and rockchip drivers. >>>> at803x can be simplified so that it reacts on a state change to >>>> PHY_NOLINK only. >>>> The rockchip driver can also be much simplified. We simply re-init >>>> the AFE/DSP registers whenever we change to PHY_RUNNING and speed >>>> is 100Mbps. This causes very small overhead because we do this even >>>> if the speed was 100Mbps already. But this is neglectable and >>>> I think justified by the much simpler code. >>>> >>>> Changes are compile-tested only. >>>> >>>> Signed-off-by: Heiner Kallweit >>> >>> Someone please review this. >> >> Hi David >> >> We should probably wait for a Tested-by: from Daniel Mack >> and David Wu , or >> equivalent. > > We should probably add them to the list of recipients if we want > tests from them, which I've done now. > > @David: patch in question that changes the Rockchip eth-phy is > https://patchwork.kernel.org/patch/10837217/ > > Sadly I don't have matching hardware to test this myself. Thanks for considering me, but I don't have access to that hardware either right now. The changes look straight forward to me however, so just go ahead an apply this. Once I get back to that setup, I'll report in case of a regression. Thanks, Dainel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH net-next] net: phy: improve handling link_change_notify callback Date: Tue, 12 Mar 2019 18:50:59 +0100 Message-ID: <945fb25c-c854-27f3-1e98-18a5c981d59f@zonque.org> References: <411b1c33-a245-0706-8afd-c4bea1b90f68@gmail.com> <20190304.113025.1437399524067140375.davem@davemloft.net> <20190304200630.GJ26378@lunn.ch> <3079158.ITs3Wk0qno@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <3079158.ITs3Wk0qno@phil> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Heiko Stuebner , Andrew Lunn , david.wu@rock-chips.com Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, David Miller , linux-arm-kernel@lists.infradead.org, hkallweit1@gmail.com List-Id: linux-rockchip.vger.kernel.org T24gMTIvMy8yMDE5IDE6MjcgUE0sIEhlaWtvIFN0dWVibmVyIHdyb3RlOgo+IEhpIEFuZHJldywg SGVpbmVyLAo+IAo+IEFtIE1vbnRhZywgNC4gTcOkcnogMjAxOSwgMjE6MDY6MzAgQ0VUIHNjaHJp ZWIgQW5kcmV3IEx1bm46Cj4+IE9uIE1vbiwgTWFyIDA0LCAyMDE5IGF0IDExOjMwOjI1QU0gLTA4 MDAsIERhdmlkIE1pbGxlciB3cm90ZToKPj4+IEZyb206IEhlaW5lciBLYWxsd2VpdCA8aGthbGx3 ZWl0MUBnbWFpbC5jb20+Cj4+PiBEYXRlOiBTdW4sIDMgTWFyIDIwMTkgMTk6NTg6NTcgKzAxMDAK Pj4+Cj4+Pj4gQ3VycmVudGx5IHRoZSBQaHkgZHJpdmVyJ3MgbGlua19jaGFuZ2Vfbm90aWZ5IGNh bGxiYWNrIGlzIGNhbGxlZAo+Pj4+IHdoZW5ldmVyIHRoZSBzdGF0ZSBtYWNoaW5lIGlzIHJ1biAo ZXZlcnkgc2Vjb25kIGlmIHBvbGxpbmcpLCBubyBtYXR0ZXIKPj4+PiB3aGV0aGVyIHRoZSBzdGF0 ZSBjaGFuZ2VkIG9yIG5vdC4gVGhpcyBpc24ndCBuZWVkZWQgYW5kIG1heSBjb25mdXNlCj4+Pj4g dXNlcnMgY29uc2lkZXJpbmcgdGhlIG5hbWUgb2YgdGhlIGNhbGxiYWNrLiBUaGVyZWZvcmUgbGV0 J3MgY2hhbmdlCj4+Pj4gdGhlIGJlaGF2aW9yIGFuZCBjYWxsIHRoaXMgY2FsbGJhY2sgb25seSBp biBjYXNlIG9mIGFuIGFjdHVhbAo+Pj4+IHN0YXRlIGNoYW5nZS4KPj4+Pgo+Pj4+IFRoaXMgcmVx dWlyZXMgY2hhbmdlcyB0byB0aGUgYXQ4MDN4IGFuZCByb2NrY2hpcCBkcml2ZXJzLgo+Pj4+IGF0 ODAzeCBjYW4gYmUgc2ltcGxpZmllZCBzbyB0aGF0IGl0IHJlYWN0cyBvbiBhIHN0YXRlIGNoYW5n ZSB0bwo+Pj4+IFBIWV9OT0xJTksgb25seS4KPj4+PiBUaGUgcm9ja2NoaXAgZHJpdmVyIGNhbiBh bHNvIGJlIG11Y2ggc2ltcGxpZmllZC4gV2Ugc2ltcGx5IHJlLWluaXQKPj4+PiB0aGUgQUZFL0RT UCByZWdpc3RlcnMgd2hlbmV2ZXIgd2UgY2hhbmdlIHRvIFBIWV9SVU5OSU5HIGFuZCBzcGVlZAo+ Pj4+IGlzIDEwME1icHMuIFRoaXMgY2F1c2VzIHZlcnkgc21hbGwgb3ZlcmhlYWQgYmVjYXVzZSB3 ZSBkbyB0aGlzIGV2ZW4KPj4+PiBpZiB0aGUgc3BlZWQgd2FzIDEwME1icHMgYWxyZWFkeS4gQnV0 IHRoaXMgaXMgbmVnbGVjdGFibGUgYW5kCj4+Pj4gSSB0aGluayBqdXN0aWZpZWQgYnkgdGhlIG11 Y2ggc2ltcGxlciBjb2RlLgo+Pj4+Cj4+Pj4gQ2hhbmdlcyBhcmUgY29tcGlsZS10ZXN0ZWQgb25s eS4KPj4+Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IEhlaW5lciBLYWxsd2VpdCA8aGthbGx3ZWl0MUBn bWFpbC5jb20+Cj4+Pgo+Pj4gU29tZW9uZSBwbGVhc2UgcmV2aWV3IHRoaXMuCj4+Cj4+IEhpIERh dmlkCj4+Cj4+IFdlIHNob3VsZCBwcm9iYWJseSB3YWl0IGZvciBhIFRlc3RlZC1ieTogZnJvbSBE YW5pZWwgTWFjawo+PiA8em9ucXVlQGdtYWlsLmNvbT4gYW5kIERhdmlkIFd1IDxkYXZpZC53dUBy b2NrLWNoaXBzLmNvbT4sIG9yCj4+IGVxdWl2YWxlbnQuCj4gCj4gV2Ugc2hvdWxkIHByb2JhYmx5 IGFkZCB0aGVtIHRvIHRoZSBsaXN0IG9mIHJlY2lwaWVudHMgaWYgd2Ugd2FudAo+IHRlc3RzIGZy b20gdGhlbSwgd2hpY2ggSSd2ZSBkb25lIG5vdy4KPiAKPiBARGF2aWQ6IHBhdGNoIGluIHF1ZXN0 aW9uIHRoYXQgY2hhbmdlcyB0aGUgUm9ja2NoaXAgZXRoLXBoeSBpcwo+IGh0dHBzOi8vcGF0Y2h3 b3JrLmtlcm5lbC5vcmcvcGF0Y2gvMTA4MzcyMTcvCj4gCj4gU2FkbHkgSSBkb24ndCBoYXZlIG1h dGNoaW5nIGhhcmR3YXJlIHRvIHRlc3QgdGhpcyBteXNlbGYuCgpUaGFua3MgZm9yIGNvbnNpZGVy aW5nIG1lLCBidXQgSSBkb24ndCBoYXZlIGFjY2VzcyB0byB0aGF0IGhhcmR3YXJlCmVpdGhlciBy aWdodCBub3cuCgpUaGUgY2hhbmdlcyBsb29rIHN0cmFpZ2h0IGZvcndhcmQgdG8gbWUgaG93ZXZl ciwgc28ganVzdCBnbyBhaGVhZCBhbgphcHBseSB0aGlzLiBPbmNlIEkgZ2V0IGJhY2sgdG8gdGhh dCBzZXR1cCwgSSdsbCByZXBvcnQgaW4gY2FzZSBvZiBhCnJlZ3Jlc3Npb24uCgoKVGhhbmtzLApE YWluZWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK