From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 03/28] [v2] infiniband: shut up a maybe-uninitialized warning Date: Tue, 18 Oct 2016 12:18:55 +0200 Message-ID: <9469876.gij7f9Mh1b@wuerfel> References: <20161017220342.1627073-1-arnd@arndb.de> <20161017220557.1688282-3-arnd@arndb.de> <33302790-0a4c-e2b3-868d-3e7dadbd3c07@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <33302790-0a4c-e2b3-868d-3e7dadbd3c07-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Haggai Eran Cc: Doug Ledford , Linus Torvalds , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sean Hefty , Hal Rosenstock , Matan Barak , Leon Romanovsky , Sagi Grimberg , Bart Van Assche , Alex Vesker , Guy Shapiro , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tuesday, October 18, 2016 9:47:31 AM CEST Haggai Eran wrote: > On 10/18/2016 1:05 AM, Arnd Bergmann wrote: > > @@ -1309,7 +1311,7 @@ static bool validate_net_dev(struct net_device *net_dev, > > static struct net_device *cma_get_net_dev(struct ib_cm_event *ib_event, > > const struct cma_req_info *req) > > { > > - struct sockaddr_storage listen_addr_storage, src_addr_storage; > > + struct sockaddr_storage listen_addr_storage = {}, src_addr_storage = {}; > > Doesn't this still translate to an extra initialization that Doug was > worried about? Thanks for spotting this. I must have screwed up while rebasing the patch at some point, this one change should not be there, the other changes by themselves sufficiently address the warning. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759009AbcJRKTh (ORCPT ); Tue, 18 Oct 2016 06:19:37 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:60687 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758088AbcJRKT3 (ORCPT ); Tue, 18 Oct 2016 06:19:29 -0400 From: Arnd Bergmann To: Haggai Eran Cc: Doug Ledford , Linus Torvalds , linux-kernel@vger.kernel.org, Sean Hefty , Hal Rosenstock , Matan Barak , Leon Romanovsky , Sagi Grimberg , Bart Van Assche , Alex Vesker , Guy Shapiro , linux-rdma@vger.kernel.org Subject: Re: [PATCH 03/28] [v2] infiniband: shut up a maybe-uninitialized warning Date: Tue, 18 Oct 2016 12:18:55 +0200 Message-ID: <9469876.gij7f9Mh1b@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <33302790-0a4c-e2b3-868d-3e7dadbd3c07@mellanox.com> References: <20161017220342.1627073-1-arnd@arndb.de> <20161017220557.1688282-3-arnd@arndb.de> <33302790-0a4c-e2b3-868d-3e7dadbd3c07@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:h9U0d+HVKx2i6ZDTZZ63CASMIbbOTswiNvCakMCP56yxN6cdrxV o9LDJhMSqZw0vJjrfoNiJxX7NkjPt7LbvFDIo1/403jgVp72jeSjLuZcbP7WngCd8bR23rl opCiXm4pXNEiG7J00FPyplCJ4IQr7EP1akqHyM1Y/73Y1i+fwBq1dxI8D1ONdK3awrgqtak dI5n/PAnTk4zSX3vVkFlg== X-UI-Out-Filterresults: notjunk:1;V01:K0:qIF4D6MR7NI=:sRm9kn5UphxWc37+rHw/DT JVPooxejZJ99f1MSqOR0PwoULRKyeWifSsF2yUa9MkWI3p0bbgIUoKse8YUkGlL1k19a9yPOy CzbMCwxn0hL+j4fldTAYv8so2uhKV4jQt3z4w0JacRxYxuXdB3MX2/kYUVuehdmfrAF+mi0f3 ce4LCr/Xf0cmL1olei6oy5K3Fl+aI54JvVA7EHwp+f8TCFiaKSPm2JwqMInCTdpLYCVbY85Qt yygQq3fQQ4LFEEPXh109n+dCLRMBjSH1BHHueuKs8himgSnQzgFemHUvHfX2Uw28ptVAf9Q+U bKp9eH7tueJaSlUrzqTZf2qrKm1XuJiZ4iDUqeNLgD58qyxXAD6jlzW2sdDYA82MDJHL63J84 1cgT+G4Jj7sqMu54f5dzXwfXuqlHrbtwXYSiB+LwexHzr8M3RLycxs5J5RBqOVLea3A5BVJsa Dq8qDtciXSulDZX0NCib+u7maBVppUfx2d78aXSH75dEsSKAZhNhRwpCHw6ACIHoOQHcKsH4Q mpYUjeoevV1+1mVUovCzcC6Ir4Q8Ua9GyXIFfoch+1f6lwNXlcUJwgLSBIV1VkIQEWgV5tKnd ZDsvgS8d/ITj+I2tGp8NdOoL569YJIoikfL7C2QkHPIgiCl1G6ryBbmmMeJj99zWEm0YlSWTk MHKyvkEfwHemlmcg6+sEx/+50wsWTx+qPm82zPd2sC58tV+W08+ncrGl3DLtvUQVIz5TNpKUb TTEhUDgAG6XeQujP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 18, 2016 9:47:31 AM CEST Haggai Eran wrote: > On 10/18/2016 1:05 AM, Arnd Bergmann wrote: > > @@ -1309,7 +1311,7 @@ static bool validate_net_dev(struct net_device *net_dev, > > static struct net_device *cma_get_net_dev(struct ib_cm_event *ib_event, > > const struct cma_req_info *req) > > { > > - struct sockaddr_storage listen_addr_storage, src_addr_storage; > > + struct sockaddr_storage listen_addr_storage = {}, src_addr_storage = {}; > > Doesn't this still translate to an extra initialization that Doug was > worried about? Thanks for spotting this. I must have screwed up while rebasing the patch at some point, this one change should not be there, the other changes by themselves sufficiently address the warning. Arnd