From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: zynq: Add support for SYZYGY Hub board
Date: Wed, 27 Sep 2017 07:50:05 +0200 [thread overview]
Message-ID: <946c9fb2-bca8-9b4b-846d-e588b6c1bc0e@monstr.eu> (raw)
In-Reply-To: <1505239539-1206-1-git-send-email-tom.mcleod@opalkelly.com>
On 12.9.2017 20:05, Tom McLeod wrote:
> Add the Zynq-based SYZYGY Hub board from Opal Kelly. The board
> contains a Xilinx Zynq xc7z012s SoC, 1GB DDR3 RAM, and supports
> booting from SD.
>
> Signed-off-by: Tom McLeod <tom.mcleod@opalkelly.com>
> ---
> arch/arm/dts/Makefile | 1 +
> arch/arm/dts/zynq-syzygy-hub.dts | 72 ++
> board/opalkelly/zynq/MAINTAINERS | 6 +
> board/opalkelly/zynq/Makefile | 9 +
> board/opalkelly/zynq/board.c | 1 +
> .../opalkelly/zynq/zynq-syzygy-hub/ps7_init_gpl.c | 1078 ++++++++++++++++++++
> .../opalkelly/zynq/zynq-syzygy-hub/ps7_init_gpl.h | 103 ++
Can you please look at board/topic/zynq/* and try to minimalize these
ps7_init* files?
At least remove functions related to silicon v1/v2?
+ if (si_ver == PCW_SILICON_VERSION_1) {
+ ps7_mio_init_data = ps7_mio_init_data_1_0;
+ ps7_pll_init_data = ps7_pll_init_data_1_0;
+ ps7_clock_init_data = ps7_clock_init_data_1_0;
+ ps7_ddr_init_data = ps7_ddr_init_data_1_0;
+ ps7_peripherals_init_data = ps7_peripherals_init_data_1_0;
+ } else if (si_ver == PCW_SILICON_VERSION_2) {
+ ps7_mio_init_data = ps7_mio_init_data_2_0;
+ ps7_pll_init_data = ps7_pll_init_data_2_0;
+ ps7_clock_init_data = ps7_clock_init_data_2_0;
+ ps7_ddr_init_data = ps7_ddr_init_data_2_0;
+ ps7_peripherals_init_data = ps7_peripherals_init_data_2_0;
+ } else {
> configs/syzygy_hub_defconfig | 57 ++
> include/configs/syzygy_hub.h | 72 ++
> 9 files changed, 1399 insertions(+)
> create mode 100644 arch/arm/dts/zynq-syzygy-hub.dts
> create mode 100644 board/opalkelly/zynq/MAINTAINERS
> create mode 100644 board/opalkelly/zynq/Makefile
> create mode 100644 board/opalkelly/zynq/board.c
> create mode 100644 board/opalkelly/zynq/zynq-syzygy-hub/ps7_init_gpl.c
> create mode 100644 board/opalkelly/zynq/zynq-syzygy-hub/ps7_init_gpl.h
> create mode 100644 configs/syzygy_hub_defconfig
> create mode 100644 include/configs/syzygy_hub.h
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 1d6cee2..c15d94f 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -126,6 +126,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += zynq-zc702.dtb \
> zynq-zc706.dtb \
> zynq-zed.dtb \
> zynq-zybo.dtb \
> + zynq-syzygy-hub.dtb \
as I see we should sort it :-)
> zynq-microzed.dtb \
> zynq-picozed.dtb \
> zynq-topic-miami.dtb \
> diff --git a/arch/arm/dts/zynq-syzygy-hub.dts b/arch/arm/dts/zynq-syzygy-hub.dts
> new file mode 100644
> index 0000000..c98ef01
> --- /dev/null
> +++ b/arch/arm/dts/zynq-syzygy-hub.dts
> @@ -0,0 +1,72 @@
> +/*
> + * SYZYGY Hub DTS
> + *
> + * Copyright (C) 2011 - 2015 Xilinx
> + * Copyright (C) 2017 Opal Kelly Inc.
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */
> +/dts-v1/;
> +/include/ "zynq-7000.dtsi"
> +
> +/ {
> + model = "SYZYGY Hub";
> + compatible = "xlnx,zynq-7000";
compatible string should contain also information about your board.
It means you should record your prefix in Linux kernel first and then
use it here.
compatible = "opalkelly,syzygy-hub-vXX", "opalkelly,syzygy-hub",
"xlnx,zynq-7000";
The rest is good.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170927/bcd89f7c/attachment.sig>
next prev parent reply other threads:[~2017-09-27 5:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 18:05 [U-Boot] [PATCH] ARM: zynq: Add support for SYZYGY Hub board Tom McLeod
2017-09-25 20:24 ` Tom McLeod
2017-09-27 5:50 ` Michal Simek [this message]
2017-09-27 16:33 ` Tom McLeod
2017-09-28 0:53 ` [U-Boot] [PATCH v2] " Tom McLeod
2017-10-10 5:45 ` Michal Simek
2017-11-02 16:42 ` Tom McLeod
2017-11-06 12:21 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=946c9fb2-bca8-9b4b-846d-e588b6c1bc0e@monstr.eu \
--to=monstr@monstr.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.