All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_sdei: Put the SDEI table after using it
Date: Mon, 18 May 2020 19:59:19 +0100	[thread overview]
Message-ID: <946c9fe8-b32c-2926-911c-886169d1f842@arm.com> (raw)
In-Reply-To: <1589021566-46373-1-git-send-email-guohanjun@huawei.com>

Hi Hanjun,

On 09/05/2020 11:52, Hanjun Guo wrote:
> The acpi_get_table() should be coupled with acpi_put_table() if
> the mapped table is not used for runtime after the initialization
> to release the table mapping, put the SDEI table after using it.

I thought this didn't really matter once ACPI had switched to its global mapping of the
tables...


> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index 334c8be..5c42757 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -1113,6 +1113,7 @@ static bool __init sdei_present_acpi(void)
>  	if (ACPI_FAILURE(status))
>  		return false;
>  
> +	acpi_put_table(sdei_table_header);
>  	pdev = platform_device_register_simple(sdei_driver.driver.name, 0, NULL,
>  					       0);
>  	if (IS_ERR(pdev))
> 


This conflicts with Sudeep's patch that moved all this code. I'll rebase and repost it.


Thanks!

James


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-18 18:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 10:52 [PATCH] firmware: arm_sdei: Put the SDEI table after using it Hanjun Guo
2020-05-18 18:59 ` James Morse [this message]
2020-05-19  1:53   ` Hanjun Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=946c9fe8-b32c-2926-911c-886169d1f842@arm.com \
    --to=james.morse@arm.com \
    --cc=guohanjun@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.