From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37931C54E94 for ; Tue, 24 Jan 2023 20:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229452AbjAXUzd (ORCPT ); Tue, 24 Jan 2023 15:55:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234433AbjAXUzc (ORCPT ); Tue, 24 Jan 2023 15:55:32 -0500 Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6720593EC for ; Tue, 24 Jan 2023 12:55:25 -0800 (PST) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C51E581F59; Tue, 24 Jan 2023 21:55:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1674593724; bh=1C5ObJ1CCeRkMXuRMUxJFeHDmh5wJ/LWIMtalUq8giQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qQPu4T7Sz7b69ghhkwBYwGO1AdHUeWXbivIddBYnQLOTjJDJCnJ2Jla5GJs3Gg9oP AAdATaZzWpbW0x5omCrKK+yFdQ1fc8cvE9rwxvq9S7CxH2lutmJzznJDeIIyZZIVV9 xaNlDXoMpBE10K8Oz/tLvoy1SmDrmUNk/9M+px1XzbyDLytkdCHrzY/gZh6VZka8G0 49O2Q+mUcRIWXof/unajgIa+JepUmALrb7FmZFaPlm6Ci2BFqD8fSzXRNVXKO8hAht tM/d0ddVB9q9dDZamAxblIfoEGN7ZJKuQBYSuc3JGBQkeKfoinZax1H/Vsq3vkymYR EhrLPuTx1SUtA== Message-ID: <9475963f-233a-d976-f337-923dfc2066be@denx.de> Date: Tue, 24 Jan 2023 21:55:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RESEND PATCH v11 09/18] drm: exynos: dsi: Add atomic check Content-Language: en-US To: Jagan Teki , Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula References: <20230123151212.269082-1-jagan@amarulasolutions.com> <20230123151212.269082-10-jagan@amarulasolutions.com> From: Marek Vasut In-Reply-To: <20230123151212.269082-10-jagan@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 1/23/23 16:12, Jagan Teki wrote: > Look like an explicit fixing up of mode_flags is required for DSIM IP > present in i.MX8M Mini/Nano SoCs. > > At least the LCDIF + DSIM needs active low sync polarities in order > to correlate the correct sync flags of the surrounding components in > the chain to make sure the whole pipeline can work properly. > > On the other hand the i.MX 8M Mini Applications Processor Reference Manual, > Rev. 3, 11/2020 says. > "13.6.3.5.2 RGB interface > Vsync, Hsync, and VDEN are active high signals." > > i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 > 3.6.3.5.2 RGB interface > i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 > 13.6.2.7.2 RGB interface > both claim "Vsync, Hsync, and VDEN are active high signals.", the > LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. > > No clear evidence about whether it can be documentation issues or > something, so added proper comments on the code. > > Comments are suggested by Marek Vasut. > > Reviewed-by: Frieder Schrempf > Signed-off-by: Jagan Teki Reviewed-by: Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B33CEC54EED for ; Tue, 24 Jan 2023 20:55:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC45310E245; Tue, 24 Jan 2023 20:55:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64A6E10E70C for ; Tue, 24 Jan 2023 20:55:25 +0000 (UTC) Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C51E581F59; Tue, 24 Jan 2023 21:55:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1674593724; bh=1C5ObJ1CCeRkMXuRMUxJFeHDmh5wJ/LWIMtalUq8giQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qQPu4T7Sz7b69ghhkwBYwGO1AdHUeWXbivIddBYnQLOTjJDJCnJ2Jla5GJs3Gg9oP AAdATaZzWpbW0x5omCrKK+yFdQ1fc8cvE9rwxvq9S7CxH2lutmJzznJDeIIyZZIVV9 xaNlDXoMpBE10K8Oz/tLvoy1SmDrmUNk/9M+px1XzbyDLytkdCHrzY/gZh6VZka8G0 49O2Q+mUcRIWXof/unajgIa+JepUmALrb7FmZFaPlm6Ci2BFqD8fSzXRNVXKO8hAht tM/d0ddVB9q9dDZamAxblIfoEGN7ZJKuQBYSuc3JGBQkeKfoinZax1H/Vsq3vkymYR EhrLPuTx1SUtA== Message-ID: <9475963f-233a-d976-f337-923dfc2066be@denx.de> Date: Tue, 24 Jan 2023 21:55:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RESEND PATCH v11 09/18] drm: exynos: dsi: Add atomic check Content-Language: en-US To: Jagan Teki , Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai References: <20230123151212.269082-1-jagan@amarulasolutions.com> <20230123151212.269082-10-jagan@amarulasolutions.com> From: Marek Vasut In-Reply-To: <20230123151212.269082-10-jagan@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Matteo Lisi , dri-devel@lists.freedesktop.org, NXP Linux Team , linux-amarula , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 1/23/23 16:12, Jagan Teki wrote: > Look like an explicit fixing up of mode_flags is required for DSIM IP > present in i.MX8M Mini/Nano SoCs. > > At least the LCDIF + DSIM needs active low sync polarities in order > to correlate the correct sync flags of the surrounding components in > the chain to make sure the whole pipeline can work properly. > > On the other hand the i.MX 8M Mini Applications Processor Reference Manual, > Rev. 3, 11/2020 says. > "13.6.3.5.2 RGB interface > Vsync, Hsync, and VDEN are active high signals." > > i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 > 3.6.3.5.2 RGB interface > i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 > 13.6.2.7.2 RGB interface > both claim "Vsync, Hsync, and VDEN are active high signals.", the > LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. > > No clear evidence about whether it can be documentation issues or > something, so added proper comments on the code. > > Comments are suggested by Marek Vasut. > > Reviewed-by: Frieder Schrempf > Signed-off-by: Jagan Teki Reviewed-by: Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1A87C61D97 for ; Tue, 24 Jan 2023 20:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=44/57q5frKbg9cU4wsc+l0byXk74gaVQFqz7AGyv0qU=; b=lTsiFj43Tc2v7R Oz3r0YRUGQTKFKavlYE+0ISZy/1gbkZYOYH/InUbs+yO1m4z6ipTGmrFgELIQoxFUpH666j+gZin4 iNnVbPnRuK0oHxPYAoNMmToXCe6at8DfNjNiPzMDlAC8hMN0zlotr8ZaXJCf4ZrCYFQajt5fSjOWr 1b446CjP/fBNVONxbG2LxtAu1CnAqebQJ3PjzICdCH+/d3PwFkDA4Tg708Wta1zBGwHQPdQSYH42a nMa93vExK9ww/M8A2snf+VRwNzp+9tEOlSgaODV+7xQGGwOVfl3esHYokDJxamKmDolTwnuGV8dVh q9RjiWoZQ/8Roixh86lA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKQKH-005I1R-CV; Tue, 24 Jan 2023 20:55:29 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKQKD-005Hzz-Ev for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 20:55:26 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C51E581F59; Tue, 24 Jan 2023 21:55:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1674593724; bh=1C5ObJ1CCeRkMXuRMUxJFeHDmh5wJ/LWIMtalUq8giQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qQPu4T7Sz7b69ghhkwBYwGO1AdHUeWXbivIddBYnQLOTjJDJCnJ2Jla5GJs3Gg9oP AAdATaZzWpbW0x5omCrKK+yFdQ1fc8cvE9rwxvq9S7CxH2lutmJzznJDeIIyZZIVV9 xaNlDXoMpBE10K8Oz/tLvoy1SmDrmUNk/9M+px1XzbyDLytkdCHrzY/gZh6VZka8G0 49O2Q+mUcRIWXof/unajgIa+JepUmALrb7FmZFaPlm6Ci2BFqD8fSzXRNVXKO8hAht tM/d0ddVB9q9dDZamAxblIfoEGN7ZJKuQBYSuc3JGBQkeKfoinZax1H/Vsq3vkymYR EhrLPuTx1SUtA== Message-ID: <9475963f-233a-d976-f337-923dfc2066be@denx.de> Date: Tue, 24 Jan 2023 21:55:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [RESEND PATCH v11 09/18] drm: exynos: dsi: Add atomic check Content-Language: en-US To: Jagan Teki , Andrzej Hajda , Inki Dae , Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula References: <20230123151212.269082-1-jagan@amarulasolutions.com> <20230123151212.269082-10-jagan@amarulasolutions.com> From: Marek Vasut In-Reply-To: <20230123151212.269082-10-jagan@amarulasolutions.com> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_125525_680644_F3EB5D07 X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/23/23 16:12, Jagan Teki wrote: > Look like an explicit fixing up of mode_flags is required for DSIM IP > present in i.MX8M Mini/Nano SoCs. > > At least the LCDIF + DSIM needs active low sync polarities in order > to correlate the correct sync flags of the surrounding components in > the chain to make sure the whole pipeline can work properly. > > On the other hand the i.MX 8M Mini Applications Processor Reference Manual, > Rev. 3, 11/2020 says. > "13.6.3.5.2 RGB interface > Vsync, Hsync, and VDEN are active high signals." > > i.MX 8M Mini Applications Processor Reference Manual Rev. 3, 11/2020 > 3.6.3.5.2 RGB interface > i.MX 8M Nano Applications Processor Reference Manual Rev. 2, 07/2022 > 13.6.2.7.2 RGB interface > both claim "Vsync, Hsync, and VDEN are active high signals.", the > LCDIF must generate inverted HS/VS/DE signals, i.e. active LOW. > > No clear evidence about whether it can be documentation issues or > something, so added proper comments on the code. > > Comments are suggested by Marek Vasut. > > Reviewed-by: Frieder Schrempf > Signed-off-by: Jagan Teki Reviewed-by: Marek Vasut _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel