From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39FF1C10F0E for ; Fri, 12 Apr 2019 11:47:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 009492171F for ; Fri, 12 Apr 2019 11:47:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="NBmZ14Mz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbfDLLr0 (ORCPT ); Fri, 12 Apr 2019 07:47:26 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:39734 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726697AbfDLLr0 (ORCPT ); Fri, 12 Apr 2019 07:47:26 -0400 Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 948D1549; Fri, 12 Apr 2019 13:47:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1555069644; bh=HLy8xDtxcC2IY2D7MhaZlOhfFS0P1zFM/tCJliCqrfk=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NBmZ14MzmgSr/Gwygc6qD2Mz1KqI4a9xkUs8tSjiN54R6IAyKwLE+Sg49wSCRBe+e iipcR5NmLj2EFxkiLNLE3uEnWxKTQPWD9myHCH4/AVzyQN9yBCd4ZURzgj403rV1Bi HJ4W72q8d8JkaS9lwanbGvZsJI2RgqoClmeG7XF4= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support To: Biju Das , David Airlie , Daniel Vetter Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro References: <1554993271-29523-1-git-send-email-biju.das@bp.renesas.com> <1554993271-29523-4-git-send-email-biju.das@bp.renesas.com> From: Kieran Bingham Organization: Ideas on Board Message-ID: <9476e97f-380a-7285-b169-72085dfe0eca@ideasonboard.com> Date: Fri, 12 Apr 2019 12:47:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1554993271-29523-4-git-send-email-biju.das@bp.renesas.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Biju, On 11/04/2019 15:34, Biju Das wrote: > Add support for the R8A774A1 DU (which is very similar to the R8A7796 DU); > it has one RGB output, one LVDS output and one HDMI output. > > Signed-off-by: Biju Das I see Figure 35.1b across the two datasheets does show some differences between these two parts, but the layout defined by the rcar_du_r8a7796_info structure is compatible based on the current state of the driver... However, if support for the TCON/CMM is added to the DU driver - then I think this will need to be separated. I have seen patches this month which are trying to upstream a CMM implementation. With that in mind - perhaps it would be worth creating a new structure for this part? Otherwise the CMM would end up being enabled when it doesn't exist and could cause problems. -- Regards Kieran > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 75ab17a..f7a5314 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[] = { > { .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info }, > { .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info }, > { .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info }, > + { .compatible = "renesas,du-r8a774a1", .data = &rcar_du_r8a7796_info }, > { .compatible = "renesas,du-r8a774c0", .data = &rcar_du_r8a774c0_info }, > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info }, > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info }, > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Bingham Subject: Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support Date: Fri, 12 Apr 2019 12:47:21 +0100 Message-ID: <9476e97f-380a-7285-b169-72085dfe0eca@ideasonboard.com> References: <1554993271-29523-1-git-send-email-biju.das@bp.renesas.com> <1554993271-29523-4-git-send-email-biju.das@bp.renesas.com> Reply-To: kieran.bingham+renesas@ideasonboard.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56E498996F for ; Fri, 12 Apr 2019 11:47:26 +0000 (UTC) In-Reply-To: <1554993271-29523-4-git-send-email-biju.das@bp.renesas.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Biju Das , David Airlie , Daniel Vetter Cc: Fabrizio Castro , Chris Paterson , Geert Uytterhoeven , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Simon Horman , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org SGkgQmlqdSwKCk9uIDExLzA0LzIwMTkgMTU6MzQsIEJpanUgRGFzIHdyb3RlOgo+IEFkZCBzdXBw b3J0IGZvciB0aGUgUjhBNzc0QTEgRFUgKHdoaWNoIGlzIHZlcnkgc2ltaWxhciB0byB0aGUgUjhB Nzc5NiBEVSk7Cj4gaXQgaGFzIG9uZSBSR0Igb3V0cHV0LCBvbmUgTFZEUyBvdXRwdXQgYW5kIG9u ZSBIRE1JIG91dHB1dC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBCaWp1IERhcyA8YmlqdS5kYXNAYnAu cmVuZXNhcy5jb20+CgpJIHNlZSBGaWd1cmUgMzUuMWIgYWNyb3NzIHRoZSB0d28gZGF0YXNoZWV0 cyBkb2VzIHNob3cgc29tZSBkaWZmZXJlbmNlcwpiZXR3ZWVuIHRoZXNlIHR3byBwYXJ0cywgYnV0 IHRoZSBsYXlvdXQgZGVmaW5lZCBieSB0aGUKcmNhcl9kdV9yOGE3Nzk2X2luZm8gc3RydWN0dXJl IGlzIGNvbXBhdGlibGUgYmFzZWQgb24gdGhlIGN1cnJlbnQgc3RhdGUKb2YgdGhlIGRyaXZlci4u LgoKSG93ZXZlciwgaWYgc3VwcG9ydCBmb3IgdGhlIFRDT04vQ01NIGlzIGFkZGVkIHRvIHRoZSBE VSBkcml2ZXIgLSB0aGVuIEkKdGhpbmsgdGhpcyB3aWxsIG5lZWQgdG8gYmUgc2VwYXJhdGVkLgoK SSBoYXZlIHNlZW4gcGF0Y2hlcyB0aGlzIG1vbnRoIHdoaWNoIGFyZSB0cnlpbmcgdG8gdXBzdHJl YW0gYSBDTU0KaW1wbGVtZW50YXRpb24uCgpXaXRoIHRoYXQgaW4gbWluZCAtIHBlcmhhcHMgaXQg d291bGQgYmUgd29ydGggY3JlYXRpbmcgYSBuZXcgc3RydWN0dXJlCmZvciB0aGlzIHBhcnQ/CgpP dGhlcndpc2UgdGhlIENNTSB3b3VsZCBlbmQgdXAgYmVpbmcgZW5hYmxlZCB3aGVuIGl0IGRvZXNu J3QgZXhpc3QgYW5kCmNvdWxkIGNhdXNlIHByb2JsZW1zLgoKLS0KUmVnYXJkcwoKS2llcmFuCgoK PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyB8IDEgKwo+ICAx IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfZHJ2LmMKPiBpbmRleCA3NWFiMTdhLi5mN2E1MzE0IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X2Rydi5jCj4gQEAgLTM4Niw2ICszODYsNyBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IG9mX2RldmljZV9pZCByY2FyX2R1X29mX3RhYmxlW10gPSB7Cj4gIAl7IC5jb21wYXRp YmxlID0gInJlbmVzYXMsZHUtcjhhNzc0NCIsIC5kYXRhID0gJnJ6ZzFfZHVfcjhhNzc0M19pbmZv IH0sCj4gIAl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMsZHUtcjhhNzc0NSIsIC5kYXRhID0gJnJ6 ZzFfZHVfcjhhNzc0NV9pbmZvIH0sCj4gIAl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMsZHUtcjhh Nzc0NzAiLCAuZGF0YSA9ICZyemcxX2R1X3I4YTc3NDcwX2luZm8gfSwKPiArCXsgLmNvbXBhdGli bGUgPSAicmVuZXNhcyxkdS1yOGE3NzRhMSIsIC5kYXRhID0gJnJjYXJfZHVfcjhhNzc5Nl9pbmZv IH0sCj4gIAl7IC5jb21wYXRpYmxlID0gInJlbmVzYXMsZHUtcjhhNzc0YzAiLCAuZGF0YSA9ICZy Y2FyX2R1X3I4YTc3NGMwX2luZm8gfSwKPiAgCXsgLmNvbXBhdGlibGUgPSAicmVuZXNhcyxkdS1y OGE3Nzc5IiwgLmRhdGEgPSAmcmNhcl9kdV9yOGE3Nzc5X2luZm8gfSwKPiAgCXsgLmNvbXBhdGli bGUgPSAicmVuZXNhcyxkdS1yOGE3NzkwIiwgLmRhdGEgPSAmcmNhcl9kdV9yOGE3NzkwX2luZm8g fSwKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==