From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes Date: Wed, 21 Nov 2018 00:18:51 +0100 Message-ID: <94869436-7841-537a-4760-8f117b06200f@gmail.com> References: <20181106204647.18051-1-marek.vasut+renesas@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Geert Uytterhoeven Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Takeshi Kihara , Geert Uytterhoeven , Wolfram Sang , Yoshihiro Shimoda , Liam Girdwood , Linux-Renesas , Mark Brown , Simon Horman , Linux ARM , Marek Vasut List-Id: devicetree@vger.kernel.org On 11/20/2018 11:16 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Tue, Nov 6, 2018 at 9:46 PM Marek Vasut wrote: >> From: Takeshi Kihara >> >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC >> and enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board >> using the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara >> Signed-off-by: Marek Vasut > >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> @@ -129,6 +129,15 @@ >> }; >> }; >> >> + reg_1p8v: regulator0 { >> + compatible = "regulator-fixed"; >> + regulator-name = "fixed-1.8V"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> reg_3p3v: regulator1 { >> compatible = "regulator-fixed"; >> regulator-name = "fixed-3.3V"; >> @@ -180,6 +189,54 @@ >> #clock-cells = <0>; >> clock-frequency = <74250000>; >> }; >> + >> + vcc_sdhi0: regulator-vcc-sdhi0 { >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "SDHI0 Vcc"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + >> + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + }; >> + >> + vccq_sdhi0: regulator-vccq-sdhi0 { >> + compatible = "regulator-gpio"; >> + >> + regulator-name = "SDHI0 VccQ"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <3300000>; >> + >> + gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>; >> + gpios-states = <1>; >> + states = <3300000 1 >> + 1800000 0>; > > I know this is how it's done in the example in > Documentation/devicetree/bindings/regulator/gpio-regulator.txt, > but usually brackets are used to group tuples, like: > > states = <3300000 1>, <1800000 0>; > > Perhaps the example should be changed? Well, looking through the DTS, I don't see anyone using tuples for the GPIO regulator states. Then again, it could be updated. +CC Mark and Liam, let's see what their opinion on changing that is. -- Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com ([209.85.221.65]:40487 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbeKUKFG (ORCPT ); Wed, 21 Nov 2018 05:05:06 -0500 Subject: Re: [PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes To: Geert Uytterhoeven Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Takeshi Kihara , Marek Vasut , Geert Uytterhoeven , Simon Horman , Wolfram Sang , Yoshihiro Shimoda , Linux-Renesas , Linux ARM , Mark Brown , Liam Girdwood References: <20181106204647.18051-1-marek.vasut+renesas@gmail.com> From: Marek Vasut Message-ID: <94869436-7841-537a-4760-8f117b06200f@gmail.com> Date: Wed, 21 Nov 2018 00:18:51 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On 11/20/2018 11:16 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Tue, Nov 6, 2018 at 9:46 PM Marek Vasut wrote: >> From: Takeshi Kihara >> >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC >> and enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board >> using the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara >> Signed-off-by: Marek Vasut > >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> @@ -129,6 +129,15 @@ >> }; >> }; >> >> + reg_1p8v: regulator0 { >> + compatible = "regulator-fixed"; >> + regulator-name = "fixed-1.8V"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> reg_3p3v: regulator1 { >> compatible = "regulator-fixed"; >> regulator-name = "fixed-3.3V"; >> @@ -180,6 +189,54 @@ >> #clock-cells = <0>; >> clock-frequency = <74250000>; >> }; >> + >> + vcc_sdhi0: regulator-vcc-sdhi0 { >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "SDHI0 Vcc"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + >> + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + }; >> + >> + vccq_sdhi0: regulator-vccq-sdhi0 { >> + compatible = "regulator-gpio"; >> + >> + regulator-name = "SDHI0 VccQ"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <3300000>; >> + >> + gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>; >> + gpios-states = <1>; >> + states = <3300000 1 >> + 1800000 0>; > > I know this is how it's done in the example in > Documentation/devicetree/bindings/regulator/gpio-regulator.txt, > but usually brackets are used to group tuples, like: > > states = <3300000 1>, <1800000 0>; > > Perhaps the example should be changed? Well, looking through the DTS, I don't see anyone using tuples for the GPIO regulator states. Then again, it could be updated. +CC Mark and Liam, let's see what their opinion on changing that is. -- Best regards, Marek Vasut From mboxrd@z Thu Jan 1 00:00:00 1970 From: marek.vasut@gmail.com (Marek Vasut) Date: Wed, 21 Nov 2018 00:18:51 +0100 Subject: [PATCH V3] arm64: dts: r8a77990: ebisu: Add and enable SDHI device nodes In-Reply-To: References: <20181106204647.18051-1-marek.vasut+renesas@gmail.com> Message-ID: <94869436-7841-537a-4760-8f117b06200f@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/20/2018 11:16 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Tue, Nov 6, 2018 at 9:46 PM Marek Vasut wrote: >> From: Takeshi Kihara >> >> This patch adds SDHI{0,1,3} device nodes for the r8a77990 SoC >> and enables SD card slot connected to SDHI0, micro SD card slot >> connected to SDHI1 and eMMC connected to SDHI3 on the Ebisu board >> using the R8A77990 SoC. >> >> Signed-off-by: Takeshi Kihara >> Signed-off-by: Marek Vasut > >> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts >> @@ -129,6 +129,15 @@ >> }; >> }; >> >> + reg_1p8v: regulator0 { >> + compatible = "regulator-fixed"; >> + regulator-name = "fixed-1.8V"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + regulator-boot-on; >> + regulator-always-on; >> + }; >> + >> reg_3p3v: regulator1 { >> compatible = "regulator-fixed"; >> regulator-name = "fixed-3.3V"; >> @@ -180,6 +189,54 @@ >> #clock-cells = <0>; >> clock-frequency = <74250000>; >> }; >> + >> + vcc_sdhi0: regulator-vcc-sdhi0 { >> + compatible = "regulator-fixed"; >> + >> + regulator-name = "SDHI0 Vcc"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + >> + gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> + }; >> + >> + vccq_sdhi0: regulator-vccq-sdhi0 { >> + compatible = "regulator-gpio"; >> + >> + regulator-name = "SDHI0 VccQ"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <3300000>; >> + >> + gpios = <&gpio5 18 GPIO_ACTIVE_HIGH>; >> + gpios-states = <1>; >> + states = <3300000 1 >> + 1800000 0>; > > I know this is how it's done in the example in > Documentation/devicetree/bindings/regulator/gpio-regulator.txt, > but usually brackets are used to group tuples, like: > > states = <3300000 1>, <1800000 0>; > > Perhaps the example should be changed? Well, looking through the DTS, I don't see anyone using tuples for the GPIO regulator states. Then again, it could be updated. +CC Mark and Liam, let's see what their opinion on changing that is. -- Best regards, Marek Vasut