All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hovold <johan@kernel.org>
Cc: Lars Poeschel <poeschel@lemonage.de>,
	devicetree <devicetree@vger.kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:NFC SUBSYSTEM" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3 3/5] nfc: pn533: add UART phy driver
Date: Sun, 28 Oct 2018 14:46:24 +0100	[thread overview]
Message-ID: <9494A12C-C53A-4F6E-B6F3-BABB09867677@holtmann.org> (raw)
In-Reply-To: <20181028102725.GL27852@localhost>

Hi Johan,

>> This adds the UART phy interface for the pn533 driver.
>> The pn533 driver can be used through UART interface this way.
>> It is implemented as a serdev device.
> 
> Just a few drive-by comments below.
> 
>> +// SPDX-License-Identifier: GPL-2.0
> 
> This should match MODULE_LICENSE below which currently says v2 *or
> later*.
> 
>> +/*
>> + * Driver for NXP PN532 NFC Chip - UART transport layer
>> + *
>> + * Copyright (C) 2018 Lemonage Software GmbH
>> + * Author: Lars Pöschel <poeschel@lemonage.de>
>> + * All rights reserved.
>> + */
> 
>> +#define VERSION "0.1"
> 
> We don't version kernel drivers individually, so please drop this here
> and below.

if we don’t then maybe send patches to remove MODULE_VERSION first. Otherwise this is totally fine to do.

There are currently 670 usages of MODULE_VERSION and I have not heard anybody looking at removing this.

Regards

Marcel


  reply	other threads:[~2018-10-28 13:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 13:29 [PATCH v3 1/5] nfc: pn533: i2c: "pn532" as dt compatible string Lars Poeschel
2018-10-25 13:29 ` Lars Poeschel
2018-10-25 13:29 ` [PATCH v3 2/5] nfc: pn532_uart: Add NXP PN532 to devicetree docs Lars Poeschel
2018-10-25 13:29   ` Lars Poeschel
2018-10-25 21:54   ` Rob Herring
2018-10-26  7:59     ` Lars Poeschel
2018-10-25 13:29 ` [PATCH v3 3/5] nfc: pn533: add UART phy driver Lars Poeschel
2018-10-25 13:29   ` Lars Poeschel
2018-10-28 10:27   ` Johan Hovold
2018-10-28 13:46     ` Marcel Holtmann [this message]
2018-10-28 14:35       ` Johan Hovold
2018-10-29 10:02     ` Lars Poeschel
2018-10-29 11:07       ` Johan Hovold
2018-10-29 15:51         ` Lars Poeschel
2018-10-29 16:13           ` Johan Hovold
2018-10-25 13:29 ` [PATCH v3 4/5] nfc: pn533: Add autopoll capability Lars Poeschel
2018-10-25 13:29   ` Lars Poeschel
2018-10-25 13:29 ` [PATCH v3 5/5] nfc: pn532_uart: Make use of pn532 autopoll Lars Poeschel
2018-10-25 13:29   ` Lars Poeschel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9494A12C-C53A-4F6E-B6F3-BABB09867677@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=poeschel@lemonage.de \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.