From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/3] eal: add channel for multi-process communication Date: Thu, 25 Jan 2018 11:41:24 +0100 Message-ID: <9497378.gnWiDux1sZ@xps> References: <1512067450-59203-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-1-git-send-email-jianfeng.tan@intel.com> <1516853783-108023-2-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, anatoly.burakov@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com To: Jianfeng Tan Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 2730D1B016 for ; Thu, 25 Jan 2018 11:42:11 +0100 (CET) In-Reply-To: <1516853783-108023-2-git-send-email-jianfeng.tan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/01/2018 05:16, Jianfeng Tan: > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > + rte_eal_mp_action_register; > + rte_eal_mp_action_unregister; > + rte_eal_mp_sendmsg; Just a naming comment: I think you can drop "eal" in function names. "rte_mp_" is a good prefix for multi-process management.