Re: [PATCH] f2fs: fix to update new block address correctly for OPU

[Chao Yu <yuchao0@huawei.com>]

Hi Jia,

On 2018/11/26 11:48, Zhujia (Euler) wrote:
> Hi  Chao,
> 
> On 2018/11/26 10:01, Chao Yu wrote:
>> On 2018/11/25 6:17, Jia Zhu wrote:
>>> Previously, we allocated a new block address for OPU mode in direct_IO.
>>>
>>> But the new address couldn't be assigned to @map->m_pblk correctly.
>>>
>>> This patch fix it.
>> Sorry to introduce this bug...
>>
>> It needs to Cc stable kernel mailing list and add 'Fixes' tag line.
> 
> I have checked the stable kernel branch and it hasn't merged the previous patch yet.
> 
> Shall we still need to cc stable kernel mailing list and add 'Fixes' tag line?

Yes, please.

I think it will be useful to track important fixes to troubleshoot user
reported bug in mailing list or bugzilla, in addition, I think it can be
the hint for maintainers of other distribution of linux e.g. redhat, suse..
to backport fixes to their own version of kernel.

Thanks,

> 
> Thanks,
> 
> Jia Zhu
> 
>>> Signed-off-by: Jia Zhu <zhujia13@huawei.com>
>> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>>
>> Thanks,
>>
>>> ---
>>>  fs/f2fs/data.c | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
>>> index 7226300..a3a567a 100644
>>> --- a/fs/f2fs/data.c
>>> +++ b/fs/f2fs/data.c
>>> @@ -1110,8 +1110,10 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map,
>>>  		if (test_opt(sbi, LFS) && flag == F2FS_GET_BLOCK_DIO &&
>>>  							map->m_may_create) {
>>>  			err = __allocate_data_block(&dn, map->m_seg_type);
>>> -			if (!err)
>>> +			if (!err) {
>>> +				blkaddr = dn.data_blkaddr;
>>>  				set_inode_flag(inode, FI_APPEND_WRITE);
>>> +			}
>>>  		}
>>>  	} else {
>>>  		if (create) {
>>>
>>
>> .
>>
> 
> 
> .
>