From: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
To: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@infradead.org>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>
Subject: RE: Question: request tag usage
Date: Fri, 26 Sep 2014 13:52:23 +0000 [thread overview]
Message-ID: <94D0CD8314A33A4D9D801C0FE68B402958C9FC0A@G9W0745.americas.hpqcorp.net> (raw)
In-Reply-To: <542521DB.1020605@suse.de>
> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@suse.de]
> Sent: Friday, September 26, 2014 3:21 AM
> To: Christoph Hellwig
> Cc: Elliott, Robert (Server Storage); SCSI Mailing List; Jens Axboe
> Subject: Re: Question: request tag usage
>
> On 09/26/2014 10:03 AM, Christoph Hellwig wrote:
...
> >
> > I guess for now we'll need to stay with the command pointer address.
> > We can revisit this once the old request layer is gone.
> >
> Too bad. The tags would have provided a really nice concise way
> of identifying the command...
I would still go ahead and print the tag; it's extremely useful for
blk-mq.
How about having scmd_printk do this?
* if tag is -1, print "scmd %p"
* else print "tag %d"
prev parent reply other threads:[~2014-09-26 13:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 6:29 Question: request tag usage Hannes Reinecke
2014-09-26 8:03 ` Christoph Hellwig
2014-09-26 8:20 ` Hannes Reinecke
2014-09-26 10:12 ` James Bottomley
2014-09-26 12:41 ` Hannes Reinecke
2014-09-26 13:52 ` Elliott, Robert (Server Storage) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94D0CD8314A33A4D9D801C0FE68B402958C9FC0A@G9W0745.americas.hpqcorp.net \
--to=elliott@hp.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.