All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
To: Hannes Reinecke <hare@suse.de>,
	James Bottomley <jbottomley@parallels.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH 20/24] sd: Cleanup logging
Date: Fri, 3 Oct 2014 02:23:08 +0000	[thread overview]
Message-ID: <94D0CD8314A33A4D9D801C0FE68B402958CCBEC7@G4W3202.americas.hpqcorp.net> (raw)
In-Reply-To: <1412144580-72880-21-git-send-email-hare@suse.de>



> -----Original Message-----
> From: Hannes Reinecke [mailto:hare@suse.de]
...
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
...
> @@ -3328,9 +3319,19 @@ static void sd_print_sense_hdr(struct scsi_disk *sdkp,
>  			     sshdr->asc, sshdr->ascq);
>  }
> 
> -static void sd_print_result(struct scsi_disk *sdkp, int result)
> +static void sd_print_result(struct scsi_disk *sdkp, const char *msg,
> +			    int result)
>  {
> -	sd_printk(KERN_INFO, sdkp, " ");
> -	scsi_show_result(result);
> +	const char *hb_string = scsi_hostbyte_string(result);
> +	const char *db_string = scsi_driverbyte_string(result);
> +
> +	if (hb_string && db_string)
> +		sd_printk(KERN_INFO, sdkp,
> +			  "%s: Result: hostbyte=%s driverbyte=%s\n",
> +			  msg, hb_string, db_string);
> +	else
> +		sd_printk(KERN_INFO, sdkp,
> +			  "%s: Result: hostbyte=0x%02x driverbyte=0x%02x\n",
> +			  msg, host_byte(result), driver_byte(result));

In a similar construct, patch 19 used || in scsi_print_result
to choose the string path, and printed "invalid" if one
of the strings was NULL.  They should probably match.


---
Rob Elliott    HP Server Storage




  parent reply	other threads:[~2014-10-03  2:25 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-01  6:22 [PATCHv5 00/24] scsi logging update (the boring part) Hannes Reinecke
2014-10-01  6:22 ` [PATCH 01/24] Remove scsi_cmd_print_sense_hdr() Hannes Reinecke
2014-10-01  6:22 ` [PATCH 02/24] sd: Remove scsi_print_sense() in sd_done() Hannes Reinecke
2014-10-01  6:22 ` [PATCH 03/24] aha152x: Debug output update and whitespace cleanup Hannes Reinecke
2014-10-03  0:01   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 04/24] scsi: introduce sdev_prefix_printk() Hannes Reinecke
2014-10-02 18:37   ` Elliott, Robert (Server Storage)
2014-10-03 16:31     ` Ewan Milne
2014-10-06  6:00       ` Hannes Reinecke
2014-10-01  6:22 ` [PATCH 05/24] scsi: Use sdev as argument for sense code printing Hannes Reinecke
2014-10-03  0:32   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 06/24] acornscsi: use scsi_print_command() Hannes Reinecke
2014-10-01  6:22 ` [PATCH 07/24] fas216: Return DID_ERROR for incomplete data transfer Hannes Reinecke
2014-10-01  7:58   ` Christoph Hellwig
2014-10-01  6:22 ` [PATCH 08/24] fas216: Update logging messages Hannes Reinecke
2014-10-03  0:43   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 09/24] 53c700: remove scsi_print_sense() usage Hannes Reinecke
2014-10-01  6:22 ` [PATCH 10/24] scsi: stop decoding if scsi_normalize_sense() fails Hannes Reinecke
2014-10-01  6:22 ` [PATCH 11/24] scsi: do not decode sense extras Hannes Reinecke
2014-10-01  6:22 ` [PATCH 12/24] scsi: use 'bool' as return value for scsi_normalize_sense() Hannes Reinecke
2014-10-03  1:15   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 13/24] scsi: remove scsi_print_status() Hannes Reinecke
2014-10-01  6:22 ` [PATCH 14/24] Implement scsi_opcode_sa_name Hannes Reinecke
2014-10-03  1:26   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 15/24] scsi: merge print_opcode_name() Hannes Reinecke
2014-10-03  1:37   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 16/24] scsi: consolidate opcode lookup in scsi_opcode_sa_name() Hannes Reinecke
2014-10-03  1:44   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 17/24] scsi: remove last argument from print_opcode_name() Hannes Reinecke
2014-10-03  2:02   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 18/24] scsi: Remove scsi_print_command when calling abort Hannes Reinecke
2014-10-03  2:11   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 19/24] scsi: separate out scsi_(host|driver)byte_string() Hannes Reinecke
2014-10-01  6:22 ` [PATCH 20/24] sd: Cleanup logging Hannes Reinecke
2014-10-02 23:20   ` Elliott, Robert (Server Storage)
2014-10-03  2:23   ` Elliott, Robert (Server Storage) [this message]
2014-10-01  6:22 ` [PATCH 21/24] scsi: simplify scsi_log_(send|completion) Hannes Reinecke
2014-10-03  2:32   ` Elliott, Robert (Server Storage)
2014-10-06  6:40     ` Hannes Reinecke
2014-10-01  6:22 ` [PATCH 22/24] scsi: fixup logging messages in scsi_error.c Hannes Reinecke
2014-10-02 19:02   ` Ewan Milne
2014-10-03  2:39   ` Elliott, Robert (Server Storage)
2014-10-01  6:22 ` [PATCH 23/24] scsi: use shost argument in scsi_eh_prt_fail_stats Hannes Reinecke
2014-10-01  6:23 ` [PATCH 24/24] scsi_error: document scsi_try_to_abort_cmd Hannes Reinecke
2014-10-01  7:59   ` Christoph Hellwig
2014-10-03  2:54   ` Elliott, Robert (Server Storage)
2014-10-02 18:53 ` [PATCHv5 00/24] scsi logging update (the boring part) Elliott, Robert (Server Storage)
2014-10-03  7:08   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94D0CD8314A33A4D9D801C0FE68B402958CCBEC7@G4W3202.americas.hpqcorp.net \
    --to=elliott@hp.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.