From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752838AbbCZSr1 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Mar 2015 14:47:27 -0400
Received: from g9t5009.houston.hp.com ([15.240.92.67]:43355 "EHLO
	g9t5009.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752705AbbCZSrZ convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Mar 2015 14:47:25 -0400
From: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
To: Christoph Hellwig <hch@lst.de>, Boaz Harrosh <boaz@plexistor.com>
CC: Ingo Molnar <mingo@kernel.org>,
        "linux-nvdimm@ml01.01.org" <linux-nvdimm@ml01.01.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "Kani, Toshimitsu" <toshi.kani@hp.com>
Subject: RE: [PATCH 2/3] x86: add a is_e820_ram() helper
Thread-Topic: [PATCH 2/3] x86: add a is_e820_ram() helper
Thread-Index: AQHQZ5+WztBOg7NCT0WJB2bbvl5SFZ0ud9yAgAAI+wCAAGjXAIAADvoAgAAgX2A=
Date: Thu, 26 Mar 2015 18:46:07 +0000
Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295A84640D@G9W0745.americas.hpqcorp.net>
References: <1427358764-6126-1-git-send-email-hch@lst.de>
 <1427358764-6126-3-git-send-email-hch@lst.de>
 <20150326090215.GA11520@gmail.com> <20150326093424.GA28217@lst.de>
 <55142A92.4060607@plexistor.com> <20150326164314.GB23958@lst.de>
In-Reply-To: <20150326164314.GB23958@lst.de>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [16.210.48.26]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Christoph Hellwig
> Sent: Thursday, March 26, 2015 11:43 AM
> To: Boaz Harrosh
> Cc: Christoph Hellwig; Ingo Molnar; linux-nvdimm@ml01.01.org; linux-
> fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; x86@kernel.org;
> ross.zwisler@linux.intel.com; axboe@kernel.dk
> Subject: Re: [PATCH 2/3] x86: add a is_e820_ram() helper
> 
> On Thu, Mar 26, 2015 at 05:49:38PM +0200, Boaz Harrosh wrote:
> > > +	memmap=nn[KMG]!ss[KMG]
> > > +			[KNL,X86] Mark specific memory as protected.
> > > +			Region of memory to be used, from ss to ss+nn.
> > > +			The memory region may be marked as e820 type 12 (0xc)
> > > +			and is NVDIMM or ADR memory.
> > > +
> >
> > Do we need to escape "\!" this character on grub command line ? It might
> > help to note that. I did like the original "|" BTW
> 
> No need to escape it on the kvm command line, which is where I tested
> this flag only so far.  If there is a strong argument for "|" I'm happy
> to change it.

I agree with Boaz that ! is a nuisance if loading pmem as a module
with modprobe from bash. 

The ! does work fine in the grub2 command line if the driver is 
built-in.  I added it to /etc/default/grub like this:
    GRUB_CMDLINE_LINUX="<other parameters> memmap=8G!18G"
and grub-mkconfig placed it in /boot/efi/EFI/centos/grub.cfg
with no issues.