From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> To: Matt Fleming <matt@codeblueprint.co.uk>, Ingo Molnar <mingo@kernel.org> Cc: Laszlo Ersek <lersek@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>, "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Taku Izumi <izumi.taku@jp.fujitsu.com>, "Linus Torvalds" <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org> Subject: RE: [PATCH 14/14] x86/efi: Print size in binary units in efi_print_memmap Date: Wed, 3 Feb 2016 15:25:24 +0000 [thread overview] Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295BF72A9F@G4W3202.americas.hpqcorp.net> (raw) In-Reply-To: <20160203112829.GC2597@codeblueprint.co.uk> > -----Original Message----- > From: Matt Fleming [mailto:matt@codeblueprint.co.uk] > Sent: Wednesday, February 3, 2016 5:28 AM > To: Ingo Molnar <mingo@kernel.org> > Cc: Laszlo Ersek <lersek@redhat.com>; H . Peter Anvin <hpa@zytor.com>; > Thomas Gleixner <tglx@linutronix.de>; linux-efi@vger.kernel.org; linux- > kernel@vger.kernel.org; Elliott, Robert (Persistent Memory) > <elliott@hpe.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>; > Ard Biesheuvel <ard.biesheuvel@linaro.org>; Taku Izumi > <izumi.taku@jp.fujitsu.com>; Linus Torvalds <torvalds@linux- > foundation.org>; Andrew Morton <akpm@linux-foundation.org> > Subject: Re: [PATCH 14/14] x86/efi: Print size in binary units in > efi_print_memmap ... > OK, this patch has caused enough headaches. Let's drop it from this > series. > > Robert, Andy, feel free to resubmit it after you've addressed > everyone's concerns and we can discuss it in isolation. We could just delete the size print altogether - better to print nothing than a silently rounded number. The end address already communicates the size - it's just not as readable. The e820 table prints don't bother with a size print. That would also shorten these extremely wide prints to 116 characters (131 if printk time is enabled). [ 0.000000] BIOS-e820: [mem 0x0000001880000000-0x000000207fffffff] reserved vs. [ 0.000000] efi: mem62: [Reserved | | |NV| | | | | |WB|WT|WC|UC] range=[0x0000001880000000-0x000000207fffffff] (32 GiB) --- Robert Elliott, HPE Persistent Memory
WARNING: multiple messages have this Message-ID (diff)
From: "Elliott, Robert (Persistent Memory)" <elliott-ZPxbGqLxI0U@public.gmane.org> To: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>, Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Laszlo Ersek <lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "H . Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Taku Izumi <izumi.taku-+CUm20s59erQFUHtdCDX3A@public.gmane.org>, Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Subject: RE: [PATCH 14/14] x86/efi: Print size in binary units in efi_print_memmap Date: Wed, 3 Feb 2016 15:25:24 +0000 [thread overview] Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295BF72A9F@G4W3202.americas.hpqcorp.net> (raw) In-Reply-To: <20160203112829.GC2597-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> > -----Original Message----- > From: Matt Fleming [mailto:matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org] > Sent: Wednesday, February 3, 2016 5:28 AM > To: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Cc: Laszlo Ersek <lersek-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>; H . Peter Anvin <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>; > Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>; linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux- > kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Elliott, Robert (Persistent Memory) > <elliott-ZPxbGqLxI0U@public.gmane.org>; Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>; > Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>; Taku Izumi > <izumi.taku-+CUm20s59erQFUHtdCDX3A@public.gmane.org>; Linus Torvalds <torvalds@linux- > foundation.org>; Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> > Subject: Re: [PATCH 14/14] x86/efi: Print size in binary units in > efi_print_memmap ... > OK, this patch has caused enough headaches. Let's drop it from this > series. > > Robert, Andy, feel free to resubmit it after you've addressed > everyone's concerns and we can discuss it in isolation. We could just delete the size print altogether - better to print nothing than a silently rounded number. The end address already communicates the size - it's just not as readable. The e820 table prints don't bother with a size print. That would also shorten these extremely wide prints to 116 characters (131 if printk time is enabled). [ 0.000000] BIOS-e820: [mem 0x0000001880000000-0x000000207fffffff] reserved vs. [ 0.000000] efi: mem62: [Reserved | | |NV| | | | | |WB|WT|WC|UC] range=[0x0000001880000000-0x000000207fffffff] (32 GiB) --- Robert Elliott, HPE Persistent Memory
next prev parent reply other threads:[~2016-02-03 15:25 UTC|newest] Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-01 22:06 [GIT PULL 00/14] EFI changes for v4.6 Matt Fleming 2016-02-01 22:06 ` [PATCH 01/14] efi: Expose non-blocking set_variable() wrapper to efivars Matt Fleming 2016-02-03 11:31 ` [tip:efi/core] " tip-bot for Ard Biesheuvel 2016-02-01 22:06 ` [PATCH 02/14] efi: Remove redundant efi_set_variable_nonblocking prototype Matt Fleming 2016-02-01 22:06 ` Matt Fleming 2016-02-03 11:31 ` [tip:efi/core] efi: Remove redundant efi_set_variable_nonblocking () prototype tip-bot for Ard Biesheuvel 2016-02-01 22:06 ` [PATCH 03/14] efi: runtime-wrappers: Add a nonblocking version of QueryVariableInfo Matt Fleming 2016-02-01 22:06 ` Matt Fleming 2016-02-03 11:31 ` [tip:efi/core] efi/runtime-wrappers: Add a nonblocking version of QueryVariableInfo() tip-bot for Ard Biesheuvel 2016-02-01 22:06 ` [PATCH 04/14] efi: Add nonblocking option to efi_query_variable_store() Matt Fleming 2016-02-03 11:32 ` [tip:efi/core] " tip-bot for Ard Biesheuvel 2016-02-01 22:06 ` [PATCH 05/14] efi: runtime-wrappers: Remove out of date comment regarding in_nmi() Matt Fleming 2016-02-03 11:32 ` [tip:efi/core] efi/runtime-wrappers: " tip-bot for Ard Biesheuvel 2016-02-01 22:07 ` [PATCH 06/14] efi: runtime-wrapper: Get rid of the rtc_lock spinlock Matt Fleming 2016-02-01 22:07 ` Matt Fleming 2016-02-03 11:32 ` [tip:efi/core] efi: Runtime-wrapper: " tip-bot for Ard Biesheuvel 2016-02-01 22:07 ` [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled Matt Fleming 2016-02-03 9:43 ` Ingo Molnar 2016-02-03 9:57 ` Ard Biesheuvel 2016-02-03 9:57 ` Ard Biesheuvel 2016-02-03 10:58 ` Ingo Molnar 2016-02-03 11:33 ` Ard Biesheuvel 2016-02-03 12:01 ` Matt Fleming 2016-02-04 13:58 ` [PATCH] efi: runtime-wrappers: run " Ard Biesheuvel 2016-02-08 15:16 ` Matt Fleming 2016-02-08 19:37 ` Andy Lutomirski 2016-02-09 16:52 ` Ard Biesheuvel 2016-02-09 16:52 ` Ard Biesheuvel 2016-02-11 16:03 ` Matt Fleming 2016-02-11 16:04 ` Matt Fleming 2016-02-01 22:07 ` [PATCH 08/14] efivars: Use to_efivar_entry Matt Fleming 2016-02-03 11:33 ` [tip:efi/core] " tip-bot for Geliang Tang 2016-02-01 22:07 ` [PATCH 09/14] x86/efi-bgrt: Don't ignore the BGRT if the 'valid' bit is 0 Matt Fleming 2016-02-03 11:33 ` [tip:efi/core] x86/efi/bgrt: " tip-bot for Môshe van der Sterre 2016-02-01 22:07 ` [PATCH 10/14] efi: Make checkpatch complain less about efi.h GUID additions Matt Fleming 2016-02-01 22:07 ` Matt Fleming 2016-02-03 10:33 ` Ingo Molnar 2016-02-03 10:33 ` Ingo Molnar 2016-02-03 10:44 ` Matt Fleming 2016-02-03 10:50 ` Ingo Molnar 2016-02-03 10:50 ` Ingo Molnar 2016-02-03 11:18 ` Matt Fleming 2016-02-03 11:27 ` Ingo Molnar 2016-02-03 11:27 ` Ingo Molnar 2016-02-03 11:09 ` Joe Perches 2016-02-01 22:07 ` [PATCH 11/14] x86/efi: Show actual ending addresses in efi_print_memmap Matt Fleming 2016-02-02 8:49 ` Laszlo Ersek 2016-02-03 11:33 ` [tip:efi/core] " tip-bot for Robert Elliott 2016-02-01 22:07 ` [PATCH 12/14] efi: Add NV memory attribute Matt Fleming 2016-02-02 8:54 ` Laszlo Ersek 2016-02-02 8:54 ` Laszlo Ersek 2016-02-03 11:34 ` [tip:efi/core] " tip-bot for Robert Elliott 2016-02-01 22:07 ` [PATCH 13/14] efi: Add Persistent Memory type name Matt Fleming 2016-02-02 8:56 ` Laszlo Ersek 2016-02-03 11:34 ` [tip:efi/core] " tip-bot for Robert Elliott 2016-02-01 22:07 ` [PATCH 14/14] x86/efi: Print size in binary units in efi_print_memmap Matt Fleming 2016-02-02 9:22 ` Laszlo Ersek 2016-02-03 10:40 ` Ingo Molnar 2016-02-03 11:28 ` Matt Fleming 2016-02-03 12:36 ` Andy Shevchenko 2016-02-03 15:25 ` Elliott, Robert (Persistent Memory) [this message] 2016-02-03 15:25 ` Elliott, Robert (Persistent Memory) 2016-02-09 12:20 ` Ingo Molnar 2016-02-09 12:53 ` Laszlo Ersek 2016-02-09 12:53 ` Laszlo Ersek 2016-02-09 13:14 ` Ingo Molnar 2016-02-09 13:14 ` Ingo Molnar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=94D0CD8314A33A4D9D801C0FE68B40295BF72A9F@G4W3202.americas.hpqcorp.net \ --to=elliott@hpe.com \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=ard.biesheuvel@linaro.org \ --cc=hpa@zytor.com \ --cc=izumi.taku@jp.fujitsu.com \ --cc=lersek@redhat.com \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=matt@codeblueprint.co.uk \ --cc=mingo@kernel.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.