From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Moore, Robert" Subject: RE: [PATCH] acpica: modify a commit error in file drivers/acpi/acpica/nsxfeval.c Date: Mon, 13 Apr 2015 17:42:45 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2BD73F@ORSMSX112.amr.corp.intel.com> References: <1428915907-14302-1-git-send-email-gongzhaogang@inspur.com> <1536129.vQOiq1xQa9@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com ([192.55.52.88]:33147 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbbDMRms (ORCPT ); Mon, 13 Apr 2015 13:42:48 -0400 In-Reply-To: <1536129.vQOiq1xQa9@vostro.rjw.lan> Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" , Zhaogang Gong Cc: "Zheng, Lv" , "Wysocki, Rafael J" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "yanxiaofeng@inspur.com" WWVzLCB0aGlzIGNvbWVzIHVwIGV2ZXJ5IG5vdyBhbmQgdGhlbi4NCg0KImlmZiIgbWVhbnMgImlm IGFuZCBvbmx5IGlmIiBieSBjb252ZW50aW9uLg0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdl LS0tLS0NCj4gRnJvbTogUmFmYWVsIEouIFd5c29ja2kgW21haWx0bzpyandAcmp3eXNvY2tpLm5l dF0NCj4gU2VudDogTW9uZGF5LCBBcHJpbCAxMywgMjAxNSA2OjM4IEFNDQo+IFRvOiBaaGFvZ2Fu ZyBHb25nDQo+IENjOiBNb29yZSwgUm9iZXJ0OyBaaGVuZywgTHY7IFd5c29ja2ksIFJhZmFlbCBK OyBsZW5iQGtlcm5lbC5vcmc7IGxpbnV4LQ0KPiBhY3BpQHZnZXIua2VybmVsLm9yZzsgbGludXgt a2VybmVsQHZnZXIua2VybmVsLm9yZzsgeWFueGlhb2ZlbmdAaW5zcHVyLmNvbQ0KPiBTdWJqZWN0 OiBSZTogW1BBVENIXSBhY3BpY2E6IG1vZGlmeSBhIGNvbW1pdCBlcnJvciBpbiBmaWxlDQo+IGRy aXZlcnMvYWNwaS9hY3BpY2EvbnN4ZmV2YWwuYw0KPiANCj4gT24gTW9uZGF5LCBBcHJpbCAxMywg MjAxNSAwNTowNTowNyBQTSBaaGFvZ2FuZyBHb25nIHdyb3RlOg0KPiA+IENoYW5nZSAiaWZmIiBp biBmdW5jdGlvbiBhY3BpX2V2YWx1YXRlX29iamVjdCgpIHRvICJpZiIuDQo+ID4NCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBaaGFvZ2FuZyBHb25nIDxnb25nemhhb2dhbmdAaW5zcHVyLmNvbT4NCj4gPiAt LS0NCj4gPiAgZHJpdmVycy9hY3BpL2FjcGljYS9uc3hmZXZhbC5jIHwgMiArLQ0KPiA+ICAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gPg0KPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2FjcGkvYWNwaWNhL25zeGZldmFsLmMNCj4gPiBiL2RyaXZlcnMvYWNw aS9hY3BpY2EvbnN4ZmV2YWwuYyBpbmRleCBiNjAzMGEyLi45NTcxNDI5IDEwMDY0NA0KPiA+IC0t LSBhL2RyaXZlcnMvYWNwaS9hY3BpY2EvbnN4ZmV2YWwuYw0KPiA+ICsrKyBiL2RyaXZlcnMvYWNw aS9hY3BpY2EvbnN4ZmV2YWwuYw0KPiA+IEBAIC0yMTQsNyArMjE0LDcgQEAgYWNwaV9ldmFsdWF0 ZV9vYmplY3QoYWNwaV9oYW5kbGUgaGFuZGxlLA0KPiA+ICAJCWluZm8tPnByZWZpeF9ub2RlID0g TlVMTDsNCj4gPiAgCX0gZWxzZSBpZiAoIWhhbmRsZSkgew0KPiA+ICAJCS8qDQo+ID4gLQkJICog QSBoYW5kbGUgaXMgb3B0aW9uYWwgaWZmIGEgZnVsbHkgcXVhbGlmaWVkIHBhdGhuYW1lIGlzDQo+ IHNwZWNpZmllZC4NCj4gPiArCQkgKiBBIGhhbmRsZSBpcyBvcHRpb25hbCBpZiBhIGZ1bGx5IHF1 YWxpZmllZCBwYXRobmFtZSBpcw0KPiBzcGVjaWZpZWQuDQo+IA0KPiBUaGlzIGlzIG5vdCBhIG1p c3Rha2UuDQo+IA0KPiA+ICAJCSAqIFNpbmNlIHdlJ3ZlIGFscmVhZHkgaGFuZGxlZCBmdWxseSBx dWFsaWZpZWQgbmFtZXMgYWJvdmUsDQo+IHRoaXMgaXMNCj4gPiAgCQkgKiBhbiBlcnJvci4NCj4g PiAgCQkgKi8NCj4gPg0KPiANCj4gLS0NCj4gSSBzcGVhayBvbmx5IGZvciBteXNlbGYuDQo+IFJh ZmFlbCBKLiBXeXNvY2tpLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlci4NCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932343AbbDMRmv (ORCPT ); Mon, 13 Apr 2015 13:42:51 -0400 Received: from mga01.intel.com ([192.55.52.88]:33147 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbbDMRms (ORCPT ); Mon, 13 Apr 2015 13:42:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,571,1422950400"; d="scan'208";a="480352415" From: "Moore, Robert" To: "Rafael J. Wysocki" , Zhaogang Gong CC: "Zheng, Lv" , "Wysocki, Rafael J" , "lenb@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "yanxiaofeng@inspur.com" Subject: RE: [PATCH] acpica: modify a commit error in file drivers/acpi/acpica/nsxfeval.c Thread-Topic: [PATCH] acpica: modify a commit error in file drivers/acpi/acpica/nsxfeval.c Thread-Index: AQHQdcj5RVNkdZ26mU+FzZlxgfRzY51LZ+OA///O1rA= Date: Mon, 13 Apr 2015 17:42:45 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D2BD73F@ORSMSX112.amr.corp.intel.com> References: <1428915907-14302-1-git-send-email-gongzhaogang@inspur.com> <1536129.vQOiq1xQa9@vostro.rjw.lan> In-Reply-To: <1536129.vQOiq1xQa9@vostro.rjw.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t3DHgtDe005596 Yes, this comes up every now and then. "iff" means "if and only if" by convention. > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Monday, April 13, 2015 6:38 AM > To: Zhaogang Gong > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; lenb@kernel.org; linux- > acpi@vger.kernel.org; linux-kernel@vger.kernel.org; yanxiaofeng@inspur.com > Subject: Re: [PATCH] acpica: modify a commit error in file > drivers/acpi/acpica/nsxfeval.c > > On Monday, April 13, 2015 05:05:07 PM Zhaogang Gong wrote: > > Change "iff" in function acpi_evaluate_object() to "if". > > > > Signed-off-by: Zhaogang Gong > > --- > > drivers/acpi/acpica/nsxfeval.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpica/nsxfeval.c > > b/drivers/acpi/acpica/nsxfeval.c index b6030a2..9571429 100644 > > --- a/drivers/acpi/acpica/nsxfeval.c > > +++ b/drivers/acpi/acpica/nsxfeval.c > > @@ -214,7 +214,7 @@ acpi_evaluate_object(acpi_handle handle, > > info->prefix_node = NULL; > > } else if (!handle) { > > /* > > - * A handle is optional iff a fully qualified pathname is > specified. > > + * A handle is optional if a fully qualified pathname is > specified. > > This is not a mistake. > > > * Since we've already handled fully qualified names above, > this is > > * an error. > > */ > > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I