From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Moore, Robert" Subject: RE: 4.9-rc1: [TMP_] ACPI namespace lookup failure, AE_ALREADY_EXISTS Date: Thu, 27 Oct 2016 15:31:47 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E51855E@ORSMSX110.amr.corp.intel.com> References: <1476913001.7633.13.camel@intel.com> <1AE640813FDE7649BE1B193DEA596E886A256F5B@SHSMSX101.ccr.corp.intel.com> <1477216090.7258.9.camel@intel.com> <1AE640813FDE7649BE1B193DEA596E886A2579A5@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com ([134.134.136.31]:20358 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932768AbcJ0Pbu (ORCPT ); Thu, 27 Oct 2016 11:31:50 -0400 In-Reply-To: <1AE640813FDE7649BE1B193DEA596E886A2579A5@SHSMSX101.ccr.corp.intel.com> Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Zheng, Lv" , "Deak, Imre" , "Wysocki, Rafael J" , "linux-acpi@vger.kernel.org" , "devel@acpica.org" Cc: "Box, David E" DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogWmhlbmcsIEx2DQo+IFNl bnQ6IE1vbmRheSwgT2N0b2JlciAyNCwgMjAxNiAxMjozNiBBTQ0KPiBUbzogRGVhaywgSW1yZSA8 aW1yZS5kZWFrQGludGVsLmNvbT47IE1vb3JlLCBSb2JlcnQNCj4gPHJvYmVydC5tb29yZUBpbnRl bC5jb20+OyBXeXNvY2tpLCBSYWZhZWwgSg0KPiA8cmFmYWVsLmoud3lzb2NraUBpbnRlbC5jb20+ OyBsaW51eC1hY3BpQHZnZXIua2VybmVsLm9yZzsNCj4gZGV2ZWxAYWNwaWNhLm9yZw0KPiBTdWJq ZWN0OiBSRTogNC45LXJjMTogW1RNUF9dIEFDUEkgbmFtZXNwYWNlIGxvb2t1cCBmYWlsdXJlLA0K PiBBRV9BTFJFQURZX0VYSVNUUw0KPiANCj4gSGksIEltcmUNCj4gDQo+ID4gRnJvbTogRGVhaywg SW1yZQ0KPiA+IFN1YmplY3Q6IFJlOiA0LjktcmMxOiBbVE1QX10gQUNQSSBuYW1lc3BhY2UgbG9v a3VwIGZhaWx1cmUsDQo+ID4gQUVfQUxSRUFEWV9FWElTVFMNCj4gPg0KPiA+IE9uIEZyaSwgMjAx Ni0xMC0yMSBhdCAyMjo0NiArMDMwMCwgWmhlbmcsIEx2IHdyb3RlOg0KPiA+ID7CoFsuLi5dDQo+ ID4gPiBJIGNoZWNrZWQgdGhlIGNvZGUsIG9ubHkgZm91bmQgb25lIGlzc3VlLg0KPiA+ID4gQW5k IEknbSBub3Qgc3VyZSBpZiBpdCBpcyByZWxhdGVkLg0KPiA+ID4gUGxlYXNlIHNlbmQgbWUgdGhl IGZ1bGwgZG1lc2cgY29udGFpbmluZyB0aGUgZXJyb3JzIGFuZCB0aGUgYWNwaWR1bXANCj4gPiA+ b3V0cHV0Lg0KPiA+DQo+ID4gSSBhdHRhY2hlZCB0aGUgZG1lc2cgY29udGFpbmluZyB0aGUgZXJy b3IgZHVyaW5nIGJvb3QgKGhhcHBlbmVkIDEgb3V0DQo+ID4gb2YgMjAwIGJvb3RzKSwgZHVyaW5n IHJlYm9vdCAoMjAgb3V0IG9mIDIwMCByZWJvb3RzKSwgZHVyaW5nIHN1c3BlbmQNCj4gPiAoaGFw cGVuZWQgYWxsIHRoZSB0aW1lKS4NCj4gDQo+IEkganVzdCBjaGVja2VkIHRoZSBlcnJvciBhbmQg dGhlIHJlbGF0ZWQgY29kZS4NCj4gDQo+IDEuIFdoYXQgdGhlIGVycm9yIGlzDQo+IFRoZSBlcnJv ciBtZXNzYWdlIGlzIGdlbmVyYXRlZCBieSBhbiBvbGQgbWV0aG9kIGF1dG8tc2VyaWFsIG1lY2hh bmlzbS4NCj4gSG93ZXZlciB0aGlzIG1lY2hhbmlzbSBzaG91bGQgaGF2ZSBiZWVuIGRpc2FibGVk IGJ5IG5ldyBhdXRvLXNlcmlhbA0KPiBhcHByb2FjaC4NCltNb29yZSwgUm9iZXJ0XSANCg0KDQpX ZSBrZXB0IHRoZSBvcmlnaW5hbCBhdXRvLXNlcmlhbGl6ZSBtZWNoYW5pc20gYmVjYXVzZSB0aGUg bmV3IG9uZSBpcyBub3QgMTAwJSBkZXRlcm1pbmlzdGljLiBUaHVzLCB0aGUgb3JpZ2luYWwgbWVj aGFuaXNtIGlzIGEgZmFsbGJhY2sgY2FzZSwgdGhhdCBpcyB3aHkgaXQgaXMgc3RpbGwgdGhlcmUu IEl0IHNob3VsZCBub3QgYmUgcmVtb3ZlZC4NCg0KDQoNCg0KDQo+IA0KPiBTZWU6IHRoZSBlcnJv ciBpcyBnZW5lcmF0ZWQgYnkgdGhlIGNvZGUgaW4NCj4gZHJpdmVycy9hY3BpL2FjcGljYS9wc3Bh cnNlLmM6DQo+IAkJCWlmICgoc3RhdHVzID09IEFFX0FMUkVBRFlfRVhJU1RTKSAmJg0KPiAJCQkg ICAgKCEod2Fsa19zdGF0ZS0+bWV0aG9kX2Rlc2MtPm1ldGhvZC4NCj4gCQkJICAgICAgIGluZm9f ZmxhZ3MgJiBBQ1BJX01FVEhPRF9TRVJJQUxJWkVEKSkpIHsNCj4gCQkJCS8qDQo+IAkJCQkgKiBN ZXRob2QgaXMgbm90IHNlcmlhbGl6ZWQgYW5kIHRyaWVkIHRvIGNyZWF0ZSBhbg0KPiBvYmplY3QN Cj4gCQkJCSAqIHR3aWNlLiBUaGUgcHJvYmFibGUgY2F1c2UgaXMgdGhhdCB0aGUgbWV0aG9kDQo+ IGNhbm5vdA0KPiAJCQkJICogaGFuZGxlIHJlZW50cmFuY3kuIE1hcmsgYXMgInBlbmRpbmcgc2Vy aWFsaXplZCINCj4gbm93LCBhbmQNCj4gCQkJCSAqIHRoZW4gbWFyayAic2VyaWFsaXplZCIgd2hl biB0aGUgbGFzdCB0aHJlYWQNCj4gZXhpdHMuDQo+IAkJCQkgKi8NCj4gCQkJCXdhbGtfc3RhdGUt Pm1ldGhvZF9kZXNjLT5tZXRob2QuaW5mb19mbGFncyB8PQ0KPiAJCQkJICAgIEFDUElfTUVUSE9E X1NFUklBTElaRURfUEVORElORzsNCj4gCQkJfQ0KPiBJdCBjYW4gb25seSBoYXBwZW4gd2hlbiBB Q1BJX01FVEhPRF9TRVJJQUxJWkVEIGZsYWcgaXMgbm90IHNldC4NCj4gSG93ZXZlciwgaW4gdGhl IHVwc3RyZWFtIGtlcm5lbCwgdGhpcyBmbGFnIGlzIHNldCBieSB0aGUgY29kZSBpbg0KPiBkcml2 ZXJzL2FjcGkvYWNwaWNhL2RzaW5pdC5jOg0KPiAJCWlmIChvYmpfZGVzYy0+bWV0aG9kLmluZm9f ZmxhZ3MgJiBBQ1BJX01FVEhPRF9TRVJJQUxJWkVEKSB7DQo+IAkJCWluZm8tPnNlcmlhbF9tZXRo b2RfY291bnQrKzsNCj4gCQkJYnJlYWs7DQo+IAkJfQ0KPiANCj4gCQlpZiAoYWNwaV9nYmxfYXV0 b19zZXJpYWxpemVfbWV0aG9kcykgew0KPiANCj4gCQkJLyogUGFyc2Uvc2NhbiBtZXRob2QgYW5k IHNlcmlhbGl6ZSBpdCBpZiBuZWNlc3NhcnkgKi8NCj4gDQo+IAkJCWFjcGlfZHNfYXV0b19zZXJp YWxpemVfbWV0aG9kKG5vZGUsIG9ial9kZXNjKTsNCj4gCQkJaWYgKG9ial9kZXNjLT5tZXRob2Qu DQo+IAkJCSAgICBpbmZvX2ZsYWdzICYgQUNQSV9NRVRIT0RfU0VSSUFMSVpFRCkgew0KPiANCj4g CQkJCS8qIE1ldGhvZCB3YXMganVzdCBjb252ZXJ0ZWQgdG8gU2VyaWFsaXplZCAqLw0KPiANCj4g CQkJCWluZm8tPnNlcmlhbF9tZXRob2RfY291bnQrKzsNCj4gCQkJCWluZm8tPnNlcmlhbGl6ZWRf bWV0aG9kX2NvdW50Kys7DQo+IAkJCQlicmVhazsNCj4gCQkJfQ0KPiAJCX0NCj4gV2hpY2ggaXMg aW52b2tlZCBieSBhY3BpX2RzX2luaXRpYWxpemVfb2JqZWN0cygpLCBhbHdheXMgaW52b2tlZCBp bg0KPiBhY3BpX25zX2xvYWRfdGFibGUoKS4NCj4gVW5sZXNzIGFjcGlfZ2JsX2F1dG9fc2VyaWFs aXplX21ldGhvZHMgPSBmYWxzZSBvciBhY3BpX25zX3BhcnNlX3RhYmxlKCkNCj4gZmFpbGVkLCB0 aGUgZmxhZyB3b24ndCBiZSByZW1haW5lZCB1bnNldC4NCj4gDQo+IFRoZSBlcnJvciBtZXNzYWdl IGlzIGdlbmVyYXRlZCBieSBvbGQgYXV0by1zZXJpYWxpemUgaW1wbGVtZW50YXRpb24uDQo+IEFu ZCBhY3BpX2dibF9hdXRvX3NlcmlhbGl6ZV9tZXRob2RzIGlzIG1lYW50IHRvIG11dGUgdGhlIHdh cm5pbmdzLg0KPiANCj4gQm90aCBtZWNoYW5pc20gc2hvdWxkIHdvcmssIHRodXMgdGhpcyBlcnJv ciBtZXNzYWdlIGlzIG5vdCBmYXRhbC4NCj4gSXQganVzdCBtYWtlcyBBQ1BJQ0EgdG8gZmFsbCBi YWNrIHRvIHVzZSBvbGQgYXV0by1zZXJpYWwgbWV0aG9kLg0KPiBTbyB0aGUgaXNzdWUgaXMgbm90 IHVyZ2VudC4NCj4gDQo+IDIuIFdoeSB0aGUgZXJyb3IgbWVzc2FnZSBpcyBjYXVzZWQNCj4gSSBj b3VsZG4ndCBzZWUgd2hldGhlciB0aGUgYmlzZWN0ZWQgY29tbWl0IGNhbiBiZSByZWxhdGVkIHRv IHRoaXMNCj4gZmVhdHVyZS4NCj4gSXQgc2VlbXMgd2UgbmVlZCB5b3VyIGhlbHAgdG8gZGVidWcg d2hhdCB0aGUgcHJvYmxlbSBpcy4NCj4gDQo+IEZpcnN0LCBwbGVhc2UgdHJ5IHRoZSBtZW50aW9u ZWQgYnJhbmNoIGhlcmU6DQo+IGh0dHBzOi8vZ2l0aHViLmNvbS96ZXRhbG9nL2xpbnV4DQo+IGFj cGljYS1sb2NrIGJyYW5jaC4NCj4gDQo+IEFzIEkgbWF5IG5lZWQgdG8gYXNrIGZvciBzZXZlcmFs IGRlYnVnZ2luZyBzdGVwcywgbGV0IG1lIGZpbGUgYSBrZXJuZWwNCj4gQnVnemlsbGEgYnVnIGZv ciB0aGlzLg0KPiBTbyB0aGF0IHdlIGNhbiBjb21tdW5pY2F0ZSB0aGVyZSBpbiBvcmRlciBub3Qg dG8gYm90aGVyIG90aGVyczoNCj4gDQo+IGh0dHBzOi8vYnVnemlsbGEua2VybmVsLm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTgwMTExDQo+IA0KPiBUaGFua3MgYW5kIGJlc3QgcmVnYXJkcw0KPiBMdg0K PiANCj4gDQo+ID4NCj4gPiBJIGF0dGFjaGVkIHRoZSBhY3BpZHVtcCBvdXRwdXQuDQo+ID4NCj4g PiA+IFBsZWFzZSBnaXZlIHRoZSBmaXggYSB0cnkgKHNlZSBhdHRhY2htZW50KS4NCj4gPg0KPiA+ IFRoZSBwYXRjaCBkaWRuJ3QgYXBwbHkgb24gNC45LXJjMSBvciBMaW51cycgbWFzdGVyLCBwbGVh c2Ugc2VlIHRoZQ0KPiA+IGF0dGFjaGVkIHBhdGNoIGZvciBteSBhdHRlbXB0IHRvIHJlc29sdmUg dGhlIGNvbmZsaWN0cy4gV2l0aCB0aGUgcGF0Y2gNCj4gPiBhcHBsaWVkIEkgY291bGQgc3RpbGwg dHJpZ2dlciB0aGUgc2FtZSBwcm9ibGVtIGR1cmluZyBzdXNwZW5kLg0KPiA+DQo+ID4gLS1JbXJl DQo+ID4NCj4gPiA+IEknbSBzb3JyeSBmb3Igc2VuZGluZyBmaXggcGF0Y2ggdXNpbmcgYXR0YWNo bWVudC4NCj4gPiA+IEl0J3Mgbm90IGNvbnZlbmllbnQgZm9yIG1lIGR1ZSB0byBteSBjdXJyZW50 IHdvcmtpbmcgZW52aXJvbm1lbnQuDQo+ID4gPg0KPiA+ID4gVGhhbmtzIGFuZCBiZXN0IHJlZ2Fy ZHMNCj4gPiA+IEx2DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7765045290605642585==" MIME-Version: 1.0 From: Moore, Robert Subject: Re: [Devel] 4.9-rc1: [TMP_] ACPI namespace lookup failure, AE_ALREADY_EXISTS Date: Thu, 27 Oct 2016 15:31:47 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E51855E@ORSMSX110.amr.corp.intel.com> In-Reply-To: 1AE640813FDE7649BE1B193DEA596E886A2579A5@SHSMSX101.ccr.corp.intel.com List-ID: To: devel@acpica.org --===============7765045290605642585== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zheng, Lv > Sent: Monday, October 24, 2016 12:36 AM > To: Deak, Imre ; Moore, Robert > ; Wysocki, Rafael J > ; linux-acpi(a)vger.kernel.org; > devel(a)acpica.org > Subject: RE: 4.9-rc1: [TMP_] ACPI namespace lookup failure, > AE_ALREADY_EXISTS > = > Hi, Imre > = > > From: Deak, Imre > > Subject: Re: 4.9-rc1: [TMP_] ACPI namespace lookup failure, > > AE_ALREADY_EXISTS > > > > On Fri, 2016-10-21 at 22:46 +0300, Zheng, Lv wrote: > > >=C2=A0[...] > > > I checked the code, only found one issue. > > > And I'm not sure if it is related. > > > Please send me the full dmesg containing the errors and the acpidump > > >output. > > > > I attached the dmesg containing the error during boot (happened 1 out > > of 200 boots), during reboot (20 out of 200 reboots), during suspend > > (happened all the time). > = > I just checked the error and the related code. > = > 1. What the error is > The error message is generated by an old method auto-serial mechanism. > However this mechanism should have been disabled by new auto-serial > approach. [Moore, Robert] = We kept the original auto-serialize mechanism because the new one is not 10= 0% deterministic. Thus, the original mechanism is a fallback case, that is = why it is still there. It should not be removed. > = > See: the error is generated by the code in > drivers/acpi/acpica/psparse.c: > if ((status =3D=3D AE_ALREADY_EXISTS) && > (!(walk_state->method_desc->method. > info_flags & ACPI_METHOD_SERIALIZED))) { > /* > * Method is not serialized and tried to create an > object > * twice. The probable cause is that the method > cannot > * handle reentrancy. Mark as "pending serialized" > now, and > * then mark "serialized" when the last thread > exits. > */ > walk_state->method_desc->method.info_flags |=3D > ACPI_METHOD_SERIALIZED_PENDING; > } > It can only happen when ACPI_METHOD_SERIALIZED flag is not set. > However, in the upstream kernel, this flag is set by the code in > drivers/acpi/acpica/dsinit.c: > if (obj_desc->method.info_flags & ACPI_METHOD_SERIALIZED) { > info->serial_method_count++; > break; > } > = > if (acpi_gbl_auto_serialize_methods) { > = > /* Parse/scan method and serialize it if necessary */ > = > acpi_ds_auto_serialize_method(node, obj_desc); > if (obj_desc->method. > info_flags & ACPI_METHOD_SERIALIZED) { > = > /* Method was just converted to Serialized */ > = > info->serial_method_count++; > info->serialized_method_count++; > break; > } > } > Which is invoked by acpi_ds_initialize_objects(), always invoked in > acpi_ns_load_table(). > Unless acpi_gbl_auto_serialize_methods =3D false or acpi_ns_parse_table() > failed, the flag won't be remained unset. > = > The error message is generated by old auto-serialize implementation. > And acpi_gbl_auto_serialize_methods is meant to mute the warnings. > = > Both mechanism should work, thus this error message is not fatal. > It just makes ACPICA to fall back to use old auto-serial method. > So the issue is not urgent. > = > 2. Why the error message is caused > I couldn't see whether the bisected commit can be related to this > feature. > It seems we need your help to debug what the problem is. > = > First, please try the mentioned branch here: > https://github.com/zetalog/linux > acpica-lock branch. > = > As I may need to ask for several debugging steps, let me file a kernel > Bugzilla bug for this. > So that we can communicate there in order not to bother others: > = > https://bugzilla.kernel.org/show_bug.cgi?id=3D180111 > = > Thanks and best regards > Lv > = > = > > > > I attached the acpidump output. > > > > > Please give the fix a try (see attachment). > > > > The patch didn't apply on 4.9-rc1 or Linus' master, please see the > > attached patch for my attempt to resolve the conflicts. With the patch > > applied I could still trigger the same problem during suspend. > > > > --Imre > > > > > I'm sorry for sending fix patch using attachment. > > > It's not convenient for me due to my current working environment. > > > > > > Thanks and best regards > > > Lv --===============7765045290605642585==--