From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Moore, Robert" Subject: RE: [PATCH] ACPICA: use designated initializers Date: Tue, 4 Apr 2017 15:02:08 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E58F7BB@ORSMSX110.amr.corp.intel.com> References: <20161217010425.GA140581@beast> <1AE640813FDE7649BE1B193DEA596E886CDFF348@SHSMSX101.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E886CE6BD95@SHSMSX101.ccr.corp.intel.com> <94F2FBAB4432B54E8AACC7DFDE6C92E37E58F104@ORSMSX110.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com ([192.55.52.88]:36783 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753807AbdDDPDa (ORCPT ); Tue, 4 Apr 2017 11:03:30 -0400 In-Reply-To: Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Kees Cook Cc: "Zheng, Lv" , "linux-kernel@vger.kernel.org" , "Wysocki, Rafael J" , Len Brown , "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "Box, David E" , "Schmauss, Erik" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBrZWVzY29va0Bnb29nbGUuY29t IFttYWlsdG86a2Vlc2Nvb2tAZ29vZ2xlLmNvbV0gT24gQmVoYWxmIE9mIEtlZXMNCj4gQ29vaw0K PiBTZW50OiBNb25kYXksIEFwcmlsIDMsIDIwMTcgMTA6MjkgQU0NCj4gVG86IE1vb3JlLCBSb2Jl cnQgPHJvYmVydC5tb29yZUBpbnRlbC5jb20+DQo+IENjOiBaaGVuZywgTHYgPGx2LnpoZW5nQGlu dGVsLmNvbT47IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7DQo+IFd5c29ja2ksIFJhZmFl bCBKIDxyYWZhZWwuai53eXNvY2tpQGludGVsLmNvbT47IExlbiBCcm93bg0KPiA8bGVuYkBrZXJu ZWwub3JnPjsgbGludXgtYWNwaUB2Z2VyLmtlcm5lbC5vcmc7IGRldmVsQGFjcGljYS5vcmcNCj4g U3ViamVjdDogUmU6IFtQQVRDSF0gQUNQSUNBOiB1c2UgZGVzaWduYXRlZCBpbml0aWFsaXplcnMN Cj4gDQo+IE9uIEZyaSwgTWFyIDMxLCAyMDE3IGF0IDU6NDUgUE0sIE1vb3JlLCBSb2JlcnQgPHJv YmVydC5tb29yZUBpbnRlbC5jb20+DQo+IHdyb3RlOg0KPiA+IEFjcGljYSBpcyBidWlsdCB3aXRo IG1hbnkgY29tcGlsZXJzLCBldmVuIHZlcnkgb2xkIG9uZXMuIEl0IHJ1bnMgb24gYXQNCj4gbGVh c3QgMTIga25vd24gb3BlcmF0aW5nIHN5c3RlbXMsIGFuZCB2ZXJ5IHByb2JhYmx5IG1vcmUuDQo+ ID4NCj4gPiBJJ20gc29ycnksIGJ1dCBubywgd2UgYXJlIG5vdCBnb2luZyB0byBzdGFydCBhZGRp bmcgY29tcGlsZXItc3BlY2lmaWMNCj4gaWZkZWZzL2NvZGUgaW4gdGhlIGJhc2UgQUNQSUNBIGNv ZGUuDQo+ID4NCj4gPiBJIGRvbid0IGNhcmUgd2hhdCB5b3UgZG8gaW4gdGhlIExpbnV4LXNwZWNp ZmljIG9yIGdjYy1zcGVjaWZpYw0KPiBoZWFkZXJzLCBob3dldmVyLiBJZiB0aGlzIGJyZWFrcyBh IGN1c3RvbWVyIGJ1aWxkLCB3ZSAoeW91KSB3aWxsIGhlYXINCj4gYWJvdXQgaXQgcmF0aGVyIHF1 aWNrbHkuDQo+IA0KPiBTaW5jZSB0aGUgY2hhbmdlIGlzIHNwZWNpZmljIHRvIHRoZSBvbmUgcGxh Y2UgQUNQSUNBIHVzZXMgYW4gYWxsLQ0KPiBmdW5jdGlvbi1wb2ludGVyIHN0cnVjdHVyZSwgSSBt YWRlIHRoZSBjaGFuZ2UgbG9jYWw6DQo+IA0KPiBodHRwczovL2dpdGh1Yi5jb20vYWNwaWNhL2Fj cGljYS9wdWxsLzI0OA0KPiANCj4gd291bGQgeW91IHJhdGhlciB0aGlzIGlzIGluIHRoZSAuaCBm aWxlcyBpbnN0ZWFkPw0KPiANCj4gLUtlZXMNCj4gDQo+IC0tDQo+IEtlZXMgQ29vaw0KPiBQaXhl bCBTZWN1cml0eQ0KDQoNCg0KDQpbTW9vcmUsIFJvYmVydF0gDQoNCkkgaGF2ZSBzb21lIHF1ZXN0 aW9ucyBhYm91dCB0aGlzIGVudGlyZSBpc3N1ZToNCg0KKyAqIFNvbWUgY29tcGlsZXJzIGNhbiBo YW5kbGUgZGVzaWduYXRlZCBpbml0aWFsaXplcnMsIHdoaWNoIGlzIG5lZWRlZCAgDQorICogdW5k ZXIgTGludXgga2VybmVsIGJ1aWxkcyBmb3Igc3RydWN0dXJlcyB0aGF0IGFyZSBlbnRpcmVseSBm dW5jdGlvbiAgDQogICogcG9pbnRlcnMuICANCg0KSSBkb24ndCB1bmRlcnN0YW5kIHdoeSB0aGlz IGlzIGNvbWluZyB1cCBub3csIHNpbmNlIEFDUElDQSBoYXMgYmVlbiBpbnRlZ3JhdGVkIHdpdGgg TGludXggZm9yIHNvbWV0aGluZyBsaWtlIHRoZSBsYXN0IDE1IHllYXJzLiBJdCdzIHRoZSAid2hp Y2ggaXMgbmVlZGVkIHVuZGVyIExpbnV4IGtlcm5lbCBidWlsZHMiIHdvcmRpbmcgdGhhdCBjb25j ZXJucyBtZSB0aGUgbW9zdC4gQXJlIHlvdSBzYXlpbmcgdGhhdCB0aGUgQUNQSUNBIGJ1aWxkIGZv ciBMaW51eCBpcyBicm9rZW4gYW5kIGRvZXMgbm90IHdvcms/DQoNCkZ1cnRoZXIsIHRoZXJlIGFy ZSBxdWl0ZSBhIGZldyBzaW1pbGFyIGRpc3BhdGNoIHRhYmxlcyBpbiBBQ1BJQ0EsIHdoeSBhcmUg dGhlc2Ugbm90IGEgcHJvYmxlbT8NCg0KQm9iDQoNCg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6054400164637314282==" MIME-Version: 1.0 From: Moore, Robert Subject: Re: [Devel] [PATCH] ACPICA: use designated initializers Date: Tue, 04 Apr 2017 15:02:08 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37E58F7BB@ORSMSX110.amr.corp.intel.com> In-Reply-To: CAGXu5jJLQmxEcG6nLKn6fsib5meNpw4y1ZLO2F4ezA+jqF-6DA@mail.gmail.com List-ID: To: devel@acpica.org --===============6054400164637314282== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: keescook(a)google.com [mailto:keescook(a)google.com] On Behalf Of K= ees > Cook > Sent: Monday, April 3, 2017 10:29 AM > To: Moore, Robert > Cc: Zheng, Lv ; linux-kernel(a)vger.kernel.org; > Wysocki, Rafael J ; Len Brown > ; linux-acpi(a)vger.kernel.org; devel(a)acpica.org > Subject: Re: [PATCH] ACPICA: use designated initializers > = > On Fri, Mar 31, 2017 at 5:45 PM, Moore, Robert > wrote: > > Acpica is built with many compilers, even very old ones. It runs on at > least 12 known operating systems, and very probably more. > > > > I'm sorry, but no, we are not going to start adding compiler-specific > ifdefs/code in the base ACPICA code. > > > > I don't care what you do in the Linux-specific or gcc-specific > headers, however. If this breaks a customer build, we (you) will hear > about it rather quickly. > = > Since the change is specific to the one place ACPICA uses an all- > function-pointer structure, I made the change local: > = > https://github.com/acpica/acpica/pull/248 > = > would you rather this is in the .h files instead? > = > -Kees > = > -- > Kees Cook > Pixel Security [Moore, Robert] = I have some questions about this entire issue: + * Some compilers can handle designated initializers, which is needed = + * under Linux kernel builds for structures that are entirely function = * pointers. = I don't understand why this is coming up now, since ACPICA has been integra= ted with Linux for something like the last 15 years. It's the "which is nee= ded under Linux kernel builds" wording that concerns me the most. Are you s= aying that the ACPICA build for Linux is broken and does not work? Further, there are quite a few similar dispatch tables in ACPICA, why are t= hese not a problem? Bob --===============6054400164637314282==--