These all look good. (NamePathOffset and ObjectType changes) Make one or two pull requests if you'd like. Thanks, Bob > -----Original Message----- > From: Devel [mailto:devel-bounces(a)acpica.org] On Behalf Of Colin Ian > King > Sent: Wednesday, May 3, 2017 6:56 AM > To: devel(a)acpica.org > Subject: Re: [Devel] [PATCH] Remove redundant assignment to > NamepathOffset > > On 18/04/17 22:30, Colin King wrote: > > From: Colin Ian King > > > > NamepathOffset is being assigned and not used and the a few statements > > later it is being re-assigned, hence the earlier assignment is > > redundant and can be removed. Remove it. > > > > Signed-off-by: Colin Ian King > > --- > > source/compiler/asloffset.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/source/compiler/asloffset.c b/source/compiler/asloffset.c > > index e3fdf1c91..0964d4fea 100644 > > --- a/source/compiler/asloffset.c > > +++ b/source/compiler/asloffset.c > > @@ -250,7 +250,6 @@ LsAmlOffsetWalk ( > > } > > > > Length = Op->Asl.FinalAmlLength; > > - NamepathOffset = Gbl_CurrentAmlOffset + Length; > > > > /* Get to the NameSeg/NamePath Op (and length of the name) */ > > > > > Any chance this will be reviewed? > _______________________________________________ > Devel mailing list > Devel(a)acpica.org > https://lists.acpica.org/mailman/listinfo/devel