From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Moore, Robert" Subject: RE: [PATCH v2 0/5] ACPI: Do not call _STA on battery devices with unmet dependencies Date: Wed, 14 Feb 2018 15:28:07 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B7572CE8@ORSMSX110.amr.corp.intel.com> References: <20180122085135.16732-1-hdegoede@redhat.com> <3281375.11fh90aaLK@aspire.rjw.lan> <7efce3e1-4cb7-fa68-9024-73fa124b9171@redhat.com> <94F2FBAB4432B54E8AACC7DFDE6C92E3B7570FA0@ORSMSX110.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com ([192.55.52.115]:36837 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031353AbeBNP2I (ORCPT ); Wed, 14 Feb 2018 10:28:08 -0500 In-Reply-To: Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hans de Goede , "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" , "Schmauss, Erik" , "Box, David E" Cc: Len Brown , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "devel@acpica.org" DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSGFucyBkZSBHb2VkZSBb bWFpbHRvOmhkZWdvZWRlQHJlZGhhdC5jb21dDQo+IFNlbnQ6IFdlZG5lc2RheSwgRmVicnVhcnkg MTQsIDIwMTggMjozMyBBTQ0KPiBUbzogTW9vcmUsIFJvYmVydCA8cm9iZXJ0Lm1vb3JlQGludGVs LmNvbT47IFJhZmFlbCBKLiBXeXNvY2tpDQo+IDxyandAcmp3eXNvY2tpLm5ldD47IGxpbnV4LWFj cGlAdmdlci5rZXJuZWwub3JnOyBTY2htYXVzcywgRXJpaw0KPiA8ZXJpay5zY2htYXVzc0BpbnRl bC5jb20+OyBCb3gsIERhdmlkIEUgPGRhdmlkLmUuYm94QGludGVsLmNvbT4NCj4gQ2M6IExlbiBC cm93biA8bGVuYkBrZXJuZWwub3JnPjsgQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNv bT47DQo+IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7IGRldmVsQGFjcGljYS5vcmcNCj4gU3Vi amVjdDogUmU6IFtQQVRDSCB2MiAwLzVdIEFDUEk6IERvIG5vdCBjYWxsIF9TVEEgb24gYmF0dGVy eSBkZXZpY2VzDQo+IHdpdGggdW5tZXQgZGVwZW5kZW5jaWVzDQo+IA0KPiBIaSwNCj4gDQo+IE9u IDA4LTAyLTE4IDE4OjM0LCBNb29yZSwgUm9iZXJ0IHdyb3RlOg0KPiA+DQo+ID4NCj4gPj4+IFRo ZSBsYXN0IG9uZSBuZWVkcyB0byBnbyBpbiB2aWEgQUNQSUNBIGFueXdheSBvciB3ZSdsbCBuZWVk IHRvIGNhcnJ5DQo+ID4+PiBhIExpbnV4LXNwZWNpZmljIHJlcGxhY2VtZW50IGZvciBhY3BpX2dl dF9vYmplY3RfaW5mbygpLg0KPiA+Pg0KPiA+PiBBY2ssIEknbSBkaXNjdXNzaW5nIGhvdyB0byBw cm9jZWVkIHdpdGggdGhpcyB3aXRoIHRoZSBBQ1BJQ0EgcGVvcGxlLg0KPiA+Pg0KPiA+PiBSZWdh cmRzLA0KPiA+Pg0KPiA+PiBIYW5zDQo+ID4NCj4gPg0KPiA+IEkgbm9ybWFsbHkgZG9uJ3QgbGlr ZSB0byBjaGFuZ2UgZXh0ZXJuYWwgaW50ZXJmYWNlcyAodGhlIGJpZ2dlc3QNCj4gcmVhc29uIGJl aW5nIHRoZSBzaGVlciBudW1iZXIgb2YgZGlmZmVyZW50IE9TIHZlbmRvcnMgdGhhdCB1c2UgQUNQ SUNBKSwNCj4gYnV0IGluIHRoaXMgY2FzZSwgSSBmZWVsIGl0IG1heSBiZSBPSy4gVGhpcyBpbnRl cmZhY2UgaXMgcHJvYmFibHkgbm90DQo+IGhlYXZpbHkgdXNlZCwgYW5kIHRoZXJlIGlzIHByZWNl ZGVudCBmb3IgdGhpcyB3aGVuIHRoZSBpbnZvY2F0aW9uIG9mDQo+IF9TVUIgd2FzIHJlbW92ZWQu DQo+ID4NCj4gPiBPbiB0aGUgb3RoZXIgaGFuZCwgSSB0aGluayBJIHNhdyBpdCBtZW50aW9uZWQg dGhhdCBMaW51eCBjYWxscyB0aGlzDQo+IGludGVyZmFjZSBvbmx5IG9uY2UsIGlzIHRoaXMgY29y cmVjdD8NCj4gDQo+IE1vcmUgb3IgbGVzcywgTGludXggY2FsbHMgaXQgb25jZSB3aGVuIGVudW1l cmF0aW5nIGFsbCB0aGUgZGV2aWNlcyBhbmQgYQ0KPiBmZXcgQUNQSSBkcml2ZXJzIGNhbGwgaXQg YWdhaW4gdG8gZ2V0IHNvbWUgZXh0cmEgaW5mbyB0aGV5IG5lZWQuDQo+IA0KPiA+IElmIHNvLCBw ZXJoYXBzIGl0IHdvdWxkIGJlIGVhc2llc3QgdG8gc2ltcGx5IHJlbW92ZSB0aGlzIGNhbGwgYW5k IHVzZQ0KPiBkaXJlY3QgY29udHJvbCBtZXRob2QgaW52b2NhdGlvbnMgdG8gb2J0YWluIHRoZSBk ZXNpcmVkIGRhdGEuDQo+IA0KPiBJZiB3ZSBnbyB0aGlzIHJvdXRlIHdlIHdvdWxkIHByb2JhYmx5 IGVuZCB1cCBjb3B5aW5nIHRoZSBmdW5jdGlvbiwgc2luY2UNCj4gYXMgc2FpZCBzZXZlcmFsIGRy aXZlcnMgdXNlIGl0IHRvby4NCj4gDQo+ID4gSWYgd2UgZ28gYWhlYWQgYW5kIG1ha2UgdGhpcyBj aGFuZ2UgdG8gQUNQSUNBOiBJIGhhdmUgbm90IHNlZW4gdGhlDQo+IHBhdGNoLCBidXQgcGxlYXNl IG1ha2Ugc3VyZSB0aGF0IGFsbCB2ZXN0aWdlcyBvZiB0aGlzIGFyZSByZW1vdmVkLiBUaGlzDQo+ IGluY2x1ZGVzIGFsbCBpbnZvY2F0aW9ucyB3aXRoaW4gQUNQSUNBIHRoYXQgZXhhbWluZSB0aGUg cmVzdWx0IG9mIHRoZQ0KPiBfU1RBIGludm9jYXRpb24sIHRoZSBDdXJyZW50U3RhdHVzIGZpZWxk IG9mIEFDUElfREVWSUNFX0lORk8sIHRoZQ0KPiBBQ1BJX1ZBTElEX1NUQSBmbGFnLCBldGMuDQo+ IA0KPiBUaGUgcGF0Y2ggYWxyZWFkeSBkb2VzIHRoYXQ6DQo+IA0KPiBodHRwczovL3BhdGNod29y ay5rZXJuZWwub3JnL3BhdGNoLzEwMTg2MTk1Lw0KPiANCg0KDQpPZiBjb3Vyc2UsIHdlIHdpbGwg bmVlZCB0aGUgQUNQSUNBIHZlcnNpb24gb2YgdGhlIHBhdGNoLCBub3QgdGhlICJsaW51eGl6ZWQi IHZlcnNpb24uDQpCb2INCg0KDQoNCj4gUmVnYXJkcywNCj4gDQo+IEhhbnMNCj4gDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Moore, Robert" To: Hans de Goede , "Rafael J. Wysocki" , "linux-acpi@vger.kernel.org" , "Schmauss, Erik" , "Box, David E" CC: Len Brown , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "devel@acpica.org" Subject: RE: [PATCH v2 0/5] ACPI: Do not call _STA on battery devices with unmet dependencies Date: Wed, 14 Feb 2018 15:28:07 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B7572CE8@ORSMSX110.amr.corp.intel.com> References: <20180122085135.16732-1-hdegoede@redhat.com> <3281375.11fh90aaLK@aspire.rjw.lan> <7efce3e1-4cb7-fa68-9024-73fa124b9171@redhat.com> <94F2FBAB4432B54E8AACC7DFDE6C92E3B7570FA0@ORSMSX110.amr.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-acpi-owner@vger.kernel.org List-ID: DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSGFucyBkZSBHb2VkZSBb bWFpbHRvOmhkZWdvZWRlQHJlZGhhdC5jb21dDQo+IFNlbnQ6IFdlZG5lc2RheSwgRmVicnVhcnkg MTQsIDIwMTggMjozMyBBTQ0KPiBUbzogTW9vcmUsIFJvYmVydCA8cm9iZXJ0Lm1vb3JlQGludGVs LmNvbT47IFJhZmFlbCBKLiBXeXNvY2tpDQo+IDxyandAcmp3eXNvY2tpLm5ldD47IGxpbnV4LWFj cGlAdmdlci5rZXJuZWwub3JnOyBTY2htYXVzcywgRXJpaw0KPiA8ZXJpay5zY2htYXVzc0BpbnRl bC5jb20+OyBCb3gsIERhdmlkIEUgPGRhdmlkLmUuYm94QGludGVsLmNvbT4NCj4gQ2M6IExlbiBC cm93biA8bGVuYkBrZXJuZWwub3JnPjsgQmpvcm4gSGVsZ2FhcyA8YmhlbGdhYXNAZ29vZ2xlLmNv bT47DQo+IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7IGRldmVsQGFjcGljYS5vcmcNCj4gU3Vi amVjdDogUmU6IFtQQVRDSCB2MiAwLzVdIEFDUEk6IERvIG5vdCBjYWxsIF9TVEEgb24gYmF0dGVy eSBkZXZpY2VzDQo+IHdpdGggdW5tZXQgZGVwZW5kZW5jaWVzDQo+IA0KPiBIaSwNCj4gDQo+IE9u IDA4LTAyLTE4IDE4OjM0LCBNb29yZSwgUm9iZXJ0IHdyb3RlOg0KPiA+DQo+ID4NCj4gPj4+IFRo ZSBsYXN0IG9uZSBuZWVkcyB0byBnbyBpbiB2aWEgQUNQSUNBIGFueXdheSBvciB3ZSdsbCBuZWVk IHRvIGNhcnJ5DQo+ID4+PiBhIExpbnV4LXNwZWNpZmljIHJlcGxhY2VtZW50IGZvciBhY3BpX2dl dF9vYmplY3RfaW5mbygpLg0KPiA+Pg0KPiA+PiBBY2ssIEknbSBkaXNjdXNzaW5nIGhvdyB0byBw cm9jZWVkIHdpdGggdGhpcyB3aXRoIHRoZSBBQ1BJQ0EgcGVvcGxlLg0KPiA+Pg0KPiA+PiBSZWdh cmRzLA0KPiA+Pg0KPiA+PiBIYW5zDQo+ID4NCj4gPg0KPiA+IEkgbm9ybWFsbHkgZG9uJ3QgbGlr ZSB0byBjaGFuZ2UgZXh0ZXJuYWwgaW50ZXJmYWNlcyAodGhlIGJpZ2dlc3QNCj4gcmVhc29uIGJl aW5nIHRoZSBzaGVlciBudW1iZXIgb2YgZGlmZmVyZW50IE9TIHZlbmRvcnMgdGhhdCB1c2UgQUNQ SUNBKSwNCj4gYnV0IGluIHRoaXMgY2FzZSwgSSBmZWVsIGl0IG1heSBiZSBPSy4gVGhpcyBpbnRl cmZhY2UgaXMgcHJvYmFibHkgbm90DQo+IGhlYXZpbHkgdXNlZCwgYW5kIHRoZXJlIGlzIHByZWNl ZGVudCBmb3IgdGhpcyB3aGVuIHRoZSBpbnZvY2F0aW9uIG9mDQo+IF9TVUIgd2FzIHJlbW92ZWQu DQo+ID4NCj4gPiBPbiB0aGUgb3RoZXIgaGFuZCwgSSB0aGluayBJIHNhdyBpdCBtZW50aW9uZWQg dGhhdCBMaW51eCBjYWxscyB0aGlzDQo+IGludGVyZmFjZSBvbmx5IG9uY2UsIGlzIHRoaXMgY29y cmVjdD8NCj4gDQo+IE1vcmUgb3IgbGVzcywgTGludXggY2FsbHMgaXQgb25jZSB3aGVuIGVudW1l cmF0aW5nIGFsbCB0aGUgZGV2aWNlcyBhbmQgYQ0KPiBmZXcgQUNQSSBkcml2ZXJzIGNhbGwgaXQg YWdhaW4gdG8gZ2V0IHNvbWUgZXh0cmEgaW5mbyB0aGV5IG5lZWQuDQo+IA0KPiA+IElmIHNvLCBw ZXJoYXBzIGl0IHdvdWxkIGJlIGVhc2llc3QgdG8gc2ltcGx5IHJlbW92ZSB0aGlzIGNhbGwgYW5k IHVzZQ0KPiBkaXJlY3QgY29udHJvbCBtZXRob2QgaW52b2NhdGlvbnMgdG8gb2J0YWluIHRoZSBk ZXNpcmVkIGRhdGEuDQo+IA0KPiBJZiB3ZSBnbyB0aGlzIHJvdXRlIHdlIHdvdWxkIHByb2JhYmx5 IGVuZCB1cCBjb3B5aW5nIHRoZSBmdW5jdGlvbiwgc2luY2UNCj4gYXMgc2FpZCBzZXZlcmFsIGRy aXZlcnMgdXNlIGl0IHRvby4NCj4gDQo+ID4gSWYgd2UgZ28gYWhlYWQgYW5kIG1ha2UgdGhpcyBj aGFuZ2UgdG8gQUNQSUNBOiBJIGhhdmUgbm90IHNlZW4gdGhlDQo+IHBhdGNoLCBidXQgcGxlYXNl IG1ha2Ugc3VyZSB0aGF0IGFsbCB2ZXN0aWdlcyBvZiB0aGlzIGFyZSByZW1vdmVkLiBUaGlzDQo+ IGluY2x1ZGVzIGFsbCBpbnZvY2F0aW9ucyB3aXRoaW4gQUNQSUNBIHRoYXQgZXhhbWluZSB0aGUg cmVzdWx0IG9mIHRoZQ0KPiBfU1RBIGludm9jYXRpb24sIHRoZSBDdXJyZW50U3RhdHVzIGZpZWxk IG9mIEFDUElfREVWSUNFX0lORk8sIHRoZQ0KPiBBQ1BJX1ZBTElEX1NUQSBmbGFnLCBldGMuDQo+ IA0KPiBUaGUgcGF0Y2ggYWxyZWFkeSBkb2VzIHRoYXQ6DQo+IA0KPiBodHRwczovL3BhdGNod29y ay5rZXJuZWwub3JnL3BhdGNoLzEwMTg2MTk1Lw0KPiANCg0KDQpPZiBjb3Vyc2UsIHdlIHdpbGwg bmVlZCB0aGUgQUNQSUNBIHZlcnNpb24gb2YgdGhlIHBhdGNoLCBub3QgdGhlICJsaW51eGl6ZWQi IHZlcnNpb24uDQpCb2INCg0KDQoNCj4gUmVnYXJkcywNCj4gDQo+IEhhbnMNCj4gDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4852876812202001303==" MIME-Version: 1.0 From: Moore, Robert Subject: Re: [Devel] [PATCH v2 0/5] ACPI: Do not call _STA on battery devices with unmet dependencies Date: Wed, 14 Feb 2018 15:28:07 +0000 Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B7572CE8@ORSMSX110.amr.corp.intel.com> In-Reply-To: a62364ba-7b79-6bb0-20a3-c66cb166e923@redhat.com List-ID: To: devel@acpica.org --===============4852876812202001303== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Hans de Goede [mailto:hdegoede(a)redhat.com] > Sent: Wednesday, February 14, 2018 2:33 AM > To: Moore, Robert ; Rafael J. Wysocki > ; linux-acpi(a)vger.kernel.org; Schmauss, Erik > ; Box, David E > Cc: Len Brown ; Bjorn Helgaas ; > linux-pci(a)vger.kernel.org; devel(a)acpica.org > Subject: Re: [PATCH v2 0/5] ACPI: Do not call _STA on battery devices > with unmet dependencies > = > Hi, > = > On 08-02-18 18:34, Moore, Robert wrote: > > > > > >>> The last one needs to go in via ACPICA anyway or we'll need to carry > >>> a Linux-specific replacement for acpi_get_object_info(). > >> > >> Ack, I'm discussing how to proceed with this with the ACPICA people. > >> > >> Regards, > >> > >> Hans > > > > > > I normally don't like to change external interfaces (the biggest > reason being the sheer number of different OS vendors that use ACPICA), > but in this case, I feel it may be OK. This interface is probably not > heavily used, and there is precedent for this when the invocation of > _SUB was removed. > > > > On the other hand, I think I saw it mentioned that Linux calls this > interface only once, is this correct? > = > More or less, Linux calls it once when enumerating all the devices and a > few ACPI drivers call it again to get some extra info they need. > = > > If so, perhaps it would be easiest to simply remove this call and use > direct control method invocations to obtain the desired data. > = > If we go this route we would probably end up copying the function, since > as said several drivers use it too. > = > > If we go ahead and make this change to ACPICA: I have not seen the > patch, but please make sure that all vestiges of this are removed. This > includes all invocations within ACPICA that examine the result of the > _STA invocation, the CurrentStatus field of ACPI_DEVICE_INFO, the > ACPI_VALID_STA flag, etc. > = > The patch already does that: > = > https://patchwork.kernel.org/patch/10186195/ > = Of course, we will need the ACPICA version of the patch, not the "linuxized= " version. Bob > Regards, > = > Hans > = --===============4852876812202001303==--