From: Tariq Toukan <tariqt@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Tariq Toukan <tariqt@mellanox.com>
Cc: David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] ip-address: Fix negative prints of large TX rate limits
Date: Thu, 8 Mar 2018 17:56:50 +0200 [thread overview]
Message-ID: <94a4561b-34f3-47cd-75ec-5976c708b6fe@mellanox.com> (raw)
In-Reply-To: <20180308073837.7c21b7d2@xeon-e3>
On 08/03/2018 5:38 PM, Stephen Hemminger wrote:
> On Thu, 8 Mar 2018 15:48:27 +0200
> Tariq Toukan <tariqt@mellanox.com> wrote:
>
>> if (vf_tx_rate->rate)
>> print_int(PRINT_ANY,
>> "tx_rate",
>> - ", tx rate %d (Mbps)",
>> + ", tx rate %u (Mbps)",
>> vf_tx_rate->rate)
>
> JSON output has same sign bug. You need to use print_uint here.
>
Thanks Stephen, I'm fixing it...
prev parent reply other threads:[~2018-03-08 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 13:48 [PATCH iproute2-next] ip-address: Fix negative prints of large TX rate limits Tariq Toukan
2018-03-08 15:38 ` Stephen Hemminger
2018-03-08 15:56 ` Tariq Toukan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a4561b-34f3-47cd-75ec-5976c708b6fe@mellanox.com \
--to=tariqt@mellanox.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.