From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>, Hongyan Xia <hx242@xen.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction"
Date: Tue, 24 Mar 2020 18:39:54 +0000 [thread overview]
Message-ID: <94abc4e0-b11e-df0f-3e3c-c3a61d87c63a@xen.org> (raw)
In-Reply-To: <37dcd2d8-8ffe-a58e-4c7a-6dafc935b1c1@suse.com>
On 24/03/2020 16:13, Jan Beulich wrote:
> On 24.03.2020 16:21, Hongyan Xia wrote:
>> From: Hongyan Xia <hongyxia@amazon.com>
>> In contrast,
>> after dropping that commit, parallel domain destructions will just fail
>> to take the domctl lock, creating a hypercall continuation and backing
>> off immediately, allowing the thread that holds the lock to destroy a
>> domain much more quickly and allowing backed-off threads to process
>> events and irqs.
>>
>> On a 144-core server with 4TiB of memory, destroying 32 guests (each
>> with 4 vcpus and 122GiB memory) simultaneously takes:
>>
>> before the revert: 29 minutes
>> after the revert: 6 minutes
>
> This wants comparing against numbers demonstrating the bad effects of
> the global domctl lock. Iirc they were quite a bit higher than 6 min,
> perhaps depending on guest properties.
Your original commit message doesn't contain any clue in which cases the
domctl lock was an issue. So please provide information on the setups
you think it will make it worse.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2020-03-24 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 15:21 [Xen-devel] [PATCH] Revert "domctl: improve locking during domain destruction" Hongyan Xia
2020-03-24 16:13 ` Jan Beulich
2020-03-24 18:39 ` Julien Grall [this message]
2020-03-25 7:11 ` Jan Beulich
2020-03-26 14:39 ` Hongyan Xia
2020-03-26 16:55 ` Jim Fehlig
2020-03-31 10:31 ` Julien Grall
2020-03-24 18:40 ` [Xen-devel] " Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94abc4e0-b11e-df0f-3e3c-c3a61d87c63a@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=hx242@xen.org \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.