From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C6E5C433DB for ; Thu, 25 Feb 2021 08:44:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08B0564E4D for ; Thu, 25 Feb 2021 08:44:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08B0564E4D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.89645.169006 (Exim 4.92) (envelope-from ) id 1lFCG4-0005Gl-Lu; Thu, 25 Feb 2021 08:44:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 89645.169006; Thu, 25 Feb 2021 08:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFCG4-0005Ge-It; Thu, 25 Feb 2021 08:44:28 +0000 Received: by outflank-mailman (input) for mailman id 89645; Thu, 25 Feb 2021 08:44:27 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFCG3-0005GZ-ES for xen-devel@lists.xenproject.org; Thu, 25 Feb 2021 08:44:27 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 2b4e0ab0-18d1-42e3-b3fe-4e8ad6d7d889; Thu, 25 Feb 2021 08:44:26 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 209F2AAAE; Thu, 25 Feb 2021 08:44:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b4e0ab0-18d1-42e3-b3fe-4e8ad6d7d889 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614242665; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IjcG979P0LrZO32+Aw+dI+CvT5gBaMVcpWx8utENdVI=; b=SzpblRe2678xaohXvjP30pPO3PL1TvD4YBz0YbppEPzT9Bq4d8sx32S1wtjeHHYQxLSuop i5MlbBzmAYgJFzaHoazydofU8pIgwqlUnO8fMjpRMj5uwqRz2x8P6XORvR8PPctXZsf2Kw UtVyAHFsBO4jDeS1ljq2t1vfYeZa3co= Subject: Re: [PATCH v3 1/2][4.15] VMX: delay p2m insertion of APIC access page From: Jan Beulich To: Kevin Tian , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , Jun Nakajima Cc: Wei Liu , Ian Jackson , George Dunlap , Julien Grall , "xen-devel@lists.xenproject.org" References: <4731a3a3-906a-98ac-11ba-6a0723903391@suse.com> <90271e69-c07e-a32c-5531-a79b10ef03dd@suse.com> Message-ID: <94ac725c-ae3a-5380-aaa0-c8523074b581@suse.com> Date: Thu, 25 Feb 2021 09:44:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <90271e69-c07e-a32c-5531-a79b10ef03dd@suse.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 22.02.2021 11:56, Jan Beulich wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -428,6 +428,14 @@ static void vmx_domain_relinquish_resour > vmx_free_vlapic_mapping(d); > } > > +static void domain_creation_finished(struct domain *d) > +{ > + if ( has_vlapic(d) && !mfn_eq(d->arch.hvm.vmx.apic_access_mfn, _mfn(0)) && > + set_mmio_p2m_entry(d, gaddr_to_gfn(APIC_DEFAULT_PHYS_BASE), > + d->arch.hvm.vmx.apic_access_mfn, PAGE_ORDER_4K) ) > + domain_crash(d); > +} Having noticed that in patch 2 I also need to arrange for ept_get_entry_emt() to continue to return WB for this page, I'm inclined to add a respective assertion here. Would anyone object to me doing so? Kevin, Jun - I'd like this to also serve as a ping for an ack (with or without the suggested ASSERT() addition). Jan